From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71843C2D0BF for ; Mon, 16 Dec 2019 08:49:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3ECBF206D3 for ; Mon, 16 Dec 2019 08:49:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dJ58NKxp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727015AbfLPItv (ORCPT ); Mon, 16 Dec 2019 03:49:51 -0500 Received: from mail-ot1-f47.google.com ([209.85.210.47]:41117 "EHLO mail-ot1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726772AbfLPItv (ORCPT ); Mon, 16 Dec 2019 03:49:51 -0500 Received: by mail-ot1-f47.google.com with SMTP id r27so8211115otc.8; Mon, 16 Dec 2019 00:49:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4xOLwi7XGa06O+FcZfECpskN3Lf2VXslN2VEftJlRvg=; b=dJ58NKxpobcoCFcVrixIygWkFd2lRYRcK62+F0oqTQy0PfcLrohbjZ/4794t+zXWew 6YLPUjhuSc++1fWNSHL/u93PNyCv2AvGz6o5coEvJZP3/hXPveU7fhP50DZUhQl1cz7m V5fbw5287Yw5Yh7oHOP+LKFl2v6NCNjzpdDHSpDJqcHwSxuqAjcA54zuTxIvsu+dfUvy UjipEEgIYB2tmihK3Vq8xjpTJ7WIBIUSWu1i2WoVVYyGSEL2gBFGJRoiUBwuf9+OYdfq fv/+7QQ5mAQxYsEukysEKYsNNsRRs/bU9NflxHI5EA4lz+ZI6DUvHdRkPSA7tteynrLD HAbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4xOLwi7XGa06O+FcZfECpskN3Lf2VXslN2VEftJlRvg=; b=Nfe4K/bYqsEzecM5mGaT1laPBKUT0gxjznuZ8Zoc0U04SFNPoxLReKv++1M1m65073 guSmbiC9WaJst9L6wc7WPeVzSo/kK3GPxJtkIukzkN/Eu3B18iQw9CF4H3yfvuHVhNxo efDEEEkdLHXt+/P8be1q1lQnkfJ7GKdXrFnqtfCDAQgyu/jZFrnnAZzqWisIikHniNSo SNLoHQN2D2JMTvm8sbufodDw9l5WUdb7NuSE7Moa1ePnAyuMlJ9FcbIclt79rY0P42lm xEJa9DMiW135os1/fRglkqv33+TFiQcN5ejCkcaFdz/wcDq4xwYqnKBzWt4ZTFP3+LkS JYDA== X-Gm-Message-State: APjAAAWVndGIal8uv+3/eXXmGtT69aW8hwwgb2dp0enbGiD/4aECeqZT lyN4h5uPrT6fM9tTMHWJuiNRJRHnp5iV+6WB/2A= X-Google-Smtp-Source: APXvYqwlbGXOP54hraUBXqLyvcB1sZC55s35DdLDVTvMlWDnFYSYzIpnhC0yoc7BBbnE7hMFzhGGWwdDVzlod+Kll6g= X-Received: by 2002:a05:6830:16d0:: with SMTP id l16mr31683433otr.176.1576486189948; Mon, 16 Dec 2019 00:49:49 -0800 (PST) MIME-Version: 1.0 References: <20191213084748.11210-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20191213084748.11210-4-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Mon, 16 Dec 2019 08:49:23 +0000 Message-ID: Subject: Re: [v2 3/6] of: address: add support to parse PCI outbound-ranges To: Rob Herring Cc: Bjorn Helgaas , Mark Rutland , Geert Uytterhoeven , Magnus Damm , Kishon Vijay Abraham I , Marek Vasut , Yoshihiro Shimoda , PCI , Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Andrew Murray , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Chris Paterson , Frank Rowand , Gustavo Pimentel , Jingoo Han , Simon Horman , Shawn Lin , Tom Joseph , Heiko Stuebner , "open list:ARM/Rockchip SoC..." , "Lad, Prabhakar" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Thank you for the review. On Fri, Dec 13, 2019 at 8:37 PM Rob Herring wrote: > > On Fri, Dec 13, 2019 at 2:48 AM Lad Prabhakar > wrote: > > > > From: "Lad, Prabhakar" > > > > this patch adds support to parse PCI outbound-ranges, the > > outbound-regions are similar to pci ranges except it doesn't > > have pci address, below is the format for bar-ranges: > > > > outbound-ranges = > upper32_size lower32_size>; > > You can't just make up a new ranges property. Especially one that > doesn't follow how 'ranges' works. We already have 'dma-ranges' to > translate device to memory addresses. > > Explain the problem or feature you need, not the solution you came up > with. Why do you need this and other endpoint bindings haven't? > rcar SoC's supports multiple outbound region for mapping the PCI address locally to the system. This lead to discussion where there exist controllers which support regions for high/low priority transfer and similarly regions for large/small memory allocations, as a result a new ranges property was added, where we can specify the flags which would indicate how the outbound region can be used during requests. The current endpoint controller drivers just support single region. Cheers, --Prabhakar From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Lad, Prabhakar" Subject: Re: [v2 3/6] of: address: add support to parse PCI outbound-ranges Date: Mon, 16 Dec 2019 08:49:23 +0000 Message-ID: References: <20191213084748.11210-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20191213084748.11210-4-prabhakar.mahadev-lad.rj@bp.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Bjorn Helgaas , Mark Rutland , Geert Uytterhoeven , Magnus Damm , Kishon Vijay Abraham I , Marek Vasut , Yoshihiro Shimoda , PCI , Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Andrew Murray , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , moderated list:ARM/FREESCALE IMX / List-Id: linux-rockchip.vger.kernel.org Hi Rob, Thank you for the review. On Fri, Dec 13, 2019 at 8:37 PM Rob Herring wrote: > > On Fri, Dec 13, 2019 at 2:48 AM Lad Prabhakar > wrote: > > > > From: "Lad, Prabhakar" > > > > this patch adds support to parse PCI outbound-ranges, the > > outbound-regions are similar to pci ranges except it doesn't > > have pci address, below is the format for bar-ranges: > > > > outbound-ranges = > upper32_size lower32_size>; > > You can't just make up a new ranges property. Especially one that > doesn't follow how 'ranges' works. We already have 'dma-ranges' to > translate device to memory addresses. > > Explain the problem or feature you need, not the solution you came up > with. Why do you need this and other endpoint bindings haven't? > rcar SoC's supports multiple outbound region for mapping the PCI address locally to the system. This lead to discussion where there exist controllers which support regions for high/low priority transfer and similarly regions for large/small memory allocations, as a result a new ranges property was added, where we can specify the flags which would indicate how the outbound region can be used during requests. The current endpoint controller drivers just support single region. Cheers, --Prabhakar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C7A7C43603 for ; Mon, 16 Dec 2019 08:53:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EC3420725 for ; Mon, 16 Dec 2019 08:53:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V3JHyafn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dJ58NKxp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EC3420725 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t01cQqd6SFAEd5Y7QDvD/v7Sj8YE6dbjWBcH+N+++fQ=; b=V3JHyafnbLNgiS OlV5VRi/3FglG8HG64oBzIPoCBqbBVC5oVL2ZhD9LD6lcoUs8se0FXfYQfkGrJCB+kk2nSfyQhy/l 8g5E2NQLbQuNWUT+MXdY5VK0J8tMC7N3OkzhFHFjPfFov5VRhLi/AvSGBxe3nyEa9aXZWZ4j8lbH4 HeFHCD44DTQnCPCOiwwQRLwt6VnwiUKOtTcKeKfPTqdmmViZf/ymUQLiK6rDq282JChTnIQt0cnsE Dh2TnWgEZ0DM0fyx9pAU4ahtlrSxCp4fPHQd1UtBAKv4RdANOXhyRgWHnBpIiq+r9DqggRTjyxyvP 0sSOmRoH/KTxIqsjgYGQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1igm8B-00025X-1v; Mon, 16 Dec 2019 08:53:31 +0000 Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1igm4d-0005yt-Hw; Mon, 16 Dec 2019 08:49:59 +0000 Received: by mail-ot1-x336.google.com with SMTP id i15so8226393oto.7; Mon, 16 Dec 2019 00:49:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4xOLwi7XGa06O+FcZfECpskN3Lf2VXslN2VEftJlRvg=; b=dJ58NKxpobcoCFcVrixIygWkFd2lRYRcK62+F0oqTQy0PfcLrohbjZ/4794t+zXWew 6YLPUjhuSc++1fWNSHL/u93PNyCv2AvGz6o5coEvJZP3/hXPveU7fhP50DZUhQl1cz7m V5fbw5287Yw5Yh7oHOP+LKFl2v6NCNjzpdDHSpDJqcHwSxuqAjcA54zuTxIvsu+dfUvy UjipEEgIYB2tmihK3Vq8xjpTJ7WIBIUSWu1i2WoVVYyGSEL2gBFGJRoiUBwuf9+OYdfq fv/+7QQ5mAQxYsEukysEKYsNNsRRs/bU9NflxHI5EA4lz+ZI6DUvHdRkPSA7tteynrLD HAbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4xOLwi7XGa06O+FcZfECpskN3Lf2VXslN2VEftJlRvg=; b=pLXvhFvaACXNuRmoIZq5SMcLVako6u8YYF2WLBQrVz/hcPGV9eie/Qk4UZdYot5aFW NI3GDAjcsaQy2FrrJWY9qQfAnzoD9sG4fWd/GHXigLVNPaoYl4JfCLwy+qyef7svITxg 4hYKP8ObRNynFqns2UcTv2mEE768Vx0lMJocMh67+nhTvbD4Q0OQEZ+Gmm+Q/0ozQZpJ Ealksq65GiS5tTzdGKuFAH7v8kaGdmO+fg9u2stovrTyWl+66BeIt9D25NKUCkVjcFai wPW+zJSoSVWKu57qzpnNfee/RnptrB5oU7oZkibeNhWr3MJekCN87IfVRANnAth/kJ6h 7oLg== X-Gm-Message-State: APjAAAVwrare+YSl5nMy22LivmdoUnGzogUinILJC+h//hAAxPFawxOa 4ASfMRpu00yrEFfzm4RgCyJXvSMkdttmvxSi5l0= X-Google-Smtp-Source: APXvYqwlbGXOP54hraUBXqLyvcB1sZC55s35DdLDVTvMlWDnFYSYzIpnhC0yoc7BBbnE7hMFzhGGWwdDVzlod+Kll6g= X-Received: by 2002:a05:6830:16d0:: with SMTP id l16mr31683433otr.176.1576486189948; Mon, 16 Dec 2019 00:49:49 -0800 (PST) MIME-Version: 1.0 References: <20191213084748.11210-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20191213084748.11210-4-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Mon, 16 Dec 2019 08:49:23 +0000 Message-ID: Subject: Re: [v2 3/6] of: address: add support to parse PCI outbound-ranges To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191216_004951_702573_72C39D96 X-CRM114-Status: GOOD ( 14.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Heiko Stuebner , Geert Uytterhoeven , PCI , Shawn Lin , Frank Rowand , Marek Vasut , Lorenzo Pieralisi , Will Deacon , Magnus Damm , Kishon Vijay Abraham I , "open list:ARM/Rockchip SoC..." , Catalin Marinas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Chris Paterson , Arnd Bergmann , "Lad, Prabhakar" , Simon Horman , Bjorn Helgaas , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Greg Kroah-Hartman , Yoshihiro Shimoda , "linux-kernel@vger.kernel.org" , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Tom Joseph , Jingoo Han , Andrew Murray , Gustavo Pimentel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, Thank you for the review. On Fri, Dec 13, 2019 at 8:37 PM Rob Herring wrote: > > On Fri, Dec 13, 2019 at 2:48 AM Lad Prabhakar > wrote: > > > > From: "Lad, Prabhakar" > > > > this patch adds support to parse PCI outbound-ranges, the > > outbound-regions are similar to pci ranges except it doesn't > > have pci address, below is the format for bar-ranges: > > > > outbound-ranges = > upper32_size lower32_size>; > > You can't just make up a new ranges property. Especially one that > doesn't follow how 'ranges' works. We already have 'dma-ranges' to > translate device to memory addresses. > > Explain the problem or feature you need, not the solution you came up > with. Why do you need this and other endpoint bindings haven't? > rcar SoC's supports multiple outbound region for mapping the PCI address locally to the system. This lead to discussion where there exist controllers which support regions for high/low priority transfer and similarly regions for large/small memory allocations, as a result a new ranges property was added, where we can specify the flags which would indicate how the outbound region can be used during requests. The current endpoint controller drivers just support single region. Cheers, --Prabhakar _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel