From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from mail-lb0-f181.google.com ([209.85.217.181]:33846 "EHLO
	mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753242AbbDPKDi (ORCPT
	<rfc822;linux-media@vger.kernel.org>);
	Thu, 16 Apr 2015 06:03:38 -0400
MIME-Version: 1.0
In-Reply-To: <20150415191218.GC32654@mwanda>
References: <20150415191218.GC32654@mwanda>
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date: Thu, 16 Apr 2015 11:03:06 +0100
Message-ID: <CA+V-a8uo_F8pFEQoFx9rzdygwtPSb-BDDVx4Dfi_-wwDVjBHLQ@mail.gmail.com>
Subject: Re: [media] i2c: ov2659: signedness bug inov2659_set_fmt()
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Benoit Parrot <bparrot@ti.com>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	linux-media <linux-media@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

On Wed, Apr 15, 2015 at 8:12 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This needs to be signed or there is a risk of hitting a forever loop.
>
> Fixes: c4c0283ab3cd ('[media] media: i2c: add support for omnivision's ov2659 sensor')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
--Prabhakar Lad

> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
> index edebd11..d700a1d 100644
> --- a/drivers/media/i2c/ov2659.c
> +++ b/drivers/media/i2c/ov2659.c
> @@ -1102,7 +1102,7 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd,
>                           struct v4l2_subdev_format *fmt)
>  {
>         struct i2c_client *client = v4l2_get_subdevdata(sd);
> -       unsigned int index = ARRAY_SIZE(ov2659_formats);
> +       int index = ARRAY_SIZE(ov2659_formats);
>         struct v4l2_mbus_framefmt *mf = &fmt->format;
>         const struct ov2659_framesize *size = NULL;
>         struct ov2659 *ov2659 = to_ov2659(sd);

From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date: Thu, 16 Apr 2015 10:03:06 +0000
Subject: Re: [media] i2c: ov2659: signedness bug inov2659_set_fmt()
Message-Id: <CA+V-a8uo_F8pFEQoFx9rzdygwtPSb-BDDVx4Dfi_-wwDVjBHLQ@mail.gmail.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20150415191218.GC32654@mwanda>
In-Reply-To: <20150415191218.GC32654@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Benoit Parrot <bparrot@ti.com>, Mauro Carvalho Chehab <mchehab@osg.samsung.com>, linux-media <linux-media@vger.kernel.org>, kernel-janitors@vger.kernel.org

On Wed, Apr 15, 2015 at 8:12 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This needs to be signed or there is a risk of hitting a forever loop.
>
> Fixes: c4c0283ab3cd ('[media] media: i2c: add support for omnivision's ov2659 sensor')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
--Prabhakar Lad

> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
> index edebd11..d700a1d 100644
> --- a/drivers/media/i2c/ov2659.c
> +++ b/drivers/media/i2c/ov2659.c
> @@ -1102,7 +1102,7 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd,
>                           struct v4l2_subdev_format *fmt)
>  {
>         struct i2c_client *client = v4l2_get_subdevdata(sd);
> -       unsigned int index = ARRAY_SIZE(ov2659_formats);
> +       int index = ARRAY_SIZE(ov2659_formats);
>         struct v4l2_mbus_framefmt *mf = &fmt->format;
>         const struct ov2659_framesize *size = NULL;
>         struct ov2659 *ov2659 = to_ov2659(sd);