All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prabhakar Lad <prabhakar.csengg@gmail.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: LMML <linux-media@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	DLOS <davinci-linux-open-source@linux.davincidsp.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@redhat.com>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>
Subject: Re: [PATCH 1/6] media: i2c: ths7303: remove init_enable option from pdata
Date: Fri, 17 May 2013 10:26:38 +0530	[thread overview]
Message-ID: <CA+V-a8uzz=P9LzVeuzUhX5PTzi_VpFvVfKuGFHkcYaX02w1JrQ@mail.gmail.com> (raw)
In-Reply-To: <20130516223739.GB2077@valkosipuli.retiisi.org.uk>

Hi Sakari,

Thanks for the review.

On Fri, May 17, 2013 at 4:07 AM, Sakari Ailus <sakari.ailus@iki.fi> wrote:
> Hi Prabhakar,
>
> Thanks for the patch!
>
> On Wed, May 15, 2013 at 05:27:17PM +0530, Lad Prabhakar wrote:
>> diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c
>> index 65853ee..8cddcd0 100644
>> --- a/drivers/media/i2c/ths7303.c
>> +++ b/drivers/media/i2c/ths7303.c
>> @@ -356,9 +356,7 @@ static int ths7303_setup(struct v4l2_subdev *sd)
>>       int ret;
>>       u8 mask;
>>
>> -     state->stream_on = pdata->init_enable;
>> -
>> -     mask = state->stream_on ? 0xff : 0xf8;
>> +     mask = 0xf8;
>
> You can assign mask in declaration. It'd be nice to have a human-readable
> name for the mask, too.
>
This function gets removed in the preceding patch of this series.

Regards,
--Prabhakar Lad

  reply	other threads:[~2013-05-17  4:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15 11:57 [PATCH 0/6] media: i2c: ths7303 feature enhancement and cleanup Lad Prabhakar
2013-05-15 11:57 ` [PATCH 1/6] media: i2c: ths7303: remove init_enable option from pdata Lad Prabhakar
2013-05-16 22:37   ` Sakari Ailus
2013-05-17  4:56     ` Prabhakar Lad [this message]
2013-05-15 11:57 ` [PATCH 2/6] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata Lad Prabhakar
2013-05-15 11:57   ` Lad Prabhakar
2013-05-15 12:05   ` Laurent Pinchart
2013-05-15 12:05     ` Laurent Pinchart
2013-05-15 12:11     ` Prabhakar Lad
2013-05-15 12:11       ` Prabhakar Lad
2013-05-16 11:48       ` Prabhakar Lad
2013-05-16 11:48         ` Prabhakar Lad
2013-05-16 11:54         ` Laurent Pinchart
2013-05-16 11:54           ` Laurent Pinchart
2013-05-23  9:10   ` Prabhakar Lad
2013-05-23  9:10     ` Prabhakar Lad
2013-05-15 11:57 ` [PATCH 3/6] media: i2c: ths7303: remove unnecessary function ths7303_setup() Lad Prabhakar
2013-05-15 11:57 ` [PATCH 4/6] media: i2c: ths7303: make the pdata as a constant pointer Lad Prabhakar
2013-05-15 11:57 ` [PATCH 5/6] media: i2c: ths7303: add support for asynchronous probing Lad Prabhakar
2013-05-15 11:57 ` [PATCH 6/6] media: i2c: ths7303: add OF support Lad Prabhakar
2013-05-23  8:51 ` [PATCH 0/6] media: i2c: ths7303 feature enhancement and cleanup Hans Verkuil
2013-05-23  9:07   ` Prabhakar Lad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+V-a8uzz=P9LzVeuzUhX5PTzi_VpFvVfKuGFHkcYaX02w1JrQ@mail.gmail.com' \
    --to=prabhakar.csengg@gmail.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=hans.verkuil@cisco.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.