From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C06C433EF for ; Sun, 19 Dec 2021 09:53:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235534AbhLSJxL (ORCPT ); Sun, 19 Dec 2021 04:53:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbhLSJxJ (ORCPT ); Sun, 19 Dec 2021 04:53:09 -0500 Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CBAEC061574; Sun, 19 Dec 2021 01:53:09 -0800 (PST) Received: by mail-yb1-xb36.google.com with SMTP id v203so19670673ybe.6; Sun, 19 Dec 2021 01:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rQy98157VCXxailMB3OKe9xQTqZtJID4MSHHuD+ZMVE=; b=k8ttBwJ2ch3L2ku9kNpnsqC0Q7NVHZkdCSDqx5MBe8p1PYZK4kZzrWzDBj8H3QM0ds cdXWEH5/8o7OSWBkek22dihzqEraLEdZ+D35IYe4p/tu2IVrJu5YdHtS1EBdBfSscoJt +BcxXnXFhkEBedL5IZGJ1aYAWhVkn24OoqGSEox6rPUDgh8fcspsk0AT+qhMIX/wljG6 njKvaY/jdMsmvjE3gTf79QjdaXXzdmHFD4Z2rMnx48V0n95gl6j0lLubsWisxJkPlRT/ d1ETb3UpMBsV9tprKzXFyxmosTeO9qqKKrfA8AFcRQ4Fl6cktId6JeqUmqRr+3usFZ+r F4nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rQy98157VCXxailMB3OKe9xQTqZtJID4MSHHuD+ZMVE=; b=zz2ReTUSqFch8y9oiDOnbkdcRwh2Lm0vveA3jSlPrDcnOK0F73jnNvK5nApeZ7xuzF F92TbCE8RGMuml/6wrkIbYmA93bPy7pIUfE6zvAmQd+8vSjult2MvHDQQPRGiFgWXvPK ACKdPsFsggmNxFba640GlkQpuCb4yZuPXFT/luOpWLZiMeXb3KAFIteVE6jEnbYss1Sp DMNtlS0S/+28Tvgc2pM3xdY8ptO3r+NLVQchgnSIPyGgAq7hNU9aiNMNRj/MbXGMGVPp Q9dszMTeBOSxc9GPRzj2PnPD6ewK8cVxtLvZHJRXAwfmRJFm74LZawv8oMrHf+MkoWo2 F4tQ== X-Gm-Message-State: AOAM530nX9lCZn7D6FtUKSAAl43HtNIIGuTFEB+v2uXxqaU0l0EEU/bM WjF4v5HAsCnVLPkCVJpVQXODbkkJqRc/tdtYZjo= X-Google-Smtp-Source: ABdhPJwwUMaZimLMR3lbhPwW2EQ9i0quXz8lr7P5fHsQ8RE+4mqp6h3fkS59sK3CJW40LYkyT0rzyyh3Mf/Asodxpr0= X-Received: by 2002:a25:dc4d:: with SMTP id y74mr15202812ybe.422.1639907588560; Sun, 19 Dec 2021 01:53:08 -0800 (PST) MIME-Version: 1.0 References: <20211218165258.16716-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211218165258.16716-2-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Sun, 19 Dec 2021 09:52:42 +0000 Message-ID: Subject: Re: [PATCH 1/3] i2c: bcm2835: Use platform_get_irq() to get the interrupt To: Florian Fainelli Cc: Lad Prabhakar , Rob Herring , Nicolas Saenz Julienne , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Chris Brandt , Wolfram Sang , Linux I2C , linux-rpi-kernel@lists.infradead.org, LAK , LKML , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, On Sat, Dec 18, 2021 at 10:44 PM Lad, Prabhakar wrote: > > Hi Florian, > > Thank you for the review. > > On Sat, Dec 18, 2021 at 9:17 PM Florian Fainelli wrote: > > > > > > > > On 12/18/2021 8:52 AM, Lad Prabhakar wrote: > > > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > > > allocation of IRQ resources in DT core code, this causes an issue > > > when using hierarchical interrupt domains using "interrupts" property > > > in the node as this bypasses the hierarchical setup and messes up the > > > irq chaining. > > > > > > In preparation for removal of static setup of IRQ resource from DT core > > > code use platform_get_irq(). > > > > > > Signed-off-by: Lad Prabhakar > > > > Just one nit below: > > > --- > > > drivers/i2c/busses/i2c-bcm2835.c | 11 ++++------- > > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > > > diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c > > > index 37443edbf754..d63dec5f3cb1 100644 > > > --- a/drivers/i2c/busses/i2c-bcm2835.c > > > +++ b/drivers/i2c/busses/i2c-bcm2835.c > > > @@ -402,7 +402,7 @@ static const struct i2c_adapter_quirks bcm2835_i2c_quirks = { > > > static int bcm2835_i2c_probe(struct platform_device *pdev) > > > { > > > struct bcm2835_i2c_dev *i2c_dev; > > > - struct resource *mem, *irq; > > > + struct resource *mem; > > > int ret; > > > struct i2c_adapter *adap; > > > struct clk *mclk; > > > @@ -452,12 +452,9 @@ static int bcm2835_i2c_probe(struct platform_device *pdev) > > > return ret; > > > } > > > > > > - irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > > - if (!irq) { > > > - dev_err(&pdev->dev, "No IRQ resource\n"); > > > - return -ENODEV; > > > - } > > > - i2c_dev->irq = irq->start; > > > + i2c_dev->irq = platform_get_irq(pdev, 0); > > > + if (i2c_dev->irq <= 0) > > > + return i2c_dev->irq ? i2c_dev->irq : -ENXIO; > > > > Why not just check for a negative return code and propagate it as is? > > > platform_get_irq() may return 0 said that we do get a splat in this > case and further request_irq() will fail so instead check it here. > My bad, just the negative check should suffice. Cheers, Prabhakar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE9D0C433EF for ; Sun, 19 Dec 2021 09:55:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KYkRV6tBzqi1P+rJ093h7HYldqoE9pEdbk6K0RtpxV8=; b=u5fYSgNfBVv9vC pvK/mKFWS6ndmXDZrohAqcId6pmlUI6MvTGZQBu0La5CjCIuajgHJJqV2PKlzsYQeu5D/tJsSoaX6 r7huMgVBgyTgKcXydB4EFfeIy9ezYVo4+HCkm+/bx9t7xe6tpDn1JtCFGfbcajxkIwlCUrFUfbml+ qcjFT2eDIpyxl2T3wSXcEreTRsUtp3KmW6D5e8dIxfkqHpzoeQFJ0l9SHZwFsm6jfjkNDKt7rKyxS KhiTHlLQ6WMw7dOqj0hCtqcwkHvq99Y1FEJYTY16mZlQzod7FgH2JjUAbFx60czmkFtYrSNMpPHCt 2mtm0+QqIyrUcKhtSXsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1myssU-00Fdct-Jg; Sun, 19 Dec 2021 09:53:14 +0000 Received: from mail-yb1-xb32.google.com ([2607:f8b0:4864:20::b32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1myssP-00Fdc8-I8; Sun, 19 Dec 2021 09:53:10 +0000 Received: by mail-yb1-xb32.google.com with SMTP id d10so19741842ybe.3; Sun, 19 Dec 2021 01:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rQy98157VCXxailMB3OKe9xQTqZtJID4MSHHuD+ZMVE=; b=k8ttBwJ2ch3L2ku9kNpnsqC0Q7NVHZkdCSDqx5MBe8p1PYZK4kZzrWzDBj8H3QM0ds cdXWEH5/8o7OSWBkek22dihzqEraLEdZ+D35IYe4p/tu2IVrJu5YdHtS1EBdBfSscoJt +BcxXnXFhkEBedL5IZGJ1aYAWhVkn24OoqGSEox6rPUDgh8fcspsk0AT+qhMIX/wljG6 njKvaY/jdMsmvjE3gTf79QjdaXXzdmHFD4Z2rMnx48V0n95gl6j0lLubsWisxJkPlRT/ d1ETb3UpMBsV9tprKzXFyxmosTeO9qqKKrfA8AFcRQ4Fl6cktId6JeqUmqRr+3usFZ+r F4nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rQy98157VCXxailMB3OKe9xQTqZtJID4MSHHuD+ZMVE=; b=NIODAklGCr6OKRR/j3F2mTw5mmRaCJDjqIC8qrP9o1O4xiQTe6piUjtt7r+9G7060f wgsUBXrwPS6DJWhmc/Ni36zRmwiO26w+ThN8DbNACffbfYuD27cJEftw+4a+QS95n9hZ 2VYEeIyIsBpxDxJBM6BMvkro1xHRdhCN94htFGKrcMefLmzb3X+SGl4+1m4YcG2GDmZ6 SeP1Ul4g8JxLs1rNGa5fEXBam+ydpFvM8CLhWND8PvEr3wCD7zeODxBsnFfATFCBMZ90 7RwkKZ/2Eh3xdxNgnaINKvCdzbF5ZGlort0hZq+onnNll6jvuyPrJj44LS+203H89Arq D3MA== X-Gm-Message-State: AOAM531VqUEGV22COjDwFEHmZ2TglmsNTGyX5SeVRyJWWqx2Dv+N+GSx KM4tpoXQBAccRsRVOItmVbfsWfdmzM/gH+e0tgI= X-Google-Smtp-Source: ABdhPJwwUMaZimLMR3lbhPwW2EQ9i0quXz8lr7P5fHsQ8RE+4mqp6h3fkS59sK3CJW40LYkyT0rzyyh3Mf/Asodxpr0= X-Received: by 2002:a25:dc4d:: with SMTP id y74mr15202812ybe.422.1639907588560; Sun, 19 Dec 2021 01:53:08 -0800 (PST) MIME-Version: 1.0 References: <20211218165258.16716-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211218165258.16716-2-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Sun, 19 Dec 2021 09:52:42 +0000 Message-ID: Subject: Re: [PATCH 1/3] i2c: bcm2835: Use platform_get_irq() to get the interrupt To: Florian Fainelli Cc: Lad Prabhakar , Rob Herring , Nicolas Saenz Julienne , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Chris Brandt , Wolfram Sang , Linux I2C , linux-rpi-kernel@lists.infradead.org, LAK , LKML , Linux-Renesas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211219_015309_629569_F2F79889 X-CRM114-Status: GOOD ( 27.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Florian, On Sat, Dec 18, 2021 at 10:44 PM Lad, Prabhakar wrote: > > Hi Florian, > > Thank you for the review. > > On Sat, Dec 18, 2021 at 9:17 PM Florian Fainelli wrote: > > > > > > > > On 12/18/2021 8:52 AM, Lad Prabhakar wrote: > > > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > > > allocation of IRQ resources in DT core code, this causes an issue > > > when using hierarchical interrupt domains using "interrupts" property > > > in the node as this bypasses the hierarchical setup and messes up the > > > irq chaining. > > > > > > In preparation for removal of static setup of IRQ resource from DT core > > > code use platform_get_irq(). > > > > > > Signed-off-by: Lad Prabhakar > > > > Just one nit below: > > > --- > > > drivers/i2c/busses/i2c-bcm2835.c | 11 ++++------- > > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > > > diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c > > > index 37443edbf754..d63dec5f3cb1 100644 > > > --- a/drivers/i2c/busses/i2c-bcm2835.c > > > +++ b/drivers/i2c/busses/i2c-bcm2835.c > > > @@ -402,7 +402,7 @@ static const struct i2c_adapter_quirks bcm2835_i2c_quirks = { > > > static int bcm2835_i2c_probe(struct platform_device *pdev) > > > { > > > struct bcm2835_i2c_dev *i2c_dev; > > > - struct resource *mem, *irq; > > > + struct resource *mem; > > > int ret; > > > struct i2c_adapter *adap; > > > struct clk *mclk; > > > @@ -452,12 +452,9 @@ static int bcm2835_i2c_probe(struct platform_device *pdev) > > > return ret; > > > } > > > > > > - irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > > - if (!irq) { > > > - dev_err(&pdev->dev, "No IRQ resource\n"); > > > - return -ENODEV; > > > - } > > > - i2c_dev->irq = irq->start; > > > + i2c_dev->irq = platform_get_irq(pdev, 0); > > > + if (i2c_dev->irq <= 0) > > > + return i2c_dev->irq ? i2c_dev->irq : -ENXIO; > > > > Why not just check for a negative return code and propagate it as is? > > > platform_get_irq() may return 0 said that we do get a splat in this > case and further request_irq() will fail so instead check it here. > My bad, just the negative check should suffice. Cheers, Prabhakar _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel