From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF3E4C4332F for ; Sun, 26 Dec 2021 10:03:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231251AbhLZKDu (ORCPT ); Sun, 26 Dec 2021 05:03:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229709AbhLZKDt (ORCPT ); Sun, 26 Dec 2021 05:03:49 -0500 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF574C06173E; Sun, 26 Dec 2021 02:03:48 -0800 (PST) Received: by mail-yb1-xb32.google.com with SMTP id y130so11412434ybe.8; Sun, 26 Dec 2021 02:03:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PcIdhYGtAe5wiGEmCP4ZpgqtofQF1fYABhObn5o2LIM=; b=Tqi139SclsNTIfh4oyAGZJUQASq4/f+eBNWk4N0vBVBjYr1fJoIf2MChB6Lq+bBEwy HVAPn8ipsSddzr4zed1Lxj95XO6FIqYvyTyhmsnT3Gwpgl1oJex9Nkg3W9BY1aRfChzc RE54WE8HqPET/SGIWXPuCiZmmCyhJq2shQGFATYOtS0rDKEjDcUkiNH7JDrt6QInoaeT 7RN0NqHa8EMOUIjdg6uxQ0WEMmoRBm7CMhe55mm9i4QBLZhKLaCILdp4nyMEuwhb2HOk NKCzpoenct8cl3AwHn8Pqcl8MF19YQqn11zN9PcbJVGB/LHK1QMmJ43ztW+zzlEWrufz u2pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PcIdhYGtAe5wiGEmCP4ZpgqtofQF1fYABhObn5o2LIM=; b=pUKDouBNnMpNOosDwI/5rUmf2z6gnCOlHExdXu3xNaFC/55Jgbs2OqUBZ0vrSJ65tK UBF5PfTZAu3ChgPA8EOJrMAhyR6ywVvwECn+kMJwSAMiUIl4HrfZuBptkzhliw8cJAqa OMkfMeSyCXgmD3T/TjmkoggarVGQKRZ2KN6WuEPRohWSThnpsWA7Z4UujsOyA9BEBafo 32I8MYZz+q6+3bRquGCsXCBuf6k4XFWtrnUO58oZPqD8lp/G/6SIFmdvBTWN9E9hTVP+ 9waB4XfAXhkGaZbRHQcTa3Fh4GpY2MqBtUaHDayZKpsKqpEejQKAHl/uv+jkNdfq0gxk +sRg== X-Gm-Message-State: AOAM531gCvW4dddjwjO90jAJO5I4NN/jPF0bN+sAx0XlASBjWNQvUe5V aXMcOBPX++PhHScsaHLA/mVGmtWMhpGMy8Hcpg8= X-Google-Smtp-Source: ABdhPJy5eauPTYjIdf+IeTzl2CnArYlq43PzOJd+NA5Yj14nbn8+5xGo3U9BQ3S8h4SL1usNm3g+exbbRtvb7xqb6f0= X-Received: by 2002:a25:98c4:: with SMTP id m4mr16123099ybo.613.1640513028115; Sun, 26 Dec 2021 02:03:48 -0800 (PST) MIME-Version: 1.0 References: <20211221175322.7096-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211221175322.7096-3-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Sun, 26 Dec 2021 10:03:22 +0000 Message-ID: Subject: Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt To: Andy Shevchenko Cc: Prabhakar Mahadev Lad , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Nicolas Saenz Julienne , Chris Brandt , Wolfram Sang , linux-i2c , linux-rpi-kernel , linux-arm Mailing List , Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 26, 2021 at 8:41 AM Andy Shevchenko wrote: > > On Sun, Dec 26, 2021 at 1:45 AM Prabhakar Mahadev Lad > wrote: > > > On Wed, Dec 22, 2021 at 2:41 PM Lad Prabhakar wrote: > > ... > > > > > + if (np) { > > > > > > Same comments as per your other patches, i.e. > > > Why is this check here? > > > > > Because the interrupt resource has range of interrupts in one IRQ resource [0]. Let me know if there is any other alternative way to avoid such case. > > Shouldn't be fixed in platform_get_irq_optional() to return IRQ by > index for all cases? > Sorry, I don't get you here. Wasn't your earlier comment for np check? Cheers, Prabhakar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD24CC433EF for ; Sun, 26 Dec 2021 10:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AeZCiJiesdgtWsh258sdwm2eug7Ql8j1SKa+oDcpQm4=; b=NTDEEtfIhgWEAo Fga/9yXcHbDnIG3JlpQP5wjNgbTIVbxf7Vff10janfp8f4PR8R5SZQiLd8Hfe0vUgkVG/7NBUJ5Za 9U1xbW1wcDWFIPad/Oiu5TjcC3aMj/tlwllopVnbfcfWnBdDt10jgCwSdxvJDm1qlFsMdH1o5Nlh+ jh8S4+vQhKEfgQwR2OIQjSlt8Dh70UrfSAg2p+bYqpSaZoZ0+zCfqP2oT8F/ShSrt0BTVB3VlFtkC ChfxTMBBQNkhBSxXnJTLoIkHLnzlPNfYMIIhtpmKHmnNWppTPan6AYg/BGI3bJzTpVHxiRwV+AKIl CZnrh/GGf9V+FoRwmWfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n1QNe-00FSGL-Ug; Sun, 26 Dec 2021 10:03:55 +0000 Received: from mail-yb1-xb32.google.com ([2607:f8b0:4864:20::b32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n1QNb-00FSFV-0P; Sun, 26 Dec 2021 10:03:52 +0000 Received: by mail-yb1-xb32.google.com with SMTP id i3so21557567ybh.11; Sun, 26 Dec 2021 02:03:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PcIdhYGtAe5wiGEmCP4ZpgqtofQF1fYABhObn5o2LIM=; b=Tqi139SclsNTIfh4oyAGZJUQASq4/f+eBNWk4N0vBVBjYr1fJoIf2MChB6Lq+bBEwy HVAPn8ipsSddzr4zed1Lxj95XO6FIqYvyTyhmsnT3Gwpgl1oJex9Nkg3W9BY1aRfChzc RE54WE8HqPET/SGIWXPuCiZmmCyhJq2shQGFATYOtS0rDKEjDcUkiNH7JDrt6QInoaeT 7RN0NqHa8EMOUIjdg6uxQ0WEMmoRBm7CMhe55mm9i4QBLZhKLaCILdp4nyMEuwhb2HOk NKCzpoenct8cl3AwHn8Pqcl8MF19YQqn11zN9PcbJVGB/LHK1QMmJ43ztW+zzlEWrufz u2pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PcIdhYGtAe5wiGEmCP4ZpgqtofQF1fYABhObn5o2LIM=; b=VwwFp+mZ/rRZYc5DvIDBFstXZk8C7j71yqlIbtXkNGKpZDfLzUGqYI2tfJg2sEz3hr U+foo1JBV0k39dMwqPSMYgSROFFuCz1HcwZzFmgW5epzTChrhPkL0GnTUPwgXNVQQ4GC NvBdTxI9RhmunKhzJkTn8HvjW9onY984AMcFAKNqchmlDp1EbNIzdZSO2ITON8oDmfgA jOwrbNgGuD06X0aymSBDAgS20PM1goUQZLn2Jr5k8JUlbvDYIuXFTi6OwM3oMxDemyWZ qatbtMhzWb4cmblZQTZZGtBxqE84izrrCz1fV0QZpeTD9KMp3y0vTwshG6/GXO0IrzTR qiyg== X-Gm-Message-State: AOAM5336Q9yNSU1QTgZ3aXMlUBVwq10l9TKgY895o8Ish+rSqQp8fao/ e3XYm3DCUo0BNics/f/2jeAgwBoq7onbLCRinhg= X-Google-Smtp-Source: ABdhPJy5eauPTYjIdf+IeTzl2CnArYlq43PzOJd+NA5Yj14nbn8+5xGo3U9BQ3S8h4SL1usNm3g+exbbRtvb7xqb6f0= X-Received: by 2002:a25:98c4:: with SMTP id m4mr16123099ybo.613.1640513028115; Sun, 26 Dec 2021 02:03:48 -0800 (PST) MIME-Version: 1.0 References: <20211221175322.7096-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211221175322.7096-3-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Sun, 26 Dec 2021 10:03:22 +0000 Message-ID: Subject: Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt To: Andy Shevchenko Cc: Prabhakar Mahadev Lad , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Nicolas Saenz Julienne , Chris Brandt , Wolfram Sang , linux-i2c , linux-rpi-kernel , linux-arm Mailing List , Linux-Renesas , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211226_020351_087780_868ABD25 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Dec 26, 2021 at 8:41 AM Andy Shevchenko wrote: > > On Sun, Dec 26, 2021 at 1:45 AM Prabhakar Mahadev Lad > wrote: > > > On Wed, Dec 22, 2021 at 2:41 PM Lad Prabhakar wrote: > > ... > > > > > + if (np) { > > > > > > Same comments as per your other patches, i.e. > > > Why is this check here? > > > > > Because the interrupt resource has range of interrupts in one IRQ resource [0]. Let me know if there is any other alternative way to avoid such case. > > Shouldn't be fixed in platform_get_irq_optional() to return IRQ by > index for all cases? > Sorry, I don't get you here. Wasn't your earlier comment for np check? Cheers, Prabhakar _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel