From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Lad, Prabhakar" Subject: Re: [PATCH] headers: fix linux/mod_devicetable.h inclusions Date: Tue, 17 Jul 2018 13:22:37 +0100 Message-ID: References: <20180709151947.940759-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180709151947.940759-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Randy Dunlap , Greg Kroah-Hartman , Gabriel Somlo , "Michael S. Tsirkin" , Mauro Carvalho Chehab , Stanimir Varbanov , Jean-Christophe Trotin , Zha Qipeng , Darren Hart , Andy Shevchenko , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , qemu-devel@nongnu.org, LKML , linux-media , linux-arm-msm@vger.kernel.org, platform-driver-x86@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Mon, Jul 9, 2018 at 4:19 PM, Arnd Bergmann wrote: > A couple of drivers produced build errors after the mod_devicetable.h > header was split out from the platform_device one, e.g. > > drivers/media/platform/davinci/vpbe_osd.c:42:40: error: array type has incomplete element type 'struct platform_device_id' > drivers/media/platform/davinci/vpbe_venc.c:42:40: error: array type has incomplete element type 'struct platform_device_id' > For the above fixes, Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > This adds the inclusion where needed. > > Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h") > Signed-off-by: Arnd Bergmann > --- > drivers/firmware/qemu_fw_cfg.c | 1 + > drivers/media/platform/davinci/vpbe_osd.c | 1 + > drivers/media/platform/davinci/vpbe_venc.c | 1 + > drivers/media/platform/qcom/venus/vdec.c | 1 + > drivers/media/platform/qcom/venus/venc.c | 1 + > drivers/media/platform/sti/hva/hva-v4l2.c | 1 + > drivers/platform/x86/intel_punit_ipc.c | 1 + > 7 files changed, 7 insertions(+) > > diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c > index 14fedbeca724..039e0f91dba8 100644 > --- a/drivers/firmware/qemu_fw_cfg.c > +++ b/drivers/firmware/qemu_fw_cfg.c > @@ -28,6 +28,7 @@ > */ > > #include > +#include > #include > #include > #include > diff --git a/drivers/media/platform/davinci/vpbe_osd.c b/drivers/media/platform/davinci/vpbe_osd.c > index 7f610320426d..c551a25d90d9 100644 > --- a/drivers/media/platform/davinci/vpbe_osd.c > +++ b/drivers/media/platform/davinci/vpbe_osd.c > @@ -18,6 +18,7 @@ > * > */ > #include > +#include > #include > #include > #include > diff --git a/drivers/media/platform/davinci/vpbe_venc.c b/drivers/media/platform/davinci/vpbe_venc.c > index ba157827192c..ddcad7b3e76c 100644 > --- a/drivers/media/platform/davinci/vpbe_venc.c > +++ b/drivers/media/platform/davinci/vpbe_venc.c > @@ -11,6 +11,7 @@ > * GNU General Public License for more details. > */ > #include > +#include > #include > #include > #include > diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c > index f89a91d43cc9..d4e23c7df347 100644 > --- a/drivers/media/platform/qcom/venus/vdec.c > +++ b/drivers/media/platform/qcom/venus/vdec.c > @@ -14,6 +14,7 @@ > */ > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c > index f7a87a3dbb46..0522cf202b75 100644 > --- a/drivers/media/platform/qcom/venus/venc.c > +++ b/drivers/media/platform/qcom/venus/venc.c > @@ -14,6 +14,7 @@ > */ > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/media/platform/sti/hva/hva-v4l2.c b/drivers/media/platform/sti/hva/hva-v4l2.c > index 15080cb00fa7..5a807c7c5e79 100644 > --- a/drivers/media/platform/sti/hva/hva-v4l2.c > +++ b/drivers/media/platform/sti/hva/hva-v4l2.c > @@ -6,6 +6,7 @@ > */ > > #include > +#include > #include > #include > #include > diff --git a/drivers/platform/x86/intel_punit_ipc.c b/drivers/platform/x86/intel_punit_ipc.c > index b5b890127479..f1afc0ebbc68 100644 > --- a/drivers/platform/x86/intel_punit_ipc.c > +++ b/drivers/platform/x86/intel_punit_ipc.c > @@ -12,6 +12,7 @@ > */ > > #include > +#include > #include > #include > #include > -- > 2.9.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffP0Z-00041Q-6k for qemu-devel@nongnu.org; Tue, 17 Jul 2018 08:23:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffP0X-0003SG-U3 for qemu-devel@nongnu.org; Tue, 17 Jul 2018 08:23:11 -0400 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:41325) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffP0X-0003RR-IM for qemu-devel@nongnu.org; Tue, 17 Jul 2018 08:23:09 -0400 Received: by mail-ed1-x542.google.com with SMTP id s24-v6so1030546edr.8 for ; Tue, 17 Jul 2018 05:23:09 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180709151947.940759-1-arnd@arndb.de> References: <20180709151947.940759-1-arnd@arndb.de> From: "Lad, Prabhakar" Date: Tue, 17 Jul 2018 13:22:37 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH] headers: fix linux/mod_devicetable.h inclusions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Arnd Bergmann Cc: Randy Dunlap , Greg Kroah-Hartman , Gabriel Somlo , "Michael S. Tsirkin" , Mauro Carvalho Chehab , Stanimir Varbanov , Jean-Christophe Trotin , Zha Qipeng , Darren Hart , Andy Shevchenko , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , qemu-devel@nongnu.org, LKML , linux-media , linux-arm-msm@vger.kernel.org, platform-driver-x86@vger.kernel.org On Mon, Jul 9, 2018 at 4:19 PM, Arnd Bergmann wrote: > A couple of drivers produced build errors after the mod_devicetable.h > header was split out from the platform_device one, e.g. > > drivers/media/platform/davinci/vpbe_osd.c:42:40: error: array type has incomplete element type 'struct platform_device_id' > drivers/media/platform/davinci/vpbe_venc.c:42:40: error: array type has incomplete element type 'struct platform_device_id' > For the above fixes, Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > This adds the inclusion where needed. > > Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h") > Signed-off-by: Arnd Bergmann > --- > drivers/firmware/qemu_fw_cfg.c | 1 + > drivers/media/platform/davinci/vpbe_osd.c | 1 + > drivers/media/platform/davinci/vpbe_venc.c | 1 + > drivers/media/platform/qcom/venus/vdec.c | 1 + > drivers/media/platform/qcom/venus/venc.c | 1 + > drivers/media/platform/sti/hva/hva-v4l2.c | 1 + > drivers/platform/x86/intel_punit_ipc.c | 1 + > 7 files changed, 7 insertions(+) > > diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c > index 14fedbeca724..039e0f91dba8 100644 > --- a/drivers/firmware/qemu_fw_cfg.c > +++ b/drivers/firmware/qemu_fw_cfg.c > @@ -28,6 +28,7 @@ > */ > > #include > +#include > #include > #include > #include > diff --git a/drivers/media/platform/davinci/vpbe_osd.c b/drivers/media/platform/davinci/vpbe_osd.c > index 7f610320426d..c551a25d90d9 100644 > --- a/drivers/media/platform/davinci/vpbe_osd.c > +++ b/drivers/media/platform/davinci/vpbe_osd.c > @@ -18,6 +18,7 @@ > * > */ > #include > +#include > #include > #include > #include > diff --git a/drivers/media/platform/davinci/vpbe_venc.c b/drivers/media/platform/davinci/vpbe_venc.c > index ba157827192c..ddcad7b3e76c 100644 > --- a/drivers/media/platform/davinci/vpbe_venc.c > +++ b/drivers/media/platform/davinci/vpbe_venc.c > @@ -11,6 +11,7 @@ > * GNU General Public License for more details. > */ > #include > +#include > #include > #include > #include > diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c > index f89a91d43cc9..d4e23c7df347 100644 > --- a/drivers/media/platform/qcom/venus/vdec.c > +++ b/drivers/media/platform/qcom/venus/vdec.c > @@ -14,6 +14,7 @@ > */ > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c > index f7a87a3dbb46..0522cf202b75 100644 > --- a/drivers/media/platform/qcom/venus/venc.c > +++ b/drivers/media/platform/qcom/venus/venc.c > @@ -14,6 +14,7 @@ > */ > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/media/platform/sti/hva/hva-v4l2.c b/drivers/media/platform/sti/hva/hva-v4l2.c > index 15080cb00fa7..5a807c7c5e79 100644 > --- a/drivers/media/platform/sti/hva/hva-v4l2.c > +++ b/drivers/media/platform/sti/hva/hva-v4l2.c > @@ -6,6 +6,7 @@ > */ > > #include > +#include > #include > #include > #include > diff --git a/drivers/platform/x86/intel_punit_ipc.c b/drivers/platform/x86/intel_punit_ipc.c > index b5b890127479..f1afc0ebbc68 100644 > --- a/drivers/platform/x86/intel_punit_ipc.c > +++ b/drivers/platform/x86/intel_punit_ipc.c > @@ -12,6 +12,7 @@ > */ > > #include > +#include > #include > #include > #include > -- > 2.9.0 >