From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6F33C54EAA for ; Fri, 27 Jan 2023 13:37:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3DA01851E0; Fri, 27 Jan 2023 14:37:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=edgeble.ai Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=edgeble-ai.20210112.gappssmtp.com header.i=@edgeble-ai.20210112.gappssmtp.com header.b="65LWK8B4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7E1A685509; Fri, 27 Jan 2023 14:37:38 +0100 (CET) Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 186E684C58 for ; Fri, 27 Jan 2023 14:37:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=edgeble.ai Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=jagan@edgeble.ai Received: by mail-yb1-xb2b.google.com with SMTP id h5so5968158ybj.8 for ; Fri, 27 Jan 2023 05:37:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=edgeble-ai.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=a4NI8HWCEUGfpJoDSMsbNh6b/atNYxG/BCiCP7z8U1I=; b=65LWK8B4E/BupChIiPTBclhxqMsJ6TJTvXNwAng0bYWkdSDWFgpBJ73qw7GqU+d64v RiGRs9NzRpSkCkBgo4fPw6QpxGIAADxrholOI8yLqmODIOEp0mvc1N8wd4v2VEAymeha SpAlOo4oLbAhqHekz3Ux6rQxy31k9yO2ucHrB3NNEUSrnQD1B+YRxEKbfkXI7XE7kFtQ DbXWhPaoi0NVTaLoEYQxEcyHfRZR/+Z6voWC1/BwyiO/XtprHyoPHoKPczzwkWLE6Ct6 Nop4JuZnrb8RkrjvHBlYf0IV9rvjHhXRyMNJkPUtfC7EvcNnU6s0xGeS5VbqEOGYiucR ob8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a4NI8HWCEUGfpJoDSMsbNh6b/atNYxG/BCiCP7z8U1I=; b=5V0hq+l1GRLEqDOPXiXzlUW+PSnKvXzgdcnrjXyjZAQD/cB0B0p55LxlVMj5B72ri4 fmxSkx9HApR804VW0Xio3fIxUmw1nqi/K2uOTPrk4oUGv+edkjfdYdKSYyfM/v9rI+9G bCOibwfa/0FwU70a2CLblXci7DiANVqy2iOmYeUQSqcBDCBEgJiTYJbjqiIxV4DGI5bA iurOda4yVbQBaDCVQDPB/OACmjnFvmhMuaeDfzdHAGZ/vvbAmgVFE9gbUusHW3AwnTqP aodq8atMJuAV+QJbpUWhUKWv8fY1vYpVglvltokH0Lxld715yaVAaWGnOHfux+FxgNCA 1HTw== X-Gm-Message-State: AFqh2kqMuVeu66P3BO2P82+5WpyhnFnV8mGLc+xatyZxxk9v9z5HP4d5 NstLroHjZceIzgsPHMjaKjOnvpmTtj/ZLj9zjvLwSA== X-Google-Smtp-Source: AMrXdXttmdqeSXDIxMKfv3YqqdvLPpbMyzV2thCOKurpY6l2/1rm2GMTDwxdmejpybX9GmGdYW0eXi/zVit56xhicTQ= X-Received: by 2002:a25:bf83:0:b0:7fe:75bb:d85f with SMTP id l3-20020a25bf83000000b007fe75bbd85fmr4431883ybk.539.1674826654751; Fri, 27 Jan 2023 05:37:34 -0800 (PST) MIME-Version: 1.0 References: <20230125222741.303259-1-jagan@edgeble.ai> <20230125222741.303259-16-jagan@edgeble.ai> In-Reply-To: From: Jagan Teki Date: Fri, 27 Jan 2023 19:07:24 +0530 Message-ID: Subject: Re: [RFC PATCH 15/16] ARM: dts: rockchip: Add rk3588-u-boot.dtsi To: Eugen Hristev Cc: Kever Yang , Simon Glass , Philipp Tomsich , fatorangecat@189.cn, u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Fri, 27 Jan 2023 at 19:03, Eugen Hristev wrote: > > Hello Jagan, > > > On 1/26/23 00:27, Jagan Teki wrote: > > Add u-boot,dm-spl and u-boot,dm-pre-reloc related properties > > for Rockchip RK3588 SoC. > > It appears this file/commit does more than just adding u-boot,* properties > > > > > Signed-off-by: Jagan Teki > > --- > > arch/arm/dts/rk3588-u-boot.dtsi | 101 ++++++++++++++++++++++++++++++++ > > 1 file changed, 101 insertions(+) > > create mode 100644 arch/arm/dts/rk3588-u-boot.dtsi > > > > diff --git a/arch/arm/dts/rk3588-u-boot.dtsi b/arch/arm/dts/rk3588-u-boot.dtsi > > new file mode 100644 > > index 0000000000..b5cc4dcc60 > > --- /dev/null > > +++ b/arch/arm/dts/rk3588-u-boot.dtsi > > @@ -0,0 +1,101 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright (c) 2022 Edgeble AI Technologies Pvt. Ltd. > > + */ > > + > > +#include "rockchip-u-boot.dtsi" > > +#include > > + > > +/ { > > + dmc { > > + compatible = "rockchip,rk3588-dmc"; > > + u-boot,dm-pre-reloc; > > + status = "okay"; > > + }; > > + > > + pmu1_grf: syscon@fd58a000 { > > + u-boot,dm-pre-reloc; > > + compatible = "rockchip,rk3588-pmu1-grf", "syscon"; > > + reg = <0x0 0xfd58a000 0x0 0x2000>; > > + }; > > + > > + sdmmc: mmc@fe2c0000 { > > Just for my understanding, why are you adding here a new node sdmmc, and > have it disabled, while you have another node called 'sdhci' which you > enable further down in the file ? > What is the purpose of this sdmmc node? and defining it here. In order to boot SDCard, linux doesn't support this node yet so once Linux has it we can sync and drop this from here. Idea is to have devicetree files be the same as in Linux in order to maintain them properly. As long as the specific node is not supported in Linux that would be considered as -u-boot.dtsi specific. Jagan.