From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0516EC38142 for ; Fri, 27 Jan 2023 14:23:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B0FC3851E4; Fri, 27 Jan 2023 15:23:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=edgeble.ai Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=edgeble-ai.20210112.gappssmtp.com header.i=@edgeble-ai.20210112.gappssmtp.com header.b="BoqKEq89"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AAACD85705; Fri, 27 Jan 2023 15:23:53 +0100 (CET) Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 06AAB85168 for ; Fri, 27 Jan 2023 15:23:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=edgeble.ai Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=jagan@edgeble.ai Received: by mail-yb1-xb2e.google.com with SMTP id a9so6162529ybb.3 for ; Fri, 27 Jan 2023 06:23:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=edgeble-ai.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MGum7CFZ2kYfNIqa64s3h+0ReZVOzR20g406mk/Jx5Y=; b=BoqKEq89ti/csVBTHLRdzZRwFKpJaZONif3qztsTWPFZ+8//i5LqIlkqm6IDFDEdl4 Yq06WCQVGf4jtZzyo2x94zh+W+QMSu/3klvuNzyfy/31C7Za7NvuP0a3of8jqvKunoJo TvKxw5lwu0UFmkKRjAerGtl4Pjy1LNeb3SUGb3dltw8CVjHkZof3OHAEIyrvgnju3ydK 9+s0D+bj4A4GZH3NuZ6bD8I4+AWhviaNTEeg5l+NFHvOQs3BiKXRMxHFEYw9SlofEBDu MNeENk6It0Ohsh98raD6FRu5snFp9ZY7NTi91HZrM3qnLLEvY3fRBFV+JSrIqkE6qISg oiQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MGum7CFZ2kYfNIqa64s3h+0ReZVOzR20g406mk/Jx5Y=; b=EHIT5y2fToGTcp2zrpcxUirStCPyccIgyMYNSFQfixgOIccztMaQPjavtuRZgWxTli 0IWB9L2dBAn9jLA4KNklmqpie2zD98421SEEQhgWwlRwwyYfX211cA3TSivAm07QaZnn XEx9OgL99kaggoEy0RUC4naf1oTeis5f5Q8OWmtThVO7yzPYVTm+2axvuNXdplPVOe9K zbBP24Lr44ELBvIlgm5+YhRBEl61BqV3lBYcY/z2bMNgGqLBDW6Dsqu6iAPA11It1ar8 Y8Iw8oM+0e1MNYKYxJCUCZZmiGJI8CjnmEgival5B8SIxj4STLULkp1OGIbWBPrkK5wp vrhg== X-Gm-Message-State: AFqh2kqs7sjt72SKYIlug0Qui35nJKcT91ml120/H1fP8YZsLD1IlGsM 4Sn3sq+jBgGirYPyOW73idd5P1jtnhPtBBmi0ZhuCw== X-Google-Smtp-Source: AMrXdXsz1QqtfKRYmegT7oMdbqmF92VY3I0bQC5iVSMuO9+q7ce7Z0Dzw5YGNwZgs8CxdCrDt0iuGjE8oCDfwe8QNA0= X-Received: by 2002:a25:bf83:0:b0:7fe:75bb:d85f with SMTP id l3-20020a25bf83000000b007fe75bbd85fmr4454688ybk.539.1674829429710; Fri, 27 Jan 2023 06:23:49 -0800 (PST) MIME-Version: 1.0 References: <20230125222741.303259-1-jagan@edgeble.ai> <20230125222741.303259-16-jagan@edgeble.ai> In-Reply-To: From: Jagan Teki Date: Fri, 27 Jan 2023 19:53:38 +0530 Message-ID: Subject: Re: [RFC PATCH 15/16] ARM: dts: rockchip: Add rk3588-u-boot.dtsi To: Eugen Hristev Cc: Kever Yang , Simon Glass , Philipp Tomsich , fatorangecat@189.cn, u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Fri, 27 Jan 2023 at 19:21, Eugen Hristev wrote: > > On 1/27/23 15:37, Jagan Teki wrote: > > On Fri, 27 Jan 2023 at 19:03, Eugen Hristev wrote: > >> > >> Hello Jagan, > >> > >> > >> On 1/26/23 00:27, Jagan Teki wrote: > >>> Add u-boot,dm-spl and u-boot,dm-pre-reloc related properties > >>> for Rockchip RK3588 SoC. > >> > >> It appears this file/commit does more than just adding u-boot,* properties > >> > >>> > >>> Signed-off-by: Jagan Teki > >>> --- > >>> arch/arm/dts/rk3588-u-boot.dtsi | 101 ++++++++++++++++++++++++++++++++ > >>> 1 file changed, 101 insertions(+) > >>> create mode 100644 arch/arm/dts/rk3588-u-boot.dtsi > >>> > >>> diff --git a/arch/arm/dts/rk3588-u-boot.dtsi b/arch/arm/dts/rk3588-u-boot.dtsi > >>> new file mode 100644 > >>> index 0000000000..b5cc4dcc60 > >>> --- /dev/null > >>> +++ b/arch/arm/dts/rk3588-u-boot.dtsi > >>> @@ -0,0 +1,101 @@ > >>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >>> +/* > >>> + * Copyright (c) 2022 Edgeble AI Technologies Pvt. Ltd. > >>> + */ > >>> + > >>> +#include "rockchip-u-boot.dtsi" > >>> +#include > >>> + > >>> +/ { > >>> + dmc { > >>> + compatible = "rockchip,rk3588-dmc"; > >>> + u-boot,dm-pre-reloc; > >>> + status = "okay"; > >>> + }; > >>> + > >>> + pmu1_grf: syscon@fd58a000 { > >>> + u-boot,dm-pre-reloc; > >>> + compatible = "rockchip,rk3588-pmu1-grf", "syscon"; > >>> + reg = <0x0 0xfd58a000 0x0 0x2000>; > >>> + }; > >>> + > >>> + sdmmc: mmc@fe2c0000 { > >> > >> Just for my understanding, why are you adding here a new node sdmmc, and > >> have it disabled, while you have another node called 'sdhci' which you > >> enable further down in the file ? > >> What is the purpose of this sdmmc node? and defining it here. > > > > In order to boot SDCard, linux doesn't support this node yet so once > > Linux has it we can sync and drop this from here. Idea is to have > > devicetree files be the same as in Linux in order to maintain them > > properly. As long as the specific node is not supported in Linux that > > would be considered as -u-boot.dtsi specific. > > Okay, but the node is disabled.. while you enable the 'sdhci' node below > in the file. Yes, few nits to fix. I'm working on the final working version. Will fix these in the next version patchset. Jagan.