Re: [Weekly meetings] MoM - 28th of April 2022 (MP_FAIL followup)

[Geliang Tang <geliangtang@gmail.com>]

Paolo Abeni <pabeni@redhat.com> 于2022年5月4日周三 22:05写道：
>
> On Wed, 2022-05-04 at 10:44 +0800, Geliang Tang wrote:
> > Mat Martineau <mathew.j.martineau@linux.intel.com> 于2022年5月4日周三 04:41写道：
> >
> > >
> > >
> > > On Thu, 28 Apr 2022, Mat Martineau wrote:
> > >
> > > >    - Features for net-next (next):
> > > >
> > > >        - [8053fb8d49ed] selftests: mptcp: add MP_FAIL reset testcase
> > > > (Geliang Tang)
> > > >          - Two pending issues: open issue regarding multiple MP_FAIL in self
> > > > test, and dropping of bad data.
> > > >          - Prioritize MP_FAIL fixes
> > > >          - Follow up on ML to make sure Geliang is not blocked [Mat]
> > > >
> >
> > With Paolo's commit "net/sched: act_pedit: really ensure the skb is
> > writable", all pending issues about MP_FAIL have been solved.
> >
> > >
> > > Geliang -
> > >
> > > Were the two issues to resolve before upstreaming "selftests: mptcp: add
> > > MP_FAIL reset testcase" these:
> > >
> > > 1. https://github.com/multipath-tcp/mptcp_net-next/issues/265
> > >
> > > 2. Waiting for feedback on how to drop data on checksum failure.
> > >
> > >
> > > For #1, Paolo has been making a lot of progress there. Since the bug is
> > > tracked, it will be clear when it is closed and no longer blocks
> > > upstreaming
> > >
> >
> > Now all these '2 MP_FAIL[s]' issues has been fixed:
> >
> > 095 MP_FAIL MP_RST                       syn[ ok ] - synack[ ok ] - ack[ ok ]
> >                                          sum[ ok ] - csum  [ ok ]
> >                                          ftx[fail] got 2 MP_FAIL[s] TX
> > expected 1
> >  - failrx[fail] got 2 MP_FAIL[s] RX expected 1
> >                                          rtx[fail] got 2 MP_RST[s] TX expected 1
> >  - rstrx [fail] got 2 MP_RST[s] RX expected 1
> >                                          itx[ ok ] - infirx[ ok ]
> >
> > No '2 MP_FAIL[s]' issues in my test anymore.
> >
> >
> > But I still got another type of failures (0 MP_FAIL[s]) in my test:
> >
> > 002 MP_FAIL MP_RST: 5 corrupted pkts     syn[ ok ] - synack[ ok ] - ack[ ok ]
> >                                          sum[ ok ] - csum  [ ok ]
> >                                          ftx[ ok ] - failrx[fail] got
> > 0 MP_FAIL[s] RX expected 1
> >                                          rtx[ ok ] - rstrx [fail] got
> > 0 MP_RST[s] RX expected 1
> >                                          itx[ ok ] - infirx[ ok ]
> >
> > It seems MP_FAIL is lost in some cases. MP_FAIL is sent, but not received.
> >
> > I don't know whether Paolo is also looking at this 0 MP_FAIL[s] issue,
> > or whether it is necessary to open a new issue on Githut to track this
> > issue.
>
> [browsers!] I'm not working on it right now. I can have a look at the
> end of the week or the next one, if the issue is still pending.

Hi Paolo, with your new commit, selftests: mptcp: fix MP_FAIL
test-case, v2,  I didn't find this issue again in my test.

>
> Meanwhile, I suggest to track it with an individual/specific gitlab
> issue - to collect all the relevant info in a single place.
>
> Cheers,
>
> Paolo
>