All of lore.kernel.org
 help / color / mirror / Atom feed
From: james harvey <jamespharvey20@gmail.com>
To: Su Yue <suy.fnst@cn.fujitsu.com>
Cc: Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v3 (Only) 2/3] btrfs-progs: map-logical: Use btrfs_next_extent_item()
Date: Thu, 7 Jun 2018 14:41:20 -0400	[thread overview]
Message-ID: <CA+X5Wn6EP4nxGA7hE4HCUa9jWpk3XVVPdR0zb1v9Yd-y9kH5Ew@mail.gmail.com> (raw)
In-Reply-To: <CA+X5Wn7U_8cdO-fDzgfKmKvBqavzamQUNz6sDX7pePSWd-pcjg@mail.gmail.com>

On Thu, Jun 7, 2018 at 4:50 AM, Su Yue <suy.fnst@cn.fujitsu.com> wrote:
> On 06/07/2018 03:20 PM, james harvey wrote:
>>
>> btrfs_next_extent_item() looks for BTRFS_EXTENT_ITEM_KEY and
>> BTRFS_METADATA_KEY,
>> which are the types we're looking for.
>>
>> Signed-off-by: James Harvey <jamespharvey20@gmail.com>
>
> Reviewed-by: Su Yue <suy.fnst@cn.fujitsu.com>

btrfs_next_extent_item() looks for BTRFS_EXTENT_ITEM_KEY and BTRFS_METADATA_KEY,
which are the types we're looking for.

(Previous versions missed last 0 argument to btrfs_next_extent_item().  Sorry, I
realize I need to take more time before sending, being more careful on
everything.)

Signed-off-by: James Harvey <jamespharvey20@gmail.com>
---
 btrfs-map-logical.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/btrfs-map-logical.c b/btrfs-map-logical.c
index 2451012b..8a41b037 100644
--- a/btrfs-map-logical.c
+++ b/btrfs-map-logical.c
@@ -83,7 +83,8 @@ again:
                        ret = btrfs_previous_extent_item(fs_info->extent_root,
                                                         path, 0);
                else
-                       ret = btrfs_next_item(fs_info->extent_root, path);
+                       ret = btrfs_next_extent_item(fs_info->extent_root,
+                                                    path, 0);
                if (ret)
                        goto out;
                goto again;
--
2.17.0

  reply	other threads:[~2018-06-07 18:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07 17:28 [PATCH v3 (Only) 1/3] btrfs-progs: map-logical: look at next leaf if slot > items james harvey
2018-06-07 18:41 ` james harvey [this message]
2018-06-08  1:33   ` [PATCH v3 (Only) 2/3] btrfs-progs: map-logical: Use btrfs_next_extent_item() Su Yue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+X5Wn6EP4nxGA7hE4HCUa9jWpk3XVVPdR0zb1v9Yd-y9kH5Ew@mail.gmail.com \
    --to=jamespharvey20@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=suy.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.