From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wi0-f177.google.com ([209.85.212.177]:52802 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752006AbaKSLnu (ORCPT ); Wed, 19 Nov 2014 06:43:50 -0500 Received: by mail-wi0-f177.google.com with SMTP id l15so1532428wiw.4 for ; Wed, 19 Nov 2014 03:43:49 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1416397317.9374.1.camel@sipsolutions.net> References: <1415551822-20121-1-git-send-email-arik@wizery.com> <1415551822-20121-16-git-send-email-arik@wizery.com> <1416396152.9374.0.camel@sipsolutions.net> <1416397317.9374.1.camel@sipsolutions.net> From: Arik Nemtsov Date: Wed, 19 Nov 2014 13:43:34 +0200 Message-ID: (sfid-20141119_124353_454004_3CFDEA94) Subject: Re: [PATCH 16/16] mac80211: synchronously reserve TID per station To: Johannes Berg Cc: "linux-wireless@vger.kernel.org" , Liad Kaufman Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Nov 19, 2014 at 1:41 PM, Johannes Berg wrote: > On Wed, 2014-11-19 at 13:40 +0200, Arik Nemtsov wrote: >> On Wed, Nov 19, 2014 at 1:22 PM, Johannes Berg >> wrote: >> > On Sun, 2014-11-09 at 18:50 +0200, Arik Nemtsov wrote: >> > >> >> + if (WARN_ON(tid >= IEEE80211_NUM_TIDS)) >> >> + return -EINVAL; >> > >> > That validates < 16 >> > >> >> + queues = BIT(sdata->vif.hw_queue[ieee802_1d_to_ac[tid]]); >> > >> > but that's only valid for < 8, causing a smatch warning. >> >> It's a valid warning. It should be tid & 7 here. I'll send a fix. > > yes, but I think &7 is wrong too - TIDs (really TSIDs) 8-15 don't have a > static AC mapping, and we don't support them anyway. I think the sanity > check should just make sure it's < 8. yea you're right. was just writing this :) Arik