* [PATCH] drivers: iio: replace comma with a semicolon
@ 2017-03-30 12:41 Arushi Singhal
2017-03-30 18:16 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Arushi Singhal @ 2017-03-30 12:41 UTC (permalink / raw)
To: jic23
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, linux-kernel, outreachy-kernel
Replace a comma between expression statements by a semicolon. This
changes the semantics of the code, but given the current indentation
appears to be what is intended.
A simplified version of the Coccinelle semantic patch that performs this
transformation is as follows:
// <smpl>
@r@
expression e1,e2;
@@
e1
-,
+;
e2;
// </smpl>
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/iio/chemical/ams-iaq-core.c | 2 +-
drivers/iio/chemical/vz89x.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/chemical/ams-iaq-core.c b/drivers/iio/chemical/ams-iaq-core.c
index 41a8e6f2e31d..c948ad2ee9ad 100644
--- a/drivers/iio/chemical/ams-iaq-core.c
+++ b/drivers/iio/chemical/ams-iaq-core.c
@@ -163,7 +163,7 @@ static int ams_iaqcore_probe(struct i2c_client *client,
mutex_init(&data->lock);
indio_dev->dev.parent = &client->dev;
- indio_dev->info = &ams_iaqcore_info,
+ indio_dev->info = &ams_iaqcore_info;
indio_dev->name = dev_name(&client->dev);
indio_dev->modes = INDIO_DIRECT_MODE;
diff --git a/drivers/iio/chemical/vz89x.c b/drivers/iio/chemical/vz89x.c
index 8e0e4415c161..f75eea6822f2 100644
--- a/drivers/iio/chemical/vz89x.c
+++ b/drivers/iio/chemical/vz89x.c
@@ -393,7 +393,7 @@ static int vz89x_probe(struct i2c_client *client,
mutex_init(&data->lock);
indio_dev->dev.parent = &client->dev;
- indio_dev->info = &vz89x_info,
+ indio_dev->info = &vz89x_info;
indio_dev->name = dev_name(&client->dev);
indio_dev->modes = INDIO_DIRECT_MODE;
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: iio: replace comma with a semicolon
2017-03-30 12:41 [PATCH] drivers: iio: replace comma with a semicolon Arushi Singhal
@ 2017-03-30 18:16 ` Jonathan Cameron
2017-03-30 18:34 ` Arushi Singhal
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2017-03-30 18:16 UTC (permalink / raw)
To: Arushi Singhal
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, linux-kernel, outreachy-kernel
On 30/03/17 13:41, Arushi Singhal wrote:
> Replace a comma between expression statements by a semicolon. This
> changes the semantics of the code, but given the current indentation
> appears to be what is intended.
> A simplified version of the Coccinelle semantic patch that performs this
> transformation is as follows:
>
> // <smpl>
> @r@
> expression e1,e2;
> @@
>
> e1
> -,
> +;
> e2;
> // </smpl>
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
As per the discussion about the other one. This is perfectly
correct, but weird enough that I think we'll clear it out.
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
I did add chemical to the title though to make it clearer what
this was covering.
Thanks,
Jonathan
> ---
> drivers/iio/chemical/ams-iaq-core.c | 2 +-
> drivers/iio/chemical/vz89x.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/chemical/ams-iaq-core.c b/drivers/iio/chemical/ams-iaq-core.c
> index 41a8e6f2e31d..c948ad2ee9ad 100644
> --- a/drivers/iio/chemical/ams-iaq-core.c
> +++ b/drivers/iio/chemical/ams-iaq-core.c
> @@ -163,7 +163,7 @@ static int ams_iaqcore_probe(struct i2c_client *client,
> mutex_init(&data->lock);
>
> indio_dev->dev.parent = &client->dev;
> - indio_dev->info = &ams_iaqcore_info,
> + indio_dev->info = &ams_iaqcore_info;
> indio_dev->name = dev_name(&client->dev);
> indio_dev->modes = INDIO_DIRECT_MODE;
>
> diff --git a/drivers/iio/chemical/vz89x.c b/drivers/iio/chemical/vz89x.c
> index 8e0e4415c161..f75eea6822f2 100644
> --- a/drivers/iio/chemical/vz89x.c
> +++ b/drivers/iio/chemical/vz89x.c
> @@ -393,7 +393,7 @@ static int vz89x_probe(struct i2c_client *client,
> mutex_init(&data->lock);
>
> indio_dev->dev.parent = &client->dev;
> - indio_dev->info = &vz89x_info,
> + indio_dev->info = &vz89x_info;
> indio_dev->name = dev_name(&client->dev);
> indio_dev->modes = INDIO_DIRECT_MODE;
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: iio: replace comma with a semicolon
2017-03-30 18:16 ` Jonathan Cameron
@ 2017-03-30 18:34 ` Arushi Singhal
2017-04-02 9:05 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Arushi Singhal @ 2017-03-30 18:34 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, LKML, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 2327 bytes --]
On Thu, Mar 30, 2017 at 11:46 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 30/03/17 13:41, Arushi Singhal wrote:
> > Replace a comma between expression statements by a semicolon. This
> > changes the semantics of the code, but given the current indentation
> > appears to be what is intended.
> > A simplified version of the Coccinelle semantic patch that performs this
> > transformation is as follows:
> >
> > // <smpl>
> > @r@
> > expression e1,e2;
> > @@
> >
> > e1
> > -,
> > +;
> > e2;
> > // </smpl>
> >
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> As per the discussion about the other one. This is perfectly
> correct, but weird enough that I think we'll clear it out.
>
>
Applied to the togreg branch of iio.git and pushed out as testing
> for the autobuilders to play with it.
>
> I did add chemical to the title though to make it clearer what
> this was covering.
>
Thanks Jonathan
Do I need to resend it with revised patch subject.
Arushi
>
> Thanks,
>
> Jonathan
> > ---
> > drivers/iio/chemical/ams-iaq-core.c | 2 +-
> > drivers/iio/chemical/vz89x.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/chemical/ams-iaq-core.c
> b/drivers/iio/chemical/ams-iaq-core.c
> > index 41a8e6f2e31d..c948ad2ee9ad 100644
> > --- a/drivers/iio/chemical/ams-iaq-core.c
> > +++ b/drivers/iio/chemical/ams-iaq-core.c
> > @@ -163,7 +163,7 @@ static int ams_iaqcore_probe(struct i2c_client
> *client,
> > mutex_init(&data->lock);
> >
> > indio_dev->dev.parent = &client->dev;
> > - indio_dev->info = &ams_iaqcore_info,
> > + indio_dev->info = &ams_iaqcore_info;
> > indio_dev->name = dev_name(&client->dev);
> > indio_dev->modes = INDIO_DIRECT_MODE;
> >
> > diff --git a/drivers/iio/chemical/vz89x.c b/drivers/iio/chemical/vz89x.c
> > index 8e0e4415c161..f75eea6822f2 100644
> > --- a/drivers/iio/chemical/vz89x.c
> > +++ b/drivers/iio/chemical/vz89x.c
> > @@ -393,7 +393,7 @@ static int vz89x_probe(struct i2c_client *client,
> > mutex_init(&data->lock);
> >
> > indio_dev->dev.parent = &client->dev;
> > - indio_dev->info = &vz89x_info,
> > + indio_dev->info = &vz89x_info;
> > indio_dev->name = dev_name(&client->dev);
> > indio_dev->modes = INDIO_DIRECT_MODE;
> >
> >
>
>
[-- Attachment #2: Type: text/html, Size: 3554 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: iio: replace comma with a semicolon
2017-03-30 18:34 ` Arushi Singhal
@ 2017-04-02 9:05 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2017-04-02 9:05 UTC (permalink / raw)
To: Arushi Singhal
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, LKML, outreachy-kernel
On 30/03/17 19:34, Arushi Singhal wrote:
>
>
> On Thu, Mar 30, 2017 at 11:46 PM, Jonathan Cameron <jic23@kernel.org <mailto:jic23@kernel.org>> wrote:
>
> On 30/03/17 13:41, Arushi Singhal wrote:
> > Replace a comma between expression statements by a semicolon. This
> > changes the semantics of the code, but given the current indentation
> > appears to be what is intended.
> > A simplified version of the Coccinelle semantic patch that performs this
> > transformation is as follows:
> >
> > // <smpl>
> > @r@
> > expression e1,e2;
> > @@
> >
> > e1
> > -,
> > +;
> > e2;
> > // </smpl>
> >
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com <mailto:arushisinghal19971997@gmail.com>>
> As per the discussion about the other one. This is perfectly
> correct, but weird enough that I think we'll clear it out.
>
>
> Applied to the togreg branch of iio.git and pushed out as testing
> for the autobuilders to play with it.
>
> I did add chemical to the title though to make it clearer what
> this was covering.
>
> Thanks Jonathan
> Do I need to resend it with revised patch subject.
> Arushi
Nope. I tend to just fix things like that when applying
(unless it's a repeat of something I have been moaning about in which
case I might bounce it back for another version!) Honestly it's
quicker to just fix it than to have to go through another round of
patches.
Just occasionally I mess it such fixes up though so always worth a
quick check when I have applied a patch.
Jonathan
>
>
> Thanks,
>
> Jonathan
> > ---
> > drivers/iio/chemical/ams-iaq-core.c | 2 +-
> > drivers/iio/chemical/vz89x.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/chemical/ams-iaq-core.c b/drivers/iio/chemical/ams-iaq-core.c
> > index 41a8e6f2e31d..c948ad2ee9ad 100644
> > --- a/drivers/iio/chemical/ams-iaq-core.c
> > +++ b/drivers/iio/chemical/ams-iaq-core.c
> > @@ -163,7 +163,7 @@ static int ams_iaqcore_probe(struct i2c_client *client,
> > mutex_init(&data->lock);
> >
> > indio_dev->dev.parent = &client->dev;
> > - indio_dev->info = &ams_iaqcore_info,
> > + indio_dev->info = &ams_iaqcore_info;
> > indio_dev->name = dev_name(&client->dev);
> > indio_dev->modes = INDIO_DIRECT_MODE;
> >
> > diff --git a/drivers/iio/chemical/vz89x.c b/drivers/iio/chemical/vz89x.c
> > index 8e0e4415c161..f75eea6822f2 100644
> > --- a/drivers/iio/chemical/vz89x.c
> > +++ b/drivers/iio/chemical/vz89x.c
> > @@ -393,7 +393,7 @@ static int vz89x_probe(struct i2c_client *client,
> > mutex_init(&data->lock);
> >
> > indio_dev->dev.parent = &client->dev;
> > - indio_dev->info = &vz89x_info,
> > + indio_dev->info = &vz89x_info;
> > indio_dev->name = dev_name(&client->dev);
> > indio_dev->modes = INDIO_DIRECT_MODE;
> >
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-02 9:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-30 12:41 [PATCH] drivers: iio: replace comma with a semicolon Arushi Singhal
2017-03-30 18:16 ` Jonathan Cameron
2017-03-30 18:34 ` Arushi Singhal
2017-04-02 9:05 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.