* [PATCH v2 0/2] Remove Typedefs.
@ 2017-03-21 15:18 ` Arushi Singhal
0 siblings, 0 replies; 9+ messages in thread
From: Arushi Singhal @ 2017-03-21 15:06 UTC (permalink / raw)
To: linux-fbdev
Cc: outreachy-kernel, Michael.Hennerich, teddy.wang, gregkh, speakup,
devel, linux-kernel, sudipm.mukherjee, linux-iio, Arushi Singhal
Typedefs are removed in sm750fb driver.
Arushi Singhal (2):
staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t"
staging: sm750fb: Remove typedef from "typedef enum _spolarity_t"
drivers/staging/sm750fb/ddk750_mode.c | 8 +++++---
drivers/staging/sm750fb/ddk750_mode.h | 19 ++++++++-----------
drivers/staging/sm750fb/sm750_hw.c | 2 +-
3 files changed, 14 insertions(+), 15 deletions(-)
--
changes in v2
-change the spelling of coverpatch subject.
2.11.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/2] staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t"
2017-03-21 15:18 ` Arushi Singhal
@ 2017-03-21 15:18 ` Arushi Singhal
-1 siblings, 0 replies; 9+ messages in thread
From: Arushi Singhal @ 2017-03-21 15:06 UTC (permalink / raw)
To: linux-fbdev
Cc: outreachy-kernel, Michael.Hennerich, teddy.wang, gregkh, speakup,
devel, linux-kernel, sudipm.mukherjee, linux-iio, Arushi Singhal
This patch removes typedefs from struct and renames it from "typedef
struct _mode_parameter_t" to "struct mode_parameter" as per kernel
coding standards."
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
changes in v2
-change the subject and commit message of PATCH.
drivers/staging/sm750fb/ddk750_mode.c | 8 +++++---
drivers/staging/sm750fb/ddk750_mode.h | 8 +++-----
drivers/staging/sm750fb/sm750_hw.c | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
index eea5aef2956f..9665bb9478dc 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -12,7 +12,8 @@
* HW only supports 7 predefined pixel clocks, and clock select is
* in bit 29:27 of Display Control register.
*/
-static unsigned long displayControlAdjust_SM750LE(mode_parameter_t *pModeParam, unsigned long dispControl)
+static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
+ unsigned long dispControl)
{
unsigned long x, y;
@@ -72,7 +73,8 @@ static unsigned long displayControlAdjust_SM750LE(mode_parameter_t *pModeParam,
}
/* only timing related registers will be programed */
-static int programModeRegisters(mode_parameter_t *pModeParam, struct pll_value *pll)
+static int programModeRegisters(struct mode_parameter *pModeParam,
+ struct pll_value *pll)
{
int ret = 0;
int cnt = 0;
@@ -198,7 +200,7 @@ static int programModeRegisters(mode_parameter_t *pModeParam, struct pll_value *
return ret;
}
-int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock)
+int ddk750_setModeTiming(struct mode_parameter *parm, clock_type_t clock)
{
struct pll_value pll;
unsigned int uiActualPixelClk;
diff --git a/drivers/staging/sm750fb/ddk750_mode.h b/drivers/staging/sm750fb/ddk750_mode.h
index 6d204b8b4a01..9dc4d6c5a779 100644
--- a/drivers/staging/sm750fb/ddk750_mode.h
+++ b/drivers/staging/sm750fb/ddk750_mode.h
@@ -9,7 +9,7 @@ typedef enum _spolarity_t {
}
spolarity_t;
-typedef struct _mode_parameter_t {
+struct mode_parameter {
/* Horizontal timing. */
unsigned long horizontal_total;
unsigned long horizontal_display_end;
@@ -31,9 +31,7 @@ typedef struct _mode_parameter_t {
/* Clock Phase. This clock phase only applies to Panel. */
spolarity_t clock_phase_polarity;
-}
-mode_parameter_t;
-
-int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock);
+};
+int ddk750_setModeTiming(struct mode_parameter *parm, clock_type_t clock);
#endif
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index fab3fc9c8330..baf1bbdc92ff 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -252,7 +252,7 @@ int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc,
{
int ret, fmt;
u32 reg;
- mode_parameter_t modparm;
+ struct mode_parameter modparm;
clock_type_t clock;
struct sm750_dev *sm750_dev;
struct lynxfb_par *par;
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] staging: sm750fb: Remove typedef from "typedef enum _spolarity_t"
2017-03-21 15:18 ` Arushi Singhal
@ 2017-03-21 15:18 ` Arushi Singhal
-1 siblings, 0 replies; 9+ messages in thread
From: Arushi Singhal @ 2017-03-21 15:06 UTC (permalink / raw)
To: linux-fbdev
Cc: outreachy-kernel, Michael.Hennerich, teddy.wang, gregkh, speakup,
devel, linux-kernel, sudipm.mukherjee, linux-iio, Arushi Singhal
This patch removes typedefs from enum and renames it from "typedef enum
_spolarity_t" to "enum spolarity" as per kernel coding standards."
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
changes in v2
-change the subject and commit message of PATCH.
drivers/staging/sm750fb/ddk750_mode.h | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.h b/drivers/staging/sm750fb/ddk750_mode.h
index 9dc4d6c5a779..d5eae36d85cb 100644
--- a/drivers/staging/sm750fb/ddk750_mode.h
+++ b/drivers/staging/sm750fb/ddk750_mode.h
@@ -3,11 +3,10 @@
#include "ddk750_chip.h"
-typedef enum _spolarity_t {
+enum spolarity {
POS = 0, /* positive */
NEG, /* negative */
-}
-spolarity_t;
+};
struct mode_parameter {
/* Horizontal timing. */
@@ -15,14 +14,14 @@ struct mode_parameter {
unsigned long horizontal_display_end;
unsigned long horizontal_sync_start;
unsigned long horizontal_sync_width;
- spolarity_t horizontal_sync_polarity;
+ enum spolarity horizontal_sync_polarity;
/* Vertical timing. */
unsigned long vertical_total;
unsigned long vertical_display_end;
unsigned long vertical_sync_start;
unsigned long vertical_sync_height;
- spolarity_t vertical_sync_polarity;
+ enum spolarity vertical_sync_polarity;
/* Refresh timing. */
unsigned long pixel_clock;
@@ -30,7 +29,7 @@ struct mode_parameter {
unsigned long vertical_frequency;
/* Clock Phase. This clock phase only applies to Panel. */
- spolarity_t clock_phase_polarity;
+ enum spolarity clock_phase_polarity;
};
int ddk750_setModeTiming(struct mode_parameter *parm, clock_type_t clock);
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 0/2] Remove Typedefs.
@ 2017-03-21 15:18 ` Arushi Singhal
0 siblings, 0 replies; 9+ messages in thread
From: Arushi Singhal @ 2017-03-21 15:18 UTC (permalink / raw)
To: linux-fbdev
Cc: outreachy-kernel, Michael.Hennerich, teddy.wang, gregkh, speakup,
devel, linux-kernel, sudipm.mukherjee, linux-iio, Arushi Singhal
Typedefs are removed in sm750fb driver.
Arushi Singhal (2):
staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t"
staging: sm750fb: Remove typedef from "typedef enum _spolarity_t"
drivers/staging/sm750fb/ddk750_mode.c | 8 +++++---
drivers/staging/sm750fb/ddk750_mode.h | 19 ++++++++-----------
drivers/staging/sm750fb/sm750_hw.c | 2 +-
3 files changed, 14 insertions(+), 15 deletions(-)
--
changes in v2
-change the spelling of coverpatch subject.
2.11.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/2] staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t"
@ 2017-03-21 15:18 ` Arushi Singhal
0 siblings, 0 replies; 9+ messages in thread
From: Arushi Singhal @ 2017-03-21 15:18 UTC (permalink / raw)
To: linux-fbdev
Cc: outreachy-kernel, Michael.Hennerich, teddy.wang, gregkh, speakup,
devel, linux-kernel, sudipm.mukherjee, linux-iio, Arushi Singhal
This patch removes typedefs from struct and renames it from "typedef
struct _mode_parameter_t" to "struct mode_parameter" as per kernel
coding standards."
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
changes in v2
-change the subject and commit message of PATCH.
drivers/staging/sm750fb/ddk750_mode.c | 8 +++++---
drivers/staging/sm750fb/ddk750_mode.h | 8 +++-----
drivers/staging/sm750fb/sm750_hw.c | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
index eea5aef2956f..9665bb9478dc 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -12,7 +12,8 @@
* HW only supports 7 predefined pixel clocks, and clock select is
* in bit 29:27 of Display Control register.
*/
-static unsigned long displayControlAdjust_SM750LE(mode_parameter_t *pModeParam, unsigned long dispControl)
+static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
+ unsigned long dispControl)
{
unsigned long x, y;
@@ -72,7 +73,8 @@ static unsigned long displayControlAdjust_SM750LE(mode_parameter_t *pModeParam,
}
/* only timing related registers will be programed */
-static int programModeRegisters(mode_parameter_t *pModeParam, struct pll_value *pll)
+static int programModeRegisters(struct mode_parameter *pModeParam,
+ struct pll_value *pll)
{
int ret = 0;
int cnt = 0;
@@ -198,7 +200,7 @@ static int programModeRegisters(mode_parameter_t *pModeParam, struct pll_value *
return ret;
}
-int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock)
+int ddk750_setModeTiming(struct mode_parameter *parm, clock_type_t clock)
{
struct pll_value pll;
unsigned int uiActualPixelClk;
diff --git a/drivers/staging/sm750fb/ddk750_mode.h b/drivers/staging/sm750fb/ddk750_mode.h
index 6d204b8b4a01..9dc4d6c5a779 100644
--- a/drivers/staging/sm750fb/ddk750_mode.h
+++ b/drivers/staging/sm750fb/ddk750_mode.h
@@ -9,7 +9,7 @@ typedef enum _spolarity_t {
}
spolarity_t;
-typedef struct _mode_parameter_t {
+struct mode_parameter {
/* Horizontal timing. */
unsigned long horizontal_total;
unsigned long horizontal_display_end;
@@ -31,9 +31,7 @@ typedef struct _mode_parameter_t {
/* Clock Phase. This clock phase only applies to Panel. */
spolarity_t clock_phase_polarity;
-}
-mode_parameter_t;
-
-int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock);
+};
+int ddk750_setModeTiming(struct mode_parameter *parm, clock_type_t clock);
#endif
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index fab3fc9c8330..baf1bbdc92ff 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -252,7 +252,7 @@ int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc,
{
int ret, fmt;
u32 reg;
- mode_parameter_t modparm;
+ struct mode_parameter modparm;
clock_type_t clock;
struct sm750_dev *sm750_dev;
struct lynxfb_par *par;
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] staging: sm750fb: Remove typedef from "typedef enum _spolarity_t"
@ 2017-03-21 15:18 ` Arushi Singhal
0 siblings, 0 replies; 9+ messages in thread
From: Arushi Singhal @ 2017-03-21 15:18 UTC (permalink / raw)
To: linux-fbdev
Cc: outreachy-kernel, Michael.Hennerich, teddy.wang, gregkh, speakup,
devel, linux-kernel, sudipm.mukherjee, linux-iio, Arushi Singhal
This patch removes typedefs from enum and renames it from "typedef enum
_spolarity_t" to "enum spolarity" as per kernel coding standards."
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
changes in v2
-change the subject and commit message of PATCH.
drivers/staging/sm750fb/ddk750_mode.h | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.h b/drivers/staging/sm750fb/ddk750_mode.h
index 9dc4d6c5a779..d5eae36d85cb 100644
--- a/drivers/staging/sm750fb/ddk750_mode.h
+++ b/drivers/staging/sm750fb/ddk750_mode.h
@@ -3,11 +3,10 @@
#include "ddk750_chip.h"
-typedef enum _spolarity_t {
+enum spolarity {
POS = 0, /* positive */
NEG, /* negative */
-}
-spolarity_t;
+};
struct mode_parameter {
/* Horizontal timing. */
@@ -15,14 +14,14 @@ struct mode_parameter {
unsigned long horizontal_display_end;
unsigned long horizontal_sync_start;
unsigned long horizontal_sync_width;
- spolarity_t horizontal_sync_polarity;
+ enum spolarity horizontal_sync_polarity;
/* Vertical timing. */
unsigned long vertical_total;
unsigned long vertical_display_end;
unsigned long vertical_sync_start;
unsigned long vertical_sync_height;
- spolarity_t vertical_sync_polarity;
+ enum spolarity vertical_sync_polarity;
/* Refresh timing. */
unsigned long pixel_clock;
@@ -30,7 +29,7 @@ struct mode_parameter {
unsigned long vertical_frequency;
/* Clock Phase. This clock phase only applies to Panel. */
- spolarity_t clock_phase_polarity;
+ enum spolarity clock_phase_polarity;
};
int ddk750_setModeTiming(struct mode_parameter *parm, clock_type_t clock);
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/2] Remove Typedefs.
2017-03-21 15:18 ` Arushi Singhal
` (2 preceding siblings ...)
(?)
@ 2017-03-21 19:34 ` Jonathan Cameron
2017-03-21 19:37 ` Arushi Singhal
-1 siblings, 1 reply; 9+ messages in thread
From: Jonathan Cameron @ 2017-03-21 19:34 UTC (permalink / raw)
To: Arushi Singhal, linux-fbdev
Cc: outreachy-kernel, Michael.Hennerich, teddy.wang, gregkh, speakup,
devel, linux-kernel, sudipm.mukherjee, linux-iio
On 21/03/17 15:06, Arushi Singhal wrote:
> Typedefs are removed in sm750fb driver.
>
> Arushi Singhal (2):
> staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t"
> staging: sm750fb: Remove typedef from "typedef enum _spolarity_t"
>
> drivers/staging/sm750fb/ddk750_mode.c | 8 +++++---
> drivers/staging/sm750fb/ddk750_mode.h | 19 ++++++++-----------
> drivers/staging/sm750fb/sm750_hw.c | 2 +-
> 3 files changed, 14 insertions(+), 15 deletions(-)
>
Please be careful to only cc linux-iio for patches with an IIO component...
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/2] Remove Typedefs.
2017-03-21 19:34 ` [PATCH v2 0/2] Remove Typedefs Jonathan Cameron
@ 2017-03-21 19:37 ` Arushi Singhal
0 siblings, 0 replies; 9+ messages in thread
From: Arushi Singhal @ 2017-03-21 19:37 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Linux Fbdev development list, outreachy-kernel,
Michael Hennerich, Teddy Wang, Greg KH, speakup, driverdevel,
linux-kernel, Sudip Mukherjee, linux-iio
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On Wed, Mar 22, 2017 at 1:04 AM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 21/03/17 15:06, Arushi Singhal wrote:
> > Typedefs are removed in sm750fb driver.
> >
> > Arushi Singhal (2):
> > staging: sm750fb: Remove typedef from "typedef struct
> _mode_parameter_t"
> > staging: sm750fb: Remove typedef from "typedef enum _spolarity_t"
> >
> > drivers/staging/sm750fb/ddk750_mode.c | 8 +++++---
> > drivers/staging/sm750fb/ddk750_mode.h | 19 ++++++++-----------
> > drivers/staging/sm750fb/sm750_hw.c | 2 +-
> > 3 files changed, 14 insertions(+), 15 deletions(-)
> >
> Please be careful to only cc linux-iio for patches with an IIO component...
>
Sorry
>From next I will not repeat the same.
Thanks
Arushi
[-- Attachment #2: Type: text/html, Size: 1214 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/2] Remove Typedefs.
@ 2017-03-21 19:37 ` Arushi Singhal
0 siblings, 0 replies; 9+ messages in thread
From: Arushi Singhal @ 2017-03-21 19:37 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Linux Fbdev development list, outreachy-kernel,
Michael Hennerich, Teddy Wang, Greg KH, speakup, driverdevel,
linux-kernel, Sudip Mukherjee, linux-iio
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On Wed, Mar 22, 2017 at 1:04 AM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 21/03/17 15:06, Arushi Singhal wrote:
> > Typedefs are removed in sm750fb driver.
> >
> > Arushi Singhal (2):
> > staging: sm750fb: Remove typedef from "typedef struct
> _mode_parameter_t"
> > staging: sm750fb: Remove typedef from "typedef enum _spolarity_t"
> >
> > drivers/staging/sm750fb/ddk750_mode.c | 8 +++++---
> > drivers/staging/sm750fb/ddk750_mode.h | 19 ++++++++-----------
> > drivers/staging/sm750fb/sm750_hw.c | 2 +-
> > 3 files changed, 14 insertions(+), 15 deletions(-)
> >
> Please be careful to only cc linux-iio for patches with an IIO component...
>
Sorry
From next I will not repeat the same.
Thanks
Arushi
[-- Attachment #2: Type: text/html, Size: 1214 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-03-21 19:37 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-21 15:06 [PATCH v2 0/2] Remove Typedefs Arushi Singhal
2017-03-21 15:18 ` Arushi Singhal
2017-03-21 15:06 ` [PATCH v2 1/2] staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t" Arushi Singhal
2017-03-21 15:18 ` Arushi Singhal
2017-03-21 15:06 ` [PATCH v2 2/2] staging: sm750fb: Remove typedef from "typedef enum _spolarity_t" Arushi Singhal
2017-03-21 15:18 ` Arushi Singhal
2017-03-21 19:34 ` [PATCH v2 0/2] Remove Typedefs Jonathan Cameron
2017-03-21 19:37 ` Arushi Singhal
2017-03-21 19:37 ` Arushi Singhal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.