From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f68.google.com (mail-ua1-f68.google.com [209.85.222.68]) by mail.openembedded.org (Postfix) with ESMTP id D34467FC2D for ; Mon, 25 Nov 2019 22:22:37 +0000 (UTC) Received: by mail-ua1-f68.google.com with SMTP id o9so4993794uat.8 for ; Mon, 25 Nov 2019 14:22:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UgJUbBDR/JNnpMQGuEj9pmNayvz4qvaj6ERuPxw8auo=; b=wfGcY8Tkq4WUnB1JJnujpwK5+DQnwBWP4H/YA0zkB0056KEWfyK7j4f0l3270Xw7d9 Q0/WmjO8mxLlANeh5hEzBVADxSXWP614fyuBOKc0jkv4+6cVwlmj5hgNGgHagnsJfY/n QQEj6FiMWSorJ3vskle7hmoOJbqV6vc8uMXAmNkIAE67bpp0O7GC+saDW5QWRW8UOUzm LB6znSdLFrgmCn+gTlf+0GjkUtQzo1Fqv7Nj1tW8clS9VEAuIdfmlRR5Q0Jk+dXPScO5 RU2YIp3heOoMj/oZjt+XY69rIJQZutKc1sRvHxlNyj5MXGDAdAoN1lqEZenp1i2nvbqx BwhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UgJUbBDR/JNnpMQGuEj9pmNayvz4qvaj6ERuPxw8auo=; b=C5cDuDX5HvVp22ykXWQfDYtD7D9RgsxnqjKQd+59PvI0ToslIoKGHBPpR5eGA8/3lX FSsrEGDyFF0AVblsgNG6b+z0NEdiNGeX+O7Q48/YWUF05tmq16sg7A5uFZOKxexKonta n9MDvSZx40vgCx2Kgw9QQon8XQVxjNzhDgfjR7vGYtyYsOMq2my0cKkMm4+t6UZefaLK Bc1HALt8CrFnJy41/s0KgNKZX5VIlKGwbL06WNnpuze278BbtxpDFVNBgCFgiMJjGrlG 4xHGNVc74b8mnxbhcqY2pt3E1DHUa1Z7OXMeUx0No7XATFhpSKxSwY3SQ86DZ1i6Ztev fF0Q== X-Gm-Message-State: APjAAAXua+PQIfmB+RK1OD49iwGdu4Y1rjSpceLs0+ro322qwgVAzW4L tSmh47E+GOohos+4ICad3PE0TpC+JdGVcDBI9utMv/JPZ/c= X-Google-Smtp-Source: APXvYqzm0I8hwLtvaT0O851tm3lxVgvum/BNEtPKcmmxKt8S1qCAIV8dQUJ0WMXcT+7fHZvmpt+DwMQKOXagpujtWyg= X-Received: by 2002:ab0:41c2:: with SMTP id 60mr11123088uap.36.1574720558170; Mon, 25 Nov 2019 14:22:38 -0800 (PST) MIME-Version: 1.0 References: <20191113232303.29047-1-anibal.limon@linaro.org> <3ba6b1a5788f453aa1974a13342d148c@XBOX03.axis.com> In-Reply-To: From: Anibal Limon Date: Mon, 25 Nov 2019 16:22:27 -0600 Message-ID: To: bitbake-devel Subject: Re: [PATCH] lib/bb: Add BB_SIGNATURE_LOCAL_DIRS_EXCLUDE to speed-up taskhash on directories X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussion that advance bitbake development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Nov 2019 22:22:38 -0000 Content-Type: multipart/alternative; boundary="0000000000007da088059833335a" --0000000000007da088059833335a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Regarding some comments in PATCHv2 where default value was set [1], I agree that this patch will be better and then set default value in oe-core. [1] http://lists.openembedded.org/pipermail/bitbake-devel/2019-November/020519.= html On Thu, 14 Nov 2019 at 12:08, Anibal Limon wrote: > > > On Thu, 14 Nov 2019 at 12:07, Anibal Limon > wrote: > >> >> On Thu, 14 Nov 2019 at 10:54, Peter Kjellerstedt < >> peter.kjellerstedt@axis.com> wrote: >> >>> > -----Original Message----- >>> > From: bitbake-devel-bounces@lists.openembedded.org >> > bounces@lists.openembedded.org> On Behalf Of Khem Raj >>> > Sent: den 14 november 2019 03:55 >>> > To: An=C3=ADbal Lim=C3=B3n >>> > Cc: bitbake-devel >>> > Subject: Re: [bitbake-devel] [PATCH] lib/bb: Add >>> > BB_SIGNATURE_LOCAL_DIRS_EXCLUDE to speed-up taskhash on directories >>> > >>> > On Wed, Nov 13, 2019 at 3:23 PM An=C3=ADbal Lim=C3=B3n >>> > wrote: >>> > > >>> > > The new BB_SIGNATURE_LOCAL_DIRS_EXCLUDE allows you to specify a lis= t >>> > > of directories to exclude when making taskhash, our specific case >>> > > is using SRC_URI that points local VCS directory. >>> > > >>> > > In OE-Core this variable could be set by default to: >>> > > >>> > > BB_SIGNATURE_LOCAL_DIRS_EXCLUDE =3D ".cvs .git .svn" >>> >>> That should be: >>> >>> BB_SIGNATURE_LOCAL_DIRS_EXCLUDE =3D "CVS .git .svn" >>> >> >> So I will change to, >> >> + self.localdirsexclude =3D (data.getVar("BB_SIGNATURE_LOCAL_DIRS_EXCLUD= E") >> or "CVS .git .svn").split() >> >> Any other directory to add it? >> > > Replying myself... > > What about add all VCS directories that we support in fetcher. > > >> >> Cheers, >> Anibal >> >> >>> >>> > I like the approach. perhaps a sane default would be nice. >>> >>> //Peter >>> >>> --0000000000007da088059833335a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Regarding some comments in PATCHv2 where default valu= e was set [1], I agree that this patch will be better and then set default = value
in oe-core.


On Thu, 14 Nov 2019 at 12:08, Anibal Limon <anibal.limon@linaro.org> wrote:
=


On Thu, 14 Nov 2019 at 12:07, Anibal Limon <anibal.limon@linaro.org&g= t; wrote:

On Thu, 14 Nov 2019 at 10:54, Peter Kjellerst= edt <pe= ter.kjellerstedt@axis.com> wrote:
> -----Original Message-----
> From: bitbake-devel-bounces@lists.openembedded.org <bitb= ake-devel-
> bo= unces@lists.openembedded.org> On Behalf Of Khem Raj
> Sent: den 14 november 2019 03:55
> To: An=C3=ADbal Lim=C3=B3n <anibal.limon@linaro.org>
> Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>
> Subject: Re: [bitbake-devel] [PATCH] lib/bb: Add
> BB_SIGNATURE_LOCAL_DIRS_EXCLUDE to speed-up taskhash on directories >
> On Wed, Nov 13, 2019 at 3:23 PM An=C3=ADbal Lim=C3=B3n <anibal.limon@linaro.org>
> wrote:
> >
> > The new BB_SIGNATURE_LOCAL_DIRS_EXCLUDE allows you to specify a l= ist
> > of directories to exclude when making taskhash, our specific case=
> > is using SRC_URI that points local VCS directory.
> >
> > In OE-Core this variable could be set by default to:
> >
> > BB_SIGNATURE_LOCAL_DIRS_EXCLUDE =3D ".cvs .git .svn"
That should be:

BB_SIGNATURE_LOCAL_DIRS_EXCLUDE =3D "CVS .git .svn"

So I will change to,

+ self= .localdirsexclude =3D (data.getVar("BB_SIGNATURE_LOCAL_DIRS_EXCLUDE&qu= ot;) or "CVS .git .svn").split()

Any= other directory to add it?

Replying myself...

--0000000000007da088059833335a--