From: Pranay Srivastava <pranjas@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: William Hubbs <w.d.hubbs@gmail.com>,
Christopher Brannon <chris@the-brannons.com>,
kirk@reisers.ca, Samuel Thibault <samuel.thibault@ens-lyon.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
speakup@linux-speakup.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as per required context
Date: Fri, 24 Mar 2017 15:44:02 +0530 [thread overview]
Message-ID: <CA+aCy1FPdRnihN-Yb7K0t=Ne_-aK+4_u98ydQ65sd7OK_Nhj5g@mail.gmail.com> (raw)
In-Reply-To: <20170324084341.GA10793@kroah.com>
On Fri, Mar 24, 2017 at 2:13 PM, Greg KH <greg@kroah.com> wrote:
> On Fri, Mar 24, 2017 at 02:07:11PM +0530, Pranay Kr. Srivastava wrote:
>> speakup_allocate used GFP_ATOMIC for allocations
>> even while during initialization due to it's use
>> in notifier call.
>
> Is that a problem?
No that's the way it should be. I was just trying to say that allocation
should be context based[?]. If we can be lenient then that's better[?]
>
>> Pass GFP_ flags as well to speakup_allocate depending
>> on the context it is called in.
>
> At init, we should be fine to use GFP_ATOMIC, so is this change really
> needed?
>
> thanks,
>
> greg k-h
--
---P.K.S
next prev parent reply other threads:[~2017-03-24 10:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 8:27 [PATCH SPEAKUP v2 0/3] cleanup error and initilization Pranay Kr. Srivastava
2017-02-28 8:27 ` [PATCH SPEAKUP v2 1/3] return same error value from spk_set_key_info Pranay Kr. Srivastava
2017-02-28 9:04 ` Samuel Thibault
2017-03-01 7:51 ` Greg KH
2017-03-21 7:10 ` [PATCH staging/speakup v3 0/3] cleanup error and initilization Pranay Kr. Srivastava
2017-03-21 7:10 ` [PATCH staging/speakup v3 1/3] return same error value from spk_set_key_info Pranay Kr. Srivastava
2017-03-21 7:10 ` [PATCH staging/speakup v3 2/3] remove unnecessary initial allocation of vc Pranay Kr. Srivastava
2017-03-21 7:10 ` [PATCH staging/speakup v3 3/3] use speakup_allocate as per required context Pranay Kr. Srivastava
2017-03-23 13:17 ` Greg KH
2017-03-24 8:37 ` [[RESEND]PATCH " Pranay Kr. Srivastava
2017-03-24 8:43 ` Greg KH
2017-03-24 10:14 ` Pranay Srivastava [this message]
2017-02-28 8:27 ` [PATCH SPEAKUP v2 2/3] remove unecessary initial allocation of vc Pranay Kr. Srivastava
2017-02-28 9:05 ` Samuel Thibault
2017-02-28 8:27 ` [PATCH SPEAKUP v2 3/3] use spkeaup_allocate as per required context Pranay Kr. Srivastava
2017-02-28 9:05 ` Samuel Thibault
2017-03-01 7:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+aCy1FPdRnihN-Yb7K0t=Ne_-aK+4_u98ydQ65sd7OK_Nhj5g@mail.gmail.com' \
--to=pranjas@gmail.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=sfr@canb.auug.org.au \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.