All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cleber Rosa <crosa@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>,
	Richard Henderson <richard.henderson@linaro.org>,
	QEMU devel <qemu-devel@nongnu.org>
Subject: Re: Regression caught by replay_kernel.py:ReplayKernelNormal.test_aarch64_virt
Date: Tue, 27 Jul 2021 10:15:02 -0400	[thread overview]
Message-ID: <CA+bd_6L47217UTjyWLrn45JHDMJa0eaDMOW6JQFFZRqkpfpkTA@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA8aEkSRABqJ4-_SJ9-dS=M4jeaW=OQH99BaZUs5Lq0u=w@mail.gmail.com>

On Tue, Jul 27, 2021 at 9:48 AM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 27 Jul 2021 at 14:24, Cleber Rosa <crosa@redhat.com> wrote:
> > Yes, I've spent quite some time with some flaky behavior while running
> > the replay tests as well. But in the end, the test remained unchanged
> > because we found the issues in the actual code under test (one time
> > the recording of the replay file would sometimes be corrupted when
> > using >=1 CPUs, but 100% of the time when using a single CPU).
> >
> > This time, it was failing 100% of the time in my experience, and now,
> > after the fix in df3a2de51a07089a4a729fe1f792f658df9dade4, it's
> > passing 100% of the time.  So I guess even tests with some observed
> > flakiness can have their value.
>
> To me they have very little value, because once I notice a test
> is flaky I simply start to ignore whether it is passing or failing,
> and then it might as well not be there at all.
> (This is happening currently with the gitlab CI tests, which have
> been failing for a week.)
>
> -- PMM
>

I hear you... and I acknowledge that we currently don't have a good
solution for keeping track of the test results data and thus going
beyond one's perceived value of a test.

It's not something for the short term, but I do plan to work on a
"confidence" tracker for tests.  There is some seed work in the CKI
data warehouse project[1] but it's very incipient.

- Cleber.

[1] - https://gitlab.com/cki-project/datawarehouse/-/blob/main/datawarehouse/views.py#L158



      reply	other threads:[~2021-07-27 14:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27  0:39 Regression caught by replay_kernel.py:ReplayKernelNormal.test_aarch64_virt Cleber Rosa
2021-07-27  5:57 ` Pavel Dovgalyuk
2021-07-27  7:36 ` Peter Maydell
2021-07-27 13:18   ` Cleber Rosa
2021-07-27 13:46     ` Peter Maydell
2021-07-27  9:16 ` Peter Maydell
2021-07-27 13:23   ` Cleber Rosa
2021-07-27 13:47     ` Peter Maydell
2021-07-27 14:15       ` Cleber Rosa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+bd_6L47217UTjyWLrn45JHDMJa0eaDMOW6JQFFZRqkpfpkTA@mail.gmail.com \
    --to=crosa@redhat.com \
    --cc=pavel.dovgalyuk@ispras.ru \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.