Re: [OE-core] [PATCH] gtk-icon-cache.bbclass: update RDEPENDS

From: "Martin Jansa" <Martin.Jansa@gmail.com>
To: Changqing Li <changqing.li@windriver.com>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>,
	 Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] gtk-icon-cache.bbclass: update RDEPENDS
Date: Fri, 10 Jul 2020 18:37:04 +0200	[thread overview]
Message-ID: <CA+chaQc3oXSrbDYdWKRyFEbqn9oNHdeiAVexmzVndwcyYFEBog@mail.gmail.com> (raw)
In-Reply-To: <61ba6f0c-0bb3-42fa-408e-c2396d5a2773@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 2985 bytes --]

With this change now in master and dunfell there is signature issue in
allarch adwaita-icon-theme now runtime depending on TUNE_PKGARCH gdk-pixbuf
as shown by sstate-diff-machines.sh/bitbake-diffsigs:

bitbake-diffsigs
tmp-glibc/sstate-diff/1594398219/qemu*/all-webos-linux/adwaita-icon-theme/*do_prepare_recipe_sysroot*
NOTE: Starting bitbake server...
NOTE: Started PRServer with DBfile: cache/prserv.sqlite3, IP: 127.0.0.1,
PORT: 33511, PID: 36423
Hash for dependent task gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot
changed from
a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 to
1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f
Unable to find matching sigdata for
openembedded-core/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot
with hashes
a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 or
1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f

On Wed, Jul 1, 2020 at 3:39 AM Changqing Li <changqing.li@windriver.com>
wrote:

>
> On 6/30/20 6:01 PM, Richard Purdie wrote:
> > On Tue, 2020-06-30 at 17:49 +0800, Changqing Li wrote:
> >> From: Changqing Li <changqing.li@windriver.com>
> >>
> >> fix error:
> >> + /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-query-loaders --update-cache
> >> /var/tmp/rpm-tmp.mdYxY6: line 12: /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-
> >> query-loaders: No such file or directory
> >> %post(adwaita-icon-theme-3.36.1-r0.0.noarch): waitpid(2961) rc 2961
> >> status 7f00
> >> warning: %post(adwaita-icon-theme-3.36.1-r0.0.noarch) scriptlet
> >> failed, exit status 127
> >>
> >> when install adwaita-icon-theme, which inherit gtk-icon-cache
> >> on target, above error reported,  fix by add needeed packages
> >> in RDEPENDS
> >>
> >> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> >> ---
> >>   meta/classes/gtk-icon-cache.bbclass | 2 ++
> >>   1 file changed, 2 insertions(+)
> >>
> >> diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-
> >> icon-cache.bbclass
> >> index 91cb4ad409..7f218ce7ae 100644
> >> --- a/meta/classes/gtk-icon-cache.bbclass
> >> +++ b/meta/classes/gtk-icon-cache.bbclass
> >> @@ -4,6 +4,8 @@ DEPENDS +=" ${@['hicolor-icon-theme', '']['${BPN}' ==
> >> 'hicolor-icon-theme']} gtk
> >>
> >>   PACKAGE_WRITE_DEPS += "gtk+3-native gdk-pixbuf-native"
> >>
> >> +RDEPENDS_${PN} += "gdk-pixbuf gtk+3"
> >> +
> >>   gtk_icon_cache_postinst() {
> >>   if [ "x$D" != "x" ]; then
> >>      $INTERCEPT_DIR/postinst_intercept update_gtk_icon_cache ${PKG}
> >> \
> > This isn't quite right since the postinst may be added to a package
> > other than ${PN}.
> >
> > You need to add the RDEPENDS to the code:
> >
> >          rdepends = ' ' + d.getVar('MLPREFIX', False) +
> "hicolor-icon-theme"
> >          d.appendVar('RDEPENDS_%s' % pkg, rdepends)
> >
> > later in that class.
> >
> > Cheers,
> >
> > Richard
> Thanks, I will correct it.
> >
> 
>

[-- Attachment #2: Type: text/html, Size: 4007 bytes --]