From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by mail.openembedded.org (Postfix) with ESMTP id 3783B74A32 for ; Sat, 19 May 2018 05:42:22 +0000 (UTC) Received: by mail-wm0-f65.google.com with SMTP id n10-v6so18449365wmc.1 for ; Fri, 18 May 2018 22:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n2yAv1nLrUhWuy5ZsSXHhAraB5DO94RTGhjfD48faDA=; b=L505x/mt7QytI+70LfT9IRvr8pL34bJoeopCZOFe8DFwHFB0Zx9PajFgBenEIifPy0 r+30j8pIWkhdhjEtI+Yn3tZeUPiTJqlJ6uR4fFOI/TDFC8xtdX/b5wn030uLtGb1X3Gc 8uzRpYctuYqTKipax+BtYhWg9E8/QmRj26banTwfC1+OpTglOIVM7dFXvFJz903xLVo/ ACB8UJKGNe5IkjXakyTfp+OyoijIiH84t1V660sqTK8T23xfbLloI6w82m3364OfqX2V Kb6xNLl+sry8SXwPQVYYx780mLLQ5KI4+RZlhAPE8aLdesRd/UcuSvXUtzE9WACqBg8T BZTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n2yAv1nLrUhWuy5ZsSXHhAraB5DO94RTGhjfD48faDA=; b=Sb+hRpnRb4V5WWsXrbzPqjGRmz6ifiHW3yPiKz1NoC38qopbYHOug1+iq6OQR8sKsy C3WYP8TmFLn+Y2Guu+KJkjRNFAIU5+uuvjQsc45TT1uZ4J2MmLHAmAoZTnPrRFIuuqY6 9Bp3R5PtfFt7OKFMtw051gckfChWzEGlRZudw2+DKz5xmFaDtSNYeETgx/4ShrilO3RW n/+T0HUmtJ6r3vNlUP3Pj7qIZOa+QXajVy+gmsqG//+AIffkHmezRWe2THEBoX9qD/8z q/RU66uOf7MZA6GBQy/+1u18EBVbsLiS1dDrmz5mLTAn79bvE6hxtes7CJT5G/2JIduK HCEQ== X-Gm-Message-State: ALKqPwcvRUqJ2OsPewB9WlhiIiq9ND+yJH3JabMmPCeKOKNLn8OlP8Ni yldtWzWhGKApAvT8YHBy7GAZI5JQcr4EK0os83A= X-Google-Smtp-Source: AB8JxZpohZPifFaaJS8vmFm5CZaEIZoBRfO0StkgZpKxn/RXDdZt6yPnTql8RN5aFrn7ZW/3afShibUf0uRjyTiQDpY= X-Received: by 2002:a1c:bfce:: with SMTP id o75-v6mr5706372wmi.122.1526708543344; Fri, 18 May 2018 22:42:23 -0700 (PDT) MIME-Version: 1.0 References: <1526683840-20390-1-git-send-email-armccurdy@gmail.com> In-Reply-To: From: Martin Jansa Date: Sat, 19 May 2018 07:42:11 +0200 Message-ID: To: Khem Raj Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH] arch-armv7a.inc: default to Thumb2 instruction set for armv7a and above X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 May 2018 05:42:23 -0000 Content-Type: multipart/alternative; boundary="00000000000066d4ac056c8888b0" --00000000000066d4ac056c8888b0 Content-Type: text/plain; charset="UTF-8" This variable was always meant to be used from DISTRO config, why not add it to: oe-core/meta/conf/distro/include/default-distrovars.inc or oe-core/meta/conf/distro/include/tcmode-default.inc ? On Sat, May 19, 2018 at 1:40 AM Khem Raj wrote: > > On Fri, May 18, 2018 at 3:50 PM Andre McCurdy wrote: > >> Although there may still be specific cases which can benefit from the >> ARM instruction set, the Thumb2 instruction set is generally a better >> default for armv7a class CPUs. Distros such as Debian and Fedora have >> been targeting Thumb2 by default for some time. >> >> Note that setting ARM_INSTRUCTION_SET has no effect unless >> TUNE_FEATURES contains "thumb" (which is controlled by the "t" suffix >> in DEFAULTTUNE, e.g. armv7vehf-neon -vs- armv7vethf-neon, etc) so out >> of tree machine configs may need to update their DEFAULTTUNE to take >> advantage of this change. > > > > I think this is a good change and we shoudl take it in thumb2 is default > ISA > for other major distros as well > > Oe based distros who ship feeds might be affected > >> >> >> Signed-off-by: Andre McCurdy >> --- >> meta/conf/machine/include/arm/arch-armv7a.inc | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc >> b/meta/conf/machine/include/arm/arch-armv7a.inc >> index bad1c27..a2663d8 100644 >> --- a/meta/conf/machine/include/arm/arch-armv7a.inc >> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc >> @@ -1,4 +1,5 @@ >> DEFAULTTUNE ?= "armv7athf" >> +ARM_INSTRUCTION_SET ?= "thumb" >> >> TUNEVALID[armv7a] = "Enable instructions for ARMv7-a" >> TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7" >> -- >> 1.9.1 >> >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > --00000000000066d4ac056c8888b0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This variable was always meant to be used from DISTRO conf= ig, why not add it to:
oe-core/meta/conf/distro/include/default-distrov= ars.inc
or
oe-core/meta/conf/distro/include/tcmode-= default.inc

?

On Sat, May 19, 2018 at 1:40 AM Khem Raj <raj.khem@gmail.com> wrote:

On Fri, May 18, 2018 at 3:50 PM Andre McCurdy <armccurdy@gmail.com> wr= ote:
Although there may still be sp= ecific cases which can benefit from the
ARM instruction set, the Thumb2 instruction set is generally a better
default for armv7a class CPUs. Distros such as Debian and Fedora have
been targeting Thumb2 by default for some time.

Note that setting ARM_INSTRUCTION_SET has no effect unless
TUNE_FEATURES contains "thumb" (which is controlled by the "= t" suffix
in DEFAULTTUNE, e.g. armv7vehf-neon -vs- armv7vethf-neon, etc) so out
of tree machine configs may need to update their DEFAULTTUNE to take
advantage of this change.


I think this is a good change and we = shoudl take it in thumb2 is default ISA=C2=A0
for ot= her major distros as well=C2=A0

Oe based distros who ship feeds might be affected=C2=A0


Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
=C2=A0meta/conf/machine/include/arm/arch-armv7a.inc | 1 +
=C2=A01 file changed, 1 insertion(+)

diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc b/meta/conf/mach= ine/include/arm/arch-armv7a.inc
index bad1c27..a2663d8 100644
--- a/meta/conf/machine/include/arm/arch-armv7a.inc
+++ b/meta/conf/machine/include/arm/arch-armv7a.inc
@@ -1,4 +1,5 @@
=C2=A0DEFAULTTUNE ?=3D "armv7athf"
+ARM_INSTRUCTION_SET ?=3D "thumb"

=C2=A0TUNEVALID[armv7a] =3D "Enable instructions for ARMv7-a"
=C2=A0TUNECONFLICTS[armv7a] =3D "armv4 armv5 armv6 armv7"
--
1.9.1

--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailma= n/listinfo/openembedded-core
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailma= n/listinfo/openembedded-core
--00000000000066d4ac056c8888b0--