OK, thanks for looking into that, I was assuming that native nsinstall is
provided by nss-native dependency we have and wasn't aware that it's built
for host as part of target build as well.

+1

On Tue, Feb 23, 2021 at 10:31 PM Andrei Gherzan <andrei@gherzan.com> wrote:

> On Tue, 23 Feb 2021, at 17:47, Andrei Gherzan wrote:
> > On Tue, 23 Feb 2021, at 17:30, Martin Jansa wrote:
> > > On Tue, Feb 23, 2021 at 05:19:16PM +0000, Andrei Gherzan wrote:
> > > > On Tue, 23 Feb 2021, at 17:15, Khem Raj wrote:
> > > > > On Tue, Feb 23, 2021 at 9:12 AM Martin Jansa <
> martin.jansa@gmail.com> wrote:
> > > > > >
> > > > > > On Tue, Feb 23, 2021 at 04:27:05PM +0000, Andrei Gherzan wrote:
> > > > > > > From: Khem Raj <raj.khem@gmail.com>
> > > > > > >
> > > > > > > We are seeing warnigs with gcc-10 even on target builds e.g.
> > > > > >
> > > > > > Do you use gcc-10 in dunfell builds?
> > > > > >
> > > > > > dunfell has 9.3.0 gcc, so either you're using gcc-10 through some
> > > > > > backports or the warning is reproducible also with gcc-9, but
> I'm not
> > > > > > seeing nss failures in my dunfell builds.
> > > > >
> > > > > I think its the native one he is running into issues. Perhaps he
> has
> > > > > newer build host OS which has gcc 10
> > > >
> > > > That is indeed the case. I'm running 10.2.0 on my host as of now.
> > >
> > > _on your host_, but why is it needed for target builds which should use
> > > gcc-cross-* 9.3.0?
> >
> > Good point. Let me take a deeper look into it and come back to you.
>
> I have taken a look into this and I think the conclusion is that your
> builds are not running on hosts with gcc-10+. The target build compiles a
> native tool: check nss/coreconf/nsinstall. This is why, as part of the
> recipe, we are passing the NATIVE_CC (as BUILD_CC) to get this pointing to
> the host's gcc. The Makefile in the path above uses it for compiling
> nsinstall.
>
> ```
> ifdef NATIVE_CC
> CC=$(NATIVE_CC)
> endif
> ```
>
> So this patch remains relevant for builds where this patch is not applied
> (for example dunfell) and on which the host provides gcc 10+.
>
> --
> Andrei
>