All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: JackieHuang <jackie.huang@windriver.com>
Cc: openembedded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-oe][PATCH 2/2] corosync: add support for extra features
Date: Tue, 5 Sep 2017 14:30:05 +0200	[thread overview]
Message-ID: <CA+chaQcm0g_6Di-h93_Kn=v6i+h+C1D6HtaVFFaZuwbgrsfkWQ@mail.gmail.com> (raw)
In-Reply-To: <6286ca12b20fb1972ee77d1fc217eb7ebbf60080.1503998700.git.jackie.huang@windriver.com>

Can you please also fix:
corosync-2.4.2: ELF binary '/tmp/work/core2-64-oe-linux/
corosync/2.4.2-r0/packages-split/corosync/usr/sbin/corosync' has
relocations in .text [textrel]

it's been there for long time.

On Tue, Aug 29, 2017 at 11:27 AM, <jackie.huang@windriver.com> wrote:

> From: Jackie Huang <jackie.huang@windriver.com>
>
> * Add support for features: dbus qdevice qnetd snmp
> * Add related PACKAGECONFIG
> * inherit useradd to add proper user for qnetd service
>
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>  .../recipes-extended/corosync/corosync_2.4.2.bb    | 30
> +++++++++++++++++++---
>  1 file changed, 27 insertions(+), 3 deletions(-)
>
> diff --git a/meta-oe/recipes-extended/corosync/corosync_2.4.2.bb
> b/meta-oe/recipes-extended/corosync/corosync_2.4.2.bb
> index 2f3aef299..7d5a87e4c 100644
> --- a/meta-oe/recipes-extended/corosync/corosync_2.4.2.bb
> +++ b/meta-oe/recipes-extended/corosync/corosync_2.4.2.bb
> @@ -5,7 +5,7 @@ HOMEPAGE = "http://corosync.github.io/corosync/"
>
>  SECTION = "base"
>
> -inherit autotools pkgconfig systemd
> +inherit autotools pkgconfig systemd useradd
>
>  SRC_URI = "http://build.clusterlabs.org/corosync/releases/${BP}.tar.gz"
>  SRC_URI[md5sum] = "547fa78704da53aa35912be58d31035f"
> @@ -16,13 +16,23 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=
> a85eb4ce24033adb6088dd1d6ffc5e5d"
>
>  DEPENDS = "groff-native nss libqb"
>
> -SYSTEMD_SERVICE_${PN} = "corosync.service corosync-notifyd.service"
> +SYSTEMD_SERVICE_${PN} = "corosync.service corosync-notifyd.service \
> +                         ${@bb.utils.contains('PACKAGECONFIG',
> 'qdevice', 'corosync-qdevice.service', '', d)} \
> +                         ${@bb.utils.contains('PACKAGECONFIG', 'qnetd',
> 'corosync-qnetd.service', '', d)} \
> +"
>  SYSTEMD_AUTO_ENABLE = "enable"
>
>  INITSCRIPT_NAME = "corosync-daemon"
>
> -PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
> +PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
> +                   dbus qdevice qnetd snmp \
> +"
>
> +PACKAGECONFIG[dbus] = "--enable-dbus,--disable-dbus,dbus"
> +PACKAGECONFIG[qdevice] = "--enable-qdevices,--disable-qdevices"
> +PACKAGECONFIG[qnetd] = "--enable-qnetd,--disable-qnetd"
> +PACKAGECONFIG[rdma] = "--enable-rdma,--disable-rdma"
> +PACKAGECONFIG[snmp] = "--enable-snmp,--disable-snmp,net-snmp"
>  PACKAGECONFIG[systemd] = "--enable-systemd --with-systemddir=${systemd_
> system_unitdir},--disable-systemd --without-systemddir,systemd"
>
>  EXTRA_OECONF = "ac_cv_path_BASHPATH=${base_bindir}/bash"
> @@ -43,12 +53,26 @@ do_install_append() {
>      install -d ${D}${sysconfdir}/default/volatiles
>      echo "d root root 0755 ${localstatedir}/log/cluster none" >
> ${D}${sysconfdir}/default/volatiles/05_corosync
>
> +    if ${@bb.utils.contains('PACKAGECONFIG', 'qnetd', 'true', 'false',
> d)}; then
> +        chown -R coroqnetd:coroqnetd ${D}${sysconfdir}/${BPN}/qnetd
> +        echo "d coroqnetd coroqnetd 0770 /var/run/corosync-qnetd none" >>
> ${D}${sysconfdir}/default/volatiles/05_corosync
> +    fi
> +
>      if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)};
> then
>          install -d ${D}${sysconfdir}/tmpfiles.d
>          echo "d ${localstatedir}/log/cluster - - - -" >
> ${D}${sysconfdir}/tmpfiles.d/corosync.conf
> +
> +        if ${@bb.utils.contains('PACKAGECONFIG', 'qnetd', 'true',
> 'false', d)}; then
> +            install -m 0644 ${S}/conf/tmpfiles.d/corosync-qnetd.conf
> ${D}${sysconfdir}/tmpfiles.d
> +        fi
>      fi
>  }
>
>  RDEPENDS_${PN} += "bash"
>
>  FILES_${PN}-dbg += "${libexecdir}/lcrso/.debug"
> +FILES_${PN}-doc += "${datadir}/snmp/mibs/COROSYNC-MIB.txt"
> +
> +USERADD_PACKAGES = "${PN}"
> +GROUPADD_PARAM_${PN} = "--system coroqnetd"
> +USERADD_PARAM_${PN} = "--system -d / -M -s /bin/nologin -c 'User for
> corosync-qnetd' -g coroqnetd coroqnetd"
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>


  reply	other threads:[~2017-09-05 12:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29  9:27 [meta-oe][PATCH 0/2] corosync: fixes and add support for extra features jackie.huang
2017-08-29  9:27 ` [meta-oe][PATCH 1/2] corosync: fixes for sysvinit and systemd jackie.huang
2017-08-29  9:27 ` [meta-oe][PATCH 2/2] corosync: add support for extra features jackie.huang
2017-09-05 12:30   ` Martin Jansa [this message]
2017-09-06  1:01     ` Huang, Jie (Jackie)
2017-09-06  1:08       ` Khem Raj
2017-09-07  1:02         ` Huang, Jie (Jackie)
2017-09-07  8:50           ` Martin Jansa
2017-09-08  2:37             ` Huang, Jie (Jackie)
2017-09-08  3:50               ` Khem Raj
2017-09-08  6:01                 ` Huang, Jie (Jackie)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+chaQcm0g_6Di-h93_Kn=v6i+h+C1D6HtaVFFaZuwbgrsfkWQ@mail.gmail.com' \
    --to=martin.jansa@gmail.com \
    --cc=jackie.huang@windriver.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.