All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin Jansa" <Martin.Jansa@gmail.com>
To: Damian Wrobel <dwrobel@ertelnet.rybnik.pl>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>,
	 bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: Re: [bitbake-devel] [PATCH] cooker: Only warn on potentially incompatible layer
Date: Tue, 7 Sep 2021 15:57:02 +0200	[thread overview]
Message-ID: <CA+chaQf+u6gyD_XdgKbzEq=JXi=3vZvYoM85QEBPnt4nYtxG1Q@mail.gmail.com> (raw)
In-Reply-To: <17bc0861fe8.10265a7ec273381.5356961515124934870@ertelnet.rybnik.pl>

[-- Attachment #1: Type: text/plain, Size: 2980 bytes --]

You can modify LAYERSERIES_COMPAT_clang-layer to whatever you need after
you provide whatever is needed for layer (a) to be compatible with the rest
of your stack of layers.

See meta-qt5-compat as an example
https://github.com/webosose/meta-webosose/tree/2db6a1bc8e1a6f82db5b8f345d5aaa29e74fede5/meta-qt5-compat

Regards,

On Tue, Sep 7, 2021 at 3:50 PM Damian Wrobel <dwrobel@ertelnet.rybnik.pl>
wrote:

>
>
>
>  ---- On Tue, 07 Sep 2021 13:40:07 +0200 Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote ----
>  > On Tue, 2021-09-07 at 01:54 -0700, Damian Wrobel wrote:
>  > > On Sat, Sep 4, 2021 at 09:54 AM, Richard Purdie wrote:
>  > > > Adding a single keyword every six months to show the layer is
> active and
>  > > > meant
>  > > > to work with a new release is not in my view a huge maintenance
> burden
>  > > > compared
>  > > > to showing that the layer is actively maintained and clearly
> showing which
>  > > > combinations are meant to work.
>  > >
>  > > It's not feasible because if the layer required some extra bbclasses
> cherry-
>  > > picked to be support it in the older yocto, then no one can simply
> add this
>  > > keyword to mark it's supported with older yocto.
>  >
>  > I don't understand your example here. If you can cherry-pick changes
> into a
>  > layer, you can also add a patch to mark the layer as supported using the
>  > standard variables?
>
> Let's consider the following example:
>
> a) meta-layer-which-we-want-to-consume (contains:
> LAYERSERIES_COMPAT_clang-layer = "gatesgarth hardknott")
> b) openembedded-core
> c) bitbake
> d) meta-our-layer
>
> By saying that layer (a) required some extra bbclasses to be cherry-picked
> I meant that
> in order to use layer (a) we had to cherry-pick some extra bbclasses or
> other changes
> into (d) to get (a) working with (b) and (c).
>
> This worked for us when (b), (c) and (d) were on yocto morty, but stopped
> to work when
> we switched to dunfell because dunfell started to utilize
> LAYERSERIES_COMPAT.
>
> This is very common situation that nothing needs to be modified in (a) to
> get it working with different versions
> of (b) and (c).
>
> So the question is why we have to modify also (a) to make (c) happy?
>
> --
> Regards,
> Damian
>
>  >
>  > > This in practise means that despite the layer itself didn't require
> any
>  > > changes to be supported in older yocto it will be unconditionally
> rejected by
>  > > bitbake.
>  >
>  > Your previous sentence says "the layer required some extra bbclasses"
> so it did
>  > need changes?
>  >
>  > > So, in reality it mean that such a layer has to be forked and
> modified to be
>  > > accepted by bitbake.
>  > >
>  > > I hope this clearly shows why this kind of checking in bitbake is
>  > > inappropriate.
>  >
>  > I'm afraid I don't understand your example.
>  >
>  > Cheers,
>  >
>  > Richard
>  >
>  >
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 3875 bytes --]

  reply	other threads:[~2021-09-07 13:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-03 14:28 [PATCH] cooker: Only warn on potentially incompatible layer Damian Wrobel
2021-09-03 17:07 ` [bitbake-devel] " Richard Purdie
2021-09-03 17:53   ` Damian Wrobel
2021-09-04  7:54     ` [bitbake-devel] " Richard Purdie
2021-09-05  8:40       ` Peter Kjellerstedt
2021-09-07  8:54       ` Damian Wrobel
2021-09-07 11:40         ` [bitbake-devel] " Richard Purdie
2021-09-07 13:50           ` Damian Wrobel
2021-09-07 13:57             ` Martin Jansa [this message]
2021-09-07 14:06             ` Alexander Kanavin
2021-09-07 15:35               ` Damian Wrobel
2021-09-07 15:49                 ` [bitbake-devel] " Alexander Kanavin
2021-09-07 16:38                   ` Damian Wrobel
2021-09-07 19:17                     ` [bitbake-devel] " Richard Purdie
2021-09-07 20:18                       ` Alexander Kanavin
2021-09-08  9:56 ` Enrico Scholz
2021-09-08 12:36   ` Peter Kjellerstedt
2021-09-08 13:35   ` Damian Wrobel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+chaQf+u6gyD_XdgKbzEq=JXi=3vZvYoM85QEBPnt4nYtxG1Q@mail.gmail.com' \
    --to=martin.jansa@gmail.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=dwrobel@ertelnet.rybnik.pl \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.