All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin Jansa" <Martin.Jansa@gmail.com>
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>,
	Jon Mason <jdmason@kudzu.us>
Subject: Re: [OE-core] [PATCH] tune-cortexa65.inc: Correct TUNE_FEATURES_tune-cortexa65
Date: Tue, 13 Oct 2020 00:24:49 +0200	[thread overview]
Message-ID: <CA+chaQf-4692XTUAiguks3ZmGg7mLXDeFbPsn-mjLRRCMcEfQQ@mail.gmail.com> (raw)
In-Reply-To: <20201012213137.15179-1-pkj@axis.com>

[-- Attachment #1: Type: text/plain, Size: 2448 bytes --]

Good catch, maybe we should require tune-test.sh test for all tune
modifying changes, it catches the issue as the very first tested case:

Testing fake MACHINE fake-cortexa65 for include
conf/machine/include/arm/armv8-2a/tune-cortexa65.inc (1/76)
ERROR: something wrong in openembedded-core/scripts/tune/log.fake-cortexa65

martin@jama:/OE/build/oe-core$ cat
openembedded-core/scripts/tune/log.fake-cortexa65
NOTE: Started PRServer with DBfile: /OE/build/oe-core/cache/prserv.sqlite3,
IP: 127.0.0.1, PORT: 44979, PID: 158972
ERROR:  OE-core's config sanity checker detected a potential
misconfiguration.
    Either fix the cause of this error or at your own risk disable the
checker (see sanity.conf).
    Following is the list of potential problems / advisories:

    Toolchain tunings invalid:
Tuning 'cortexa65' has the following errors:
Feature 'cortexa55' is not defined.


Summary: There was 1 ERROR message shown, returning a non-zero exit code.

I'll let it finish in master branch and update
https://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune-test
tomorrow.

On Mon, Oct 12, 2020 at 11:31 PM Peter Kjellerstedt <
peter.kjellerstedt@axis.com> wrote:

> It incorrectly specified "cortexa55" instead of "cortexa65".
>
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> ---
>  meta/conf/machine/include/arm/armv8-2a/tune-cortexa65.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/machine/include/arm/armv8-2a/tune-cortexa65.inc
> b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa65.inc
> index ecf17fbbe7..427e58947f 100644
> --- a/meta/conf/machine/include/arm/armv8-2a/tune-cortexa65.inc
> +++ b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa65.inc
> @@ -11,6 +11,6 @@ require conf/machine/include/arm/arch-armv8-2a.inc
>  # Little Endian base configs
>  AVAILTUNES                                         += "cortexa65"
>  ARMPKGARCH_tune-cortexa65                           = "cortexa65"
> -TUNE_FEATURES_tune-cortexa65                        =
> "${TUNE_FEATURES_tune-armv8-2a-crypto} cortexa55"
> +TUNE_FEATURES_tune-cortexa65                        =
> "${TUNE_FEATURES_tune-armv8-2a-crypto} cortexa65"
>  PACKAGE_EXTRA_ARCHS_tune-cortexa65                  =
> "${PACKAGE_EXTRA_ARCHS_tune-armv8-2a-crypto} cortexa65"
>  BASE_LIB_tune-cortexa65                             = "lib64"
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 3241 bytes --]

  reply	other threads:[~2020-10-12 22:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 21:31 [PATCH] tune-cortexa65.inc: Correct TUNE_FEATURES_tune-cortexa65 Peter Kjellerstedt
2020-10-12 22:24 ` Martin Jansa [this message]
2020-10-13  8:44   ` [OE-core] " Richard Purdie
2020-10-15 10:01     ` Martin Jansa
     [not found]     ` <163E22305B9C588F.27068@lists.openembedded.org>
2020-10-16  8:01       ` Martin Jansa
     [not found]       ` <163E6A3B404AC987.24259@lists.openembedded.org>
2020-10-18  8:30         ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+chaQf-4692XTUAiguks3ZmGg7mLXDeFbPsn-mjLRRCMcEfQQ@mail.gmail.com \
    --to=martin.jansa@gmail.com \
    --cc=jdmason@kudzu.us \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.kjellerstedt@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.