From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF72FC433EF for ; Mon, 20 Sep 2021 21:38:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE05F61244 for ; Mon, 20 Sep 2021 21:38:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AE05F61244 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7408D6E88D; Mon, 20 Sep 2021 21:38:06 +0000 (UTC) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 448FF6E88D for ; Mon, 20 Sep 2021 21:38:05 +0000 (UTC) Received: by mail-qk1-x72a.google.com with SMTP id a10so47702184qka.12 for ; Mon, 20 Sep 2021 14:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z0sMXVJD/qM1ZuMvbaI6gTOYJ9VpknbVlhhM0u7mejc=; b=dqxJA24uvAfZPUBpFHKmJEIZgdzPyGPS0Sq6uvZjU0gc6erEbkuQ4zhpwP4QD8z72u sw1LryOdbgCoGAlU671GWf8D56poCdkftvi5n9UVH0kydllWBUbg1UpLhPhtIlsWyTEf 1ut3yazIIgePgREspkn/NXAfNWrUlqhMj1SEs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z0sMXVJD/qM1ZuMvbaI6gTOYJ9VpknbVlhhM0u7mejc=; b=sPFuvwCKW838himQKv4rxAKCPiRGzb0jCPs3fw7Y5AQ5qkbHAerupOQVPvD1U4v9hX q7PZepbFeL0yZcf+ZsoVT1hR6120jtmmz1knhIG4mxxt/8i+tPjBC1YT5a1AzeT5KQJt FSQKbul5j6yRUwIViF8Sub3W7UKRWI+XK/8LUlhp3aLU+O6MHPRm9N7gNvMfgaDwtPwj UizdsuWKidIzumSJXqgc9fouGAzn1oqf7YbX6M5wssp/LVAKGgFjjIFHVzfPAoVwjbc+ VvzgxOotpBAvd6vC79YiX4xKcwkUM7x13ZO54srQrpYWR/dgCynAwlvIF8L3U5pK/tqA CliQ== X-Gm-Message-State: AOAM530dIYWsD7GgTAfmtuaTO4Lyx7Wns3DLtPrgX0FMSIrttk5GkOiJ ZI1fz2pV0FdSeoD1X0R+Irxs6XRKUhzFZw8VJB//dw== X-Google-Smtp-Source: ABdhPJyQjSb2H6udbpCD2GbTsqMT8sJOFWWkAqxky55HqdLzQrvRxx7S/aqKxyKWBV2AQNiIWArMAu4QAzyNU6Trgt8= X-Received: by 2002:a25:2f42:: with SMTP id v63mr34378682ybv.388.1632173884292; Mon, 20 Sep 2021 14:38:04 -0700 (PDT) MIME-Version: 1.0 References: <20210918102058.v5.1.I2351df94f18d5d8debc22d4d100f36fac560409a@changeid> <20210918102058.v5.2.Ifcb5df5de5b1cead7c99e0f37b044ef5cfc69eda@changeid> In-Reply-To: From: Philip Chen Date: Mon, 20 Sep 2021 14:37:53 -0700 Message-ID: Subject: Re: [PATCH v5 2/2] drm/bridge: parade-ps8640: Add support for AUX channel To: Sam Ravnborg Cc: LKML , Stephen Boyd , Douglas Anderson , Andrzej Hajda , Daniel Vetter , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Neil Armstrong , Robert Foss , dri-devel Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sam, On Sat, Sep 18, 2021 at 1:29 PM Sam Ravnborg wrote: > > Hi Philip, > On Sat, Sep 18, 2021 at 10:21:17AM -0700, Philip Chen wrote: > > Implement the first version of AUX support, which will be useful as > > we expand the driver to support varied use cases. > > > > Signed-off-by: Philip Chen > > Patch is: > Signed-off-by: Sam Ravnborg > > please consider a few follow-up patches: > 1) Replace deprecated drm_bridge_funcs with the _atomic_ variants. > 2) Replace the deprecated drm_bridge_chain_pre_enable() with the atomic > variant. > 3) Use pr_() and dev_() logging in favour of DRM_ logging. > DRM_ logging is deprecated these days and do not belong in bridge > drivers anyway. > > Maxime has a few patches pending for this driver - it would be great if > you could look them up and review them. > Maybe you can get some review in feedback. Yes, I'll do. Thanks for reviewing. > > Sam > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 796BCC433F5 for ; Tue, 21 Sep 2021 02:03:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6081960FA0 for ; Tue, 21 Sep 2021 02:03:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242715AbhIUCFR (ORCPT ); Mon, 20 Sep 2021 22:05:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235952AbhIUBsY (ORCPT ); Mon, 20 Sep 2021 21:48:24 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22D52C0612E4 for ; Mon, 20 Sep 2021 14:38:05 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id 194so22747649qkj.11 for ; Mon, 20 Sep 2021 14:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z0sMXVJD/qM1ZuMvbaI6gTOYJ9VpknbVlhhM0u7mejc=; b=dqxJA24uvAfZPUBpFHKmJEIZgdzPyGPS0Sq6uvZjU0gc6erEbkuQ4zhpwP4QD8z72u sw1LryOdbgCoGAlU671GWf8D56poCdkftvi5n9UVH0kydllWBUbg1UpLhPhtIlsWyTEf 1ut3yazIIgePgREspkn/NXAfNWrUlqhMj1SEs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z0sMXVJD/qM1ZuMvbaI6gTOYJ9VpknbVlhhM0u7mejc=; b=FdKy5PZwU4mqh9CMk4/kL4MRHV5qxpD5TnookNnsvC79IO2fSDPtMWiUz5q7o0PMou mtl6KbjIqOk/ZqHSP2SYYU4VH9/Uvm51U9LjiJL5JjRTYEwV7JIhvKI7FHUwywwPqCTg 1HpMqgCQtI4bnkChKeNU2kcs3Y0LFcBIBsEESJTtoL4fScgC0ZRokAwaQ4KMAxR2Pr1B PazFgHU1x4EsxvsUV4w4A55CdTnAHgnFU8B0YeL/OcIe/H5xqOu6cJt9o8tA+ShdEKLG JZijVVMrp1wWoZeYoySAQ7E1b8gqxsBFe9FVIwWq3DxYuPf6oDmXuuuHfVAW0NuquUm+ Bq6A== X-Gm-Message-State: AOAM531ee/Dwl0FhCShVTvqTNOk9cClo1yQwIVP/J8reP0jNtecorvZY VFzBYbdBjrA7kzdQz5zPBC1DWBq4zokvkUQf2AuaTA== X-Google-Smtp-Source: ABdhPJyQjSb2H6udbpCD2GbTsqMT8sJOFWWkAqxky55HqdLzQrvRxx7S/aqKxyKWBV2AQNiIWArMAu4QAzyNU6Trgt8= X-Received: by 2002:a25:2f42:: with SMTP id v63mr34378682ybv.388.1632173884292; Mon, 20 Sep 2021 14:38:04 -0700 (PDT) MIME-Version: 1.0 References: <20210918102058.v5.1.I2351df94f18d5d8debc22d4d100f36fac560409a@changeid> <20210918102058.v5.2.Ifcb5df5de5b1cead7c99e0f37b044ef5cfc69eda@changeid> In-Reply-To: From: Philip Chen Date: Mon, 20 Sep 2021 14:37:53 -0700 Message-ID: Subject: Re: [PATCH v5 2/2] drm/bridge: parade-ps8640: Add support for AUX channel To: Sam Ravnborg Cc: LKML , Stephen Boyd , Douglas Anderson , Andrzej Hajda , Daniel Vetter , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Neil Armstrong , Robert Foss , dri-devel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sam, On Sat, Sep 18, 2021 at 1:29 PM Sam Ravnborg wrote: > > Hi Philip, > On Sat, Sep 18, 2021 at 10:21:17AM -0700, Philip Chen wrote: > > Implement the first version of AUX support, which will be useful as > > we expand the driver to support varied use cases. > > > > Signed-off-by: Philip Chen > > Patch is: > Signed-off-by: Sam Ravnborg > > please consider a few follow-up patches: > 1) Replace deprecated drm_bridge_funcs with the _atomic_ variants. > 2) Replace the deprecated drm_bridge_chain_pre_enable() with the atomic > variant. > 3) Use pr_() and dev_() logging in favour of DRM_ logging. > DRM_ logging is deprecated these days and do not belong in bridge > drivers anyway. > > Maxime has a few patches pending for this driver - it would be great if > you could look them up and review them. > Maybe you can get some review in feedback. Yes, I'll do. Thanks for reviewing. > > Sam >