From: Philip Chen <philipchen@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Douglas Anderson <dianders@chromium.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Rob Herring <robh+dt@kernel.org>, Simon Glass <sjg@chromium.org>,
devicetree@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: input: cros-ec-keyb: Add a new property
Date: Wed, 13 Jan 2021 21:47:43 -0800 [thread overview]
Message-ID: <CA+cxXhkffakNXjqXsaCp0PU=4GnP58mVZcTA1g2eSn7G666V9w@mail.gmail.com> (raw)
In-Reply-To: <161058782774.3661239.6435895454078235399@swboyd.mtv.corp.google.com>
On Wed, Jan 13, 2021 at 5:30 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Philip Chen (2021-01-13 17:25:12)
> > This patch adds a new property `function-row-physmap` to the
>
> :)
Sorry, I'll make it imperative tense.
>
> > device tree for the custom keyboard top row design.
> >
> > The property describes the rows/columns of the top row keys
> > from left to right.
> >
> > Signed-off-by: Philip Chen <philipchen@chromium.org>
> > ---
> >
> > Changes in v5:
> > - add minItems and maxItems for `function-row-physmap`
> >
> > Changes in v2:
> > - add `function-row-physmap` instead of `google,custom-keyb-top-row`
> >
> > .../bindings/input/google,cros-ec-keyb.yaml | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > index 8e50c14a9d778..e573ef3e58b65 100644
> > --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > @@ -31,6 +31,18 @@ properties:
> > if the EC does not have its own logic or hardware for this.
> > type: boolean
> >
> > + function-row-physmap:
> > + $ref: '/schemas/types.yaml#/definitions/uint32-array'
>
> I'm not sure this is needed if min/max items is there.
>
> > + minItems: 1
> > + maxItems: 15
> > + description: |
> > + An ordered u32 array describing the rows/columns (in the scan matrix)
> > + of top row keys from physical left (KEY_F1) to right. Each entry
> > + encodes the row/column as:
> > + (((row) & 0xFF) << 24) | (((column) & 0xFF) << 16)
> > + where the lower 16 bits are reserved. This property is specified only
> > + when the keyboard has a custom design for the top row keys.
>
> Can you add it to the example so it can be tested? Then you can prove
> out if the ref is needed or not.
Sure, I'll give it a try.
>
> > +
> > required:
> > - compatible
> >
prev parent reply other threads:[~2021-01-14 5:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 1:25 [PATCH v5 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Philip Chen
2021-01-14 1:25 ` [PATCH v5 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace Philip Chen
2021-01-14 1:36 ` Stephen Boyd
2021-01-15 2:32 ` Philip Chen
2021-01-14 1:30 ` [PATCH v5 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Stephen Boyd
2021-01-14 5:47 ` Philip Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+cxXhkffakNXjqXsaCp0PU=4GnP58mVZcTA1g2eSn7G666V9w@mail.gmail.com' \
--to=philipchen@chromium.org \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sjg@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.