From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Crowe Date: Wed, 17 Feb 2021 09:27:15 +1030 Subject: [Buildroot] [PATCH 1/1] support/scripts/size-stats: increase number of files that can be linked to a source In-Reply-To: <20210216221037.36b7e48c@windsurf.home> References: <20210210110518.24817-1-daniel.crowe@resolution.systems> <20210216221037.36b7e48c@windsurf.home> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Thanks for the feedback. Happy to rework it as suggested. On Wed, 17 Feb 2021 at 07:40, Thomas Petazzoni wrote: > On Tue, 16 Feb 2021 15:06:39 +0100 > Thomas De Schampheleire wrote: > > > Please extend your commit message with more information: what is the > > problem you're fixing, and how are you fixing it. > > Right now, we can only guess what it is doing based on the code. > > > > It looks like the change is extending the size information to > > rootfs-overlays, while today only real packages are considered. > > But if that is correct, then the title "increase number of files that > > can be linked to a source" is confusing to me. > > The change is not just about the rootfs overlay, but also about taking > into account .pyc files compiled from .py files: > > + # account for python file compilation > + if fpath.endswith('.py'): > + add_file(filesdict, fpath + 'c', fullpath + 'c', pkg) > > This should at least be separated in another patch. I'm not a huge fan > of this approach, but I don't really have a good suggestion. Ideally, > we should byte-compile each package independently, so that it's part of > the install step of the package. But that would be vastly less > efficient than just byte-compiling everything in one go at the end of > the build, like we're doing. > > Daniel: could you rework your patch a bit, splitting it into several > patches, with a slightly improved commit log ? I think it makes a lot > of sense to have these improvements to size-stats. > > Thanks a lot! > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > -- *Daniel Crowe | Senior Embedded Developer* Resolution Systems Pty Ltd | L1 214 Greenhill Road, Eastwood South Australia, 5063, Australia m. +61 400 014 688 e. daniel.crowe at resolution.systems | www.resolution.systems [image: Resolution Systems] -------------- next part -------------- An HTML attachment was scrubbed... URL: