From: Andrey Konovalov <andreyknvl@gmail.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Marco Elver <elver@google.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Arnd Bergmann <arnd@arndb.de>,
kasan-dev <kasan-dev@googlegroups.com>,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev
Subject: Re: [PATCH] kasan: Always respect CONFIG_KASAN_STACK
Date: Wed, 6 Oct 2021 13:57:28 +0200 [thread overview]
Message-ID: <CA+fCnZc5=fqM=eEZ3RLqBFaxR72bjxndDdnM_rOkiSBi3+2L6A@mail.gmail.com> (raw)
In-Reply-To: <YV0NPnUbElw7cTRH@archlinux-ax161>
On Wed, Oct 6, 2021 at 4:43 AM Nathan Chancellor <nathan@kernel.org> wrote:
>
> > This part of code always looked weird to me.
> >
> > Shouldn't we be able to pull all these options out of the else section?
> >
> > Then, the code structure would make sense: first, try applying
> > KASAN_SHADOW_OFFSET; if failed, use CFLAGS_KASAN_MINIMAL; and then try
> > applying all these options one by one.
>
> Prior to commit 1a69e7ce8391 ("kasan/Makefile: support LLVM style asan
> parameters"), all the flags were run under one cc-option, meaning that
> if $(KASAN_SHADOW_OFFSET) was not set, the whole call would fail.
> However, after that commit, it is possible to do this but I was not sure
> if that was intentional so I went for the minimal fix.
Ack. Filed https://bugzilla.kernel.org/show_bug.cgi?id=214629 for the rest.
Thanks!
prev parent reply other threads:[~2021-10-06 11:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 20:55 [PATCH] kasan: Always respect CONFIG_KASAN_STACK Nathan Chancellor
2021-09-23 10:07 ` Marco Elver
2021-09-23 10:07 ` Marco Elver
2021-09-23 10:07 ` Marco Elver
2021-09-23 14:59 ` Nathan Chancellor
2021-09-23 14:59 ` Nathan Chancellor
2021-10-08 18:46 ` Palmer Dabbelt
2021-10-08 18:46 ` Palmer Dabbelt
2021-10-14 16:55 ` Nathan Chancellor
2021-10-14 16:55 ` Nathan Chancellor
2021-10-14 18:31 ` Alex Ghiti
2021-10-14 18:31 ` Alex Ghiti
2021-10-15 13:04 ` Alexandre ghiti
2021-10-15 13:04 ` Alexandre ghiti
2021-10-26 4:39 ` Alexandre Ghiti
2021-10-26 4:39 ` Alexandre Ghiti
2021-10-26 4:48 ` Dmitry Vyukov
2021-10-26 4:48 ` Dmitry Vyukov
2021-10-26 11:33 ` Alexandre Ghiti
2021-10-26 11:33 ` Alexandre Ghiti
2021-10-16 1:11 ` Palmer Dabbelt
2021-10-16 1:11 ` Palmer Dabbelt
2021-10-03 18:04 ` Andrey Konovalov
2021-10-03 18:04 ` Andrey Konovalov
2021-10-06 2:43 ` Nathan Chancellor
2021-10-06 11:57 ` Andrey Konovalov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+fCnZc5=fqM=eEZ3RLqBFaxR72bjxndDdnM_rOkiSBi3+2L6A@mail.gmail.com' \
--to=andreyknvl@gmail.com \
--cc=arnd@arndb.de \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.