From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DFACC11F69 for ; Thu, 1 Jul 2021 13:31:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD71261350 for ; Thu, 1 Jul 2021 13:31:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231940AbhGANeZ (ORCPT ); Thu, 1 Jul 2021 09:34:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbhGANeZ (ORCPT ); Thu, 1 Jul 2021 09:34:25 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97A72C061762 for ; Thu, 1 Jul 2021 06:31:54 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id bg14so10396682ejb.9 for ; Thu, 01 Jul 2021 06:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F9xHPQXfeX85p/WzrKNX5asqql2B/nD64WETM/hhNus=; b=rPkrb7S1fk4T3qkJ10Ep2j4MR6kgQaC6BsJseApFIwDMzhwuu3VfF4W+PMn+D6OOsj leSkEpTvERGV5xLo8VbBUsUr6mDM5rt1doaDh50MTc0uzsUlN3zRbh2OYSSAHBJiN6li bdQWhTsymoM6+mvoXx3OTtT4O61r1hWcjpzftezV2yOqO0RfmEfAX5YUEsKJs5htq92G PAQJrU/eJlCnP6y154lnlyQfgEYTmc87dxS+SyvZO3Cl9jM1WBBTv2ljPQLxX5FHDlcc pCiiqVPZIQkb+xQuzE49/flY/F7wWvZhXhUebyqm5a0zD+rEBDd72pM6O3vUDjN392Wt D2fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F9xHPQXfeX85p/WzrKNX5asqql2B/nD64WETM/hhNus=; b=UE9UKUtWFPOmS006DknTH6+zxgZK3dls0yLxQT1/6cNThic4I/VwEYOV75N1OGq22v tk/almGqRU59WIOPT2kHbi1eXbERvyhfUsczkOJeU9r18CEhgtpi5Ex9rB9dWS5XNktb XR3g2Eg0T/uD8tIJKvjG9XURuEjCAKxKGp6MRh+crQ1E8etUgDwVqT4rFbbdrS8g/uws 8G9xjt949B8KsV3HTgeSsgoxiawUbz6HnsjY1ojQ/lvzAm9pC32oxFXlyodHDAPgue5Q XnSotUzqeInAlw9anw4lvfxGOeRhinwApPkp2IBTV1wj6iR02zFlHjAZQiM1HoltJ9vW 8i2g== X-Gm-Message-State: AOAM533nSsdBSBYgftNVahUlYDIzKpczmiZeY6j+EFvK6bgUsKS1LYDK tuBuyhc/ComIMmoWv1Fn2oxjR35fwxDVg4/IV1U= X-Google-Smtp-Source: ABdhPJwAB9zNDvwIwLlvuGpl2XmkQHgjogSwTqCGj4FJ6uy6ez3lXb60hBmJa9obZ737ErpszWY/M6A6HyDbpv+9BfA= X-Received: by 2002:a17:907:9f0:: with SMTP id ce16mr42484016ejc.126.1625146312962; Thu, 01 Jul 2021 06:31:52 -0700 (PDT) MIME-Version: 1.0 References: <20210630134943.20781-1-yee.lee@mediatek.com> <20210630134943.20781-2-yee.lee@mediatek.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 1 Jul 2021 16:31:42 +0300 Message-ID: Subject: Re: [PATCH v3 1/1] kasan: Add memzero init for unaligned size under SLUB debug To: Marco Elver , yee.lee@mediatek.com Cc: wsd_upstream@mediatek.com, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrew Morton , Matthias Brugger , "open list:KASAN" , "open list:MEMORY MANAGEMENT" , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 30, 2021 at 10:13 PM Marco Elver wrote: > > > + if (IS_ENABLED(CONFIG_SLUB_DEBUG) && init && ((unsigned long)size & KASAN_GRANULE_MASK)) { > > + init = false; > > + memzero_explicit((void *)addr, size); > > + } > > size = round_up(size, KASAN_GRANULE_SIZE); > > > > hw_set_mem_tag_range((void *)addr, size, tag, init); > > I think this solution might be fine for now, as I don't see an easy way > to do this without some major refactor to use kmem_cache_debug_flags(). > > However, I think there's an intermediate solution where we only check > the static-key 'slub_debug_enabled' though. Because I've checked, and > various major distros _do_ enabled CONFIG_SLUB_DEBUG. But the static > branch just makes sure there's no performance overhead. > > Checking the static branch requires including mm/slab.h into > mm/kasan/kasan.h, which we currently don't do and perhaps wanted to > avoid. Although I don't see a reason there, because there's no circular > dependency even if we did. Most likely this won't be a problem. We already include ../slab.h into many mm/kasan/*.c files. > Andrey, any opinion? I like this approach. Easy to implement and is better than checking only CONFIG_SLUB_DEBUG. Thanks, Marco! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4512AC11F64 for ; Thu, 1 Jul 2021 13:31:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D485A61350 for ; Thu, 1 Jul 2021 13:31:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D485A61350 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 40A558D02A4; Thu, 1 Jul 2021 09:31:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BAA08D0001; Thu, 1 Jul 2021 09:31:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25B898D02A4; Thu, 1 Jul 2021 09:31:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id F152D8D0001 for ; Thu, 1 Jul 2021 09:31:54 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A3A74253C3 for ; Thu, 1 Jul 2021 13:31:54 +0000 (UTC) X-FDA: 78314106948.27.1DB5C44 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf17.hostedemail.com (Postfix) with ESMTP id 6919AF000136 for ; Thu, 1 Jul 2021 13:31:54 +0000 (UTC) Received: by mail-ej1-f50.google.com with SMTP id hc16so10377671ejc.12 for ; Thu, 01 Jul 2021 06:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F9xHPQXfeX85p/WzrKNX5asqql2B/nD64WETM/hhNus=; b=rPkrb7S1fk4T3qkJ10Ep2j4MR6kgQaC6BsJseApFIwDMzhwuu3VfF4W+PMn+D6OOsj leSkEpTvERGV5xLo8VbBUsUr6mDM5rt1doaDh50MTc0uzsUlN3zRbh2OYSSAHBJiN6li bdQWhTsymoM6+mvoXx3OTtT4O61r1hWcjpzftezV2yOqO0RfmEfAX5YUEsKJs5htq92G PAQJrU/eJlCnP6y154lnlyQfgEYTmc87dxS+SyvZO3Cl9jM1WBBTv2ljPQLxX5FHDlcc pCiiqVPZIQkb+xQuzE49/flY/F7wWvZhXhUebyqm5a0zD+rEBDd72pM6O3vUDjN392Wt D2fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F9xHPQXfeX85p/WzrKNX5asqql2B/nD64WETM/hhNus=; b=XWBZWqjx4aT52Y1JC8CV6JNJNY9C9cPpghgY4ZyT8o9TOqy08C7flDZekYYIeC6pfE BAHDUu7xSh4/76Qb4qiir/HTVsb/iCOr81qFolpuRNyK3DtEw7ha237WkpDPWf0rQ1du OBEwpt9DwzmMWvLcs8aI8aPbC1MtE1R8vyVFJ56rOaEsOsmoIDgWvSmy/lf7fs9z8Ot9 PG6uwctPHyfONUsU+GneqWN2eXal0kb9i1aPrVnx8hOOjor+B8l/AKG+ezBH60foSTDk FYl6XI3+u2fl0GDmzZfotEltjnwIThCRsPoDliRsxIknlC86LvT/g4IcCFyI1+xP2pqb O37g== X-Gm-Message-State: AOAM533kUkVW53szzxT4dGhzcj/bS0r/tCFDdJz56Ljc0LSMqpIDK1yp z4X8WOPH5VgAH9QjAJ7ETLTOKUWzoXXLKvEmYTA= X-Google-Smtp-Source: ABdhPJwAB9zNDvwIwLlvuGpl2XmkQHgjogSwTqCGj4FJ6uy6ez3lXb60hBmJa9obZ737ErpszWY/M6A6HyDbpv+9BfA= X-Received: by 2002:a17:907:9f0:: with SMTP id ce16mr42484016ejc.126.1625146312962; Thu, 01 Jul 2021 06:31:52 -0700 (PDT) MIME-Version: 1.0 References: <20210630134943.20781-1-yee.lee@mediatek.com> <20210630134943.20781-2-yee.lee@mediatek.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 1 Jul 2021 16:31:42 +0300 Message-ID: Subject: Re: [PATCH v3 1/1] kasan: Add memzero init for unaligned size under SLUB debug To: Marco Elver , yee.lee@mediatek.com Cc: wsd_upstream@mediatek.com, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrew Morton , Matthias Brugger , "open list:KASAN" , "open list:MEMORY MANAGEMENT" , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=rPkrb7S1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Rspamd-Server: rspam02 X-Stat-Signature: w7gosanoguqkxykf4ut3wjdzdzae3u4n X-Rspamd-Queue-Id: 6919AF000136 X-HE-Tag: 1625146314-649990 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 30, 2021 at 10:13 PM Marco Elver wrote: > > > + if (IS_ENABLED(CONFIG_SLUB_DEBUG) && init && ((unsigned long)size & KASAN_GRANULE_MASK)) { > > + init = false; > > + memzero_explicit((void *)addr, size); > > + } > > size = round_up(size, KASAN_GRANULE_SIZE); > > > > hw_set_mem_tag_range((void *)addr, size, tag, init); > > I think this solution might be fine for now, as I don't see an easy way > to do this without some major refactor to use kmem_cache_debug_flags(). > > However, I think there's an intermediate solution where we only check > the static-key 'slub_debug_enabled' though. Because I've checked, and > various major distros _do_ enabled CONFIG_SLUB_DEBUG. But the static > branch just makes sure there's no performance overhead. > > Checking the static branch requires including mm/slab.h into > mm/kasan/kasan.h, which we currently don't do and perhaps wanted to > avoid. Although I don't see a reason there, because there's no circular > dependency even if we did. Most likely this won't be a problem. We already include ../slab.h into many mm/kasan/*.c files. > Andrey, any opinion? I like this approach. Easy to implement and is better than checking only CONFIG_SLUB_DEBUG. Thanks, Marco! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC66C11F64 for ; Thu, 1 Jul 2021 13:32:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A3B961416 for ; Thu, 1 Jul 2021 13:32:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A3B961416 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bekzzZK9ABA7rvSuzjxCH9hrwSwHb7gZ8dXEcUX9FHg=; b=x2WBxNYx1Ku0m9 oO9QJo8DIR3mvN+NCuI4XEVBorUfV1suoJ9qB5rtvbECiy3qocyo+CGfOq9NY/lQNcfYXBvtFHoBh XFVl7YIW4FUB/mXvR0M55q0w2J/G2YaIiE0tbG20Qml/TbMEIv+cQqF3vIe427GWtt3JmwmR2B8zT o/qM+Ke4WgcPyTJ4bKb2oaKR0TlU+vlUrzflie125hbyLadoYgHThjTrs8Di904UxS9Uh8+X2ATC+ Wz6Je2MrBbQ89pNo4COXTyl2IsNdXkQhNid9+phDRft2IcTomV3NHG54sthrHzNNI2s6w1j9bpwYN /IRcNgOVgE616kribRLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lywnY-00HTUs-U7; Thu, 01 Jul 2021 13:32:08 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lywnL-00HTS2-O9; Thu, 01 Jul 2021 13:31:57 +0000 Received: by mail-ej1-x631.google.com with SMTP id gt10so9034599ejc.5; Thu, 01 Jul 2021 06:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F9xHPQXfeX85p/WzrKNX5asqql2B/nD64WETM/hhNus=; b=rPkrb7S1fk4T3qkJ10Ep2j4MR6kgQaC6BsJseApFIwDMzhwuu3VfF4W+PMn+D6OOsj leSkEpTvERGV5xLo8VbBUsUr6mDM5rt1doaDh50MTc0uzsUlN3zRbh2OYSSAHBJiN6li bdQWhTsymoM6+mvoXx3OTtT4O61r1hWcjpzftezV2yOqO0RfmEfAX5YUEsKJs5htq92G PAQJrU/eJlCnP6y154lnlyQfgEYTmc87dxS+SyvZO3Cl9jM1WBBTv2ljPQLxX5FHDlcc pCiiqVPZIQkb+xQuzE49/flY/F7wWvZhXhUebyqm5a0zD+rEBDd72pM6O3vUDjN392Wt D2fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F9xHPQXfeX85p/WzrKNX5asqql2B/nD64WETM/hhNus=; b=CvPL+4G8B9J2qP1/l7Nnom/E+lrRU3QFqoCH6L83CwrUcYoj0ib1eG7B5FOVP6Z9Y8 DTgnyCr9H5yJiY6/m6iwBQLQfwqcuTrtaXBQrJ564BihsNw2GSbg4iH22a4Ce+laU0C0 D5eX1212sHpXktKsiT5+B3H7XnBUhnARwVspWR0Yi5OXwieKFVMOKUYt+ckVQ9nWHYS0 RiD+dt1ph5EPP+UgCCtlgZSI8INLBuvAPprERW1ULWoNcR8Jyd/wDQLU6PzpvvqxAWxI ZEuaXxbDCxv2RMjjxg++pASs5XEDlhlYXt2CwWvVttuCt0ZhKD63uxw5LgNwZdReW0fR 3gpQ== X-Gm-Message-State: AOAM532PZzYC0pGO1YR62MNqIPibA9J8ICjfJtA20fEjRO8SkbQmlwWI j5YuaCT0tZBStFyQ9LsEpPB9tlsWO9RzT3KL2cc= X-Google-Smtp-Source: ABdhPJwAB9zNDvwIwLlvuGpl2XmkQHgjogSwTqCGj4FJ6uy6ez3lXb60hBmJa9obZ737ErpszWY/M6A6HyDbpv+9BfA= X-Received: by 2002:a17:907:9f0:: with SMTP id ce16mr42484016ejc.126.1625146312962; Thu, 01 Jul 2021 06:31:52 -0700 (PDT) MIME-Version: 1.0 References: <20210630134943.20781-1-yee.lee@mediatek.com> <20210630134943.20781-2-yee.lee@mediatek.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 1 Jul 2021 16:31:42 +0300 Message-ID: Subject: Re: [PATCH v3 1/1] kasan: Add memzero init for unaligned size under SLUB debug To: Marco Elver , yee.lee@mediatek.com Cc: wsd_upstream@mediatek.com, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrew Morton , Matthias Brugger , "open list:KASAN" , "open list:MEMORY MANAGEMENT" , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210701_063155_847019_B2A68328 X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Jun 30, 2021 at 10:13 PM Marco Elver wrote: > > > + if (IS_ENABLED(CONFIG_SLUB_DEBUG) && init && ((unsigned long)size & KASAN_GRANULE_MASK)) { > > + init = false; > > + memzero_explicit((void *)addr, size); > > + } > > size = round_up(size, KASAN_GRANULE_SIZE); > > > > hw_set_mem_tag_range((void *)addr, size, tag, init); > > I think this solution might be fine for now, as I don't see an easy way > to do this without some major refactor to use kmem_cache_debug_flags(). > > However, I think there's an intermediate solution where we only check > the static-key 'slub_debug_enabled' though. Because I've checked, and > various major distros _do_ enabled CONFIG_SLUB_DEBUG. But the static > branch just makes sure there's no performance overhead. > > Checking the static branch requires including mm/slab.h into > mm/kasan/kasan.h, which we currently don't do and perhaps wanted to > avoid. Although I don't see a reason there, because there's no circular > dependency even if we did. Most likely this won't be a problem. We already include ../slab.h into many mm/kasan/*.c files. > Andrey, any opinion? I like this approach. Easy to implement and is better than checking only CONFIG_SLUB_DEBUG. Thanks, Marco! _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 902EAC11F67 for ; Thu, 1 Jul 2021 13:33:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E8D461416 for ; Thu, 1 Jul 2021 13:33:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E8D461416 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Lm9fkmEpYHwjew1NAgD7C5ICAPVazlJw2g2yQJPlJ7g=; b=xXMGiYSbQ0tJ4i oulpenyrNpnB2DQrlk0jzC5+h5hIjnqodcXnBkma/i3oqm1kQAVVCb1jmFCPK/G9mEMG4F2DqPbOI dnohosZjOXXsIDrO0PthJUNCBbkWnCvVNMY2DoOlU2adi+K0nTxvwV7q3X7FLkweQCMc8v/L5n0tj phMeVv7mwkrYsAhLpJLuv9/c/byUl3Q7WQvJSXzi44w1/G22InSZk47AE1CvaEQaGwYP7siEwI+Sj a9BMaLXU1a5zf0+5Mjo83uzvoSDiXKU8D/FreEioEWx4Q5VqaBvziVJAYb+TJsxlhVItvkD89e6dA AoAdm4EFyACYxsnPuEyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lywnQ-00HTTl-0N; Thu, 01 Jul 2021 13:32:00 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lywnL-00HTS2-O9; Thu, 01 Jul 2021 13:31:57 +0000 Received: by mail-ej1-x631.google.com with SMTP id gt10so9034599ejc.5; Thu, 01 Jul 2021 06:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F9xHPQXfeX85p/WzrKNX5asqql2B/nD64WETM/hhNus=; b=rPkrb7S1fk4T3qkJ10Ep2j4MR6kgQaC6BsJseApFIwDMzhwuu3VfF4W+PMn+D6OOsj leSkEpTvERGV5xLo8VbBUsUr6mDM5rt1doaDh50MTc0uzsUlN3zRbh2OYSSAHBJiN6li bdQWhTsymoM6+mvoXx3OTtT4O61r1hWcjpzftezV2yOqO0RfmEfAX5YUEsKJs5htq92G PAQJrU/eJlCnP6y154lnlyQfgEYTmc87dxS+SyvZO3Cl9jM1WBBTv2ljPQLxX5FHDlcc pCiiqVPZIQkb+xQuzE49/flY/F7wWvZhXhUebyqm5a0zD+rEBDd72pM6O3vUDjN392Wt D2fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F9xHPQXfeX85p/WzrKNX5asqql2B/nD64WETM/hhNus=; b=CvPL+4G8B9J2qP1/l7Nnom/E+lrRU3QFqoCH6L83CwrUcYoj0ib1eG7B5FOVP6Z9Y8 DTgnyCr9H5yJiY6/m6iwBQLQfwqcuTrtaXBQrJ564BihsNw2GSbg4iH22a4Ce+laU0C0 D5eX1212sHpXktKsiT5+B3H7XnBUhnARwVspWR0Yi5OXwieKFVMOKUYt+ckVQ9nWHYS0 RiD+dt1ph5EPP+UgCCtlgZSI8INLBuvAPprERW1ULWoNcR8Jyd/wDQLU6PzpvvqxAWxI ZEuaXxbDCxv2RMjjxg++pASs5XEDlhlYXt2CwWvVttuCt0ZhKD63uxw5LgNwZdReW0fR 3gpQ== X-Gm-Message-State: AOAM532PZzYC0pGO1YR62MNqIPibA9J8ICjfJtA20fEjRO8SkbQmlwWI j5YuaCT0tZBStFyQ9LsEpPB9tlsWO9RzT3KL2cc= X-Google-Smtp-Source: ABdhPJwAB9zNDvwIwLlvuGpl2XmkQHgjogSwTqCGj4FJ6uy6ez3lXb60hBmJa9obZ737ErpszWY/M6A6HyDbpv+9BfA= X-Received: by 2002:a17:907:9f0:: with SMTP id ce16mr42484016ejc.126.1625146312962; Thu, 01 Jul 2021 06:31:52 -0700 (PDT) MIME-Version: 1.0 References: <20210630134943.20781-1-yee.lee@mediatek.com> <20210630134943.20781-2-yee.lee@mediatek.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 1 Jul 2021 16:31:42 +0300 Message-ID: Subject: Re: [PATCH v3 1/1] kasan: Add memzero init for unaligned size under SLUB debug To: Marco Elver , yee.lee@mediatek.com Cc: wsd_upstream@mediatek.com, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrew Morton , Matthias Brugger , "open list:KASAN" , "open list:MEMORY MANAGEMENT" , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210701_063155_847019_B2A68328 X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 30, 2021 at 10:13 PM Marco Elver wrote: > > > + if (IS_ENABLED(CONFIG_SLUB_DEBUG) && init && ((unsigned long)size & KASAN_GRANULE_MASK)) { > > + init = false; > > + memzero_explicit((void *)addr, size); > > + } > > size = round_up(size, KASAN_GRANULE_SIZE); > > > > hw_set_mem_tag_range((void *)addr, size, tag, init); > > I think this solution might be fine for now, as I don't see an easy way > to do this without some major refactor to use kmem_cache_debug_flags(). > > However, I think there's an intermediate solution where we only check > the static-key 'slub_debug_enabled' though. Because I've checked, and > various major distros _do_ enabled CONFIG_SLUB_DEBUG. But the static > branch just makes sure there's no performance overhead. > > Checking the static branch requires including mm/slab.h into > mm/kasan/kasan.h, which we currently don't do and perhaps wanted to > avoid. Although I don't see a reason there, because there's no circular > dependency even if we did. Most likely this won't be a problem. We already include ../slab.h into many mm/kasan/*.c files. > Andrey, any opinion? I like this approach. Easy to implement and is better than checking only CONFIG_SLUB_DEBUG. Thanks, Marco! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel