From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01DA3C433EF for ; Mon, 13 Dec 2021 21:57:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243440AbhLMV53 (ORCPT ); Mon, 13 Dec 2021 16:57:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243436AbhLMV52 (ORCPT ); Mon, 13 Dec 2021 16:57:28 -0500 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 272B2C061574 for ; Mon, 13 Dec 2021 13:57:28 -0800 (PST) Received: by mail-io1-xd2d.google.com with SMTP id p23so20633967iod.7 for ; Mon, 13 Dec 2021 13:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mm2UWj2YnKjrM1uYfSOmZBTk8qAIxqBQ9/EkHyLqgsc=; b=WGDhTKgs1M19F5RLh/ghQTTXHLMg4GO+Va/ZCOqp75D4BcTBFmvAyFOp3iR+playrk +T9Jlonuihe3sFoIQtfLQBUohu8R6MPWXzNZhaNBqBECrUwV/Na2RkobDZ+yJfyXhZxj Zc1w7LmN3RES+diPh9vZmRrhO4M3O2RsLHNQMUlyr7GwrhegxFvYFO0D6HFmPm55kYk+ wqrpQ6kQbGTmo893E80CH350LCb6CSWf6u+8JN/zg81wfGaanF15fb4ydtKlCBifJ2nN 8Ump1PCSItp2r2u16Yqh96q6OGH6wrsF5rdnkfLm4GyeC89cjLQuxKAgQABGwCqzZCgh Eu3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mm2UWj2YnKjrM1uYfSOmZBTk8qAIxqBQ9/EkHyLqgsc=; b=0JXB283t4M+ty8hpy4dYi96schI1MwsHr+Bp3z0NgWGuKMJCYIKAvqwRxX612z3IjY rKCKb1CMEZqgOYte19GccTEMT8Ma1DmJR2P4m0YeVg3qWTn8IhDY+CSwV5p3R4wZbe0P tjbcO1jrHjOZ9b+RONl6Bu7dB1RDnnxm+s0rtLmNpBIL4zp5bo4rnIGQTWRXqqP0JjcL 1E4CtQkk5T77jt3hT12ScWTVmLr6BgsY/uXSkqiQV2BN5wL10Ixwp+fSlJtCKfUKbQbO Zv1C7kyn7/oMBUfFQzhGQlsb15JJF1i+b7Lc/BpmL3lRF/YvfdbTk2SZXrRSIw8Cy8rI OMNA== X-Gm-Message-State: AOAM530obdu+r+1/IkaFVq8i9WnSdRkFkL+vOpgpb1JzIbdwt6VEOYiJ Y1RgvkDGrBwXx3gtJmN5MAc4QANvpr+jTMwBs0k= X-Google-Smtp-Source: ABdhPJwxpZXrkYa1rZLbVNyZvefzi4hFv2hWb7lsOaLvHUX8W4V9XsbfXmUsLiMSfTJBF8neKVDX8kzVqC7kL2jCyRg= X-Received: by 2002:a02:830e:: with SMTP id v14mr555545jag.644.1639432647604; Mon, 13 Dec 2021 13:57:27 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Mon, 13 Dec 2021 22:57:17 +0100 Message-ID: Subject: Re: [PATCH v2 24/34] kasan, vmalloc, arm64: mark vmalloc mappings as pgprot_tagged To: Vincenzo Frascino Cc: andrey.konovalov@linux.dev, Marco Elver , Alexander Potapenko , Catalin Marinas , Peter Collingbourne , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Andrew Morton , Linux Memory Management List , Will Deacon , Mark Rutland , Linux ARM , Evgenii Stepanov , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 13, 2021 at 4:17 PM Vincenzo Frascino wrote: > > Hi Andrey, > > On 12/6/21 9:44 PM, andrey.konovalov@linux.dev wrote: > > From: Andrey Konovalov > > > > HW_TAGS KASAN relies on ARM Memory Tagging Extension (MTE). With MTE, > > a memory region must be mapped as MT_NORMAL_TAGGED to allow setting > > memory tags via MTE-specific instructions. > > > > This change adds proper protection bits to vmalloc() allocations. > > Please avoid "this patch/this change" in patch description and use imperative > mode as if you are giving a command to the code base ([1] paragraph 2). Hi Vincenzo, Done in v3. > > These allocations are always backed by page_alloc pages, so the tags > > will actually be getting set on the corresponding physical memory. > > > > Signed-off-by: Andrey Konovalov > > Co-developed-by: Vincenzo Frascino > > With the change to the commit message: > > Signed-off-by: Vincenzo Frascino Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCCD5C433EF for ; Mon, 13 Dec 2021 22:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V5f6jicTtvXzdw3vn2MllqnhnTtBH6DQSLJlFpaxP0c=; b=1o3LU0pPz+T+I1 YAiZfRxrvKTUNB2sm7PiZYZwLxVt+FEcNmVqcDbhIhX90TsI5mGadOyH8/geI3Gldsx3nLNSL01L0 +CT4LPO/dyUENOGZmmluNWiNzwpHex7QTd2Xxvh76bSf8QzLYW7wNBi7ce38uUSFDdUUuOvx/5wz1 rf1tma553Nqym56GDI3deAk7paLaAl3OspkH3NUWxSvScKRmb7qcjaZ9DosbOLFn5jbU0DbmeAICV pAd0IpDRNKPuz9vJxx8xppVN8ObM0G0B3MBqrHp0PokoMrbsjM75o/LRy00kKrc++bxvYm8DI8Ip2 ZzvECYKqcGqN8iO/WFtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwto4-00Bjqf-57; Mon, 13 Dec 2021 22:28:28 +0000 Received: from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwtK4-00BXnZ-Oe for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 21:57:30 +0000 Received: by mail-io1-xd36.google.com with SMTP id b187so20595828iof.11 for ; Mon, 13 Dec 2021 13:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mm2UWj2YnKjrM1uYfSOmZBTk8qAIxqBQ9/EkHyLqgsc=; b=WGDhTKgs1M19F5RLh/ghQTTXHLMg4GO+Va/ZCOqp75D4BcTBFmvAyFOp3iR+playrk +T9Jlonuihe3sFoIQtfLQBUohu8R6MPWXzNZhaNBqBECrUwV/Na2RkobDZ+yJfyXhZxj Zc1w7LmN3RES+diPh9vZmRrhO4M3O2RsLHNQMUlyr7GwrhegxFvYFO0D6HFmPm55kYk+ wqrpQ6kQbGTmo893E80CH350LCb6CSWf6u+8JN/zg81wfGaanF15fb4ydtKlCBifJ2nN 8Ump1PCSItp2r2u16Yqh96q6OGH6wrsF5rdnkfLm4GyeC89cjLQuxKAgQABGwCqzZCgh Eu3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mm2UWj2YnKjrM1uYfSOmZBTk8qAIxqBQ9/EkHyLqgsc=; b=XYYmFB3gx0BK9v/Qi0SKchS8olIxBsaid6LIVnrsWW+Rv8ypP3fStJmRzg/AsiZDDw anO3oeaXHnmGbHtgIj7jMv5zFfzaHgnZbxtvzre2tNkI8ELB4YT79TEyO0dQ6kUFxhhr nucFEPcazPOflAME7UFCaDkr5zgz6OxXyKQsPCtF9jY/BPRa5Z9xbTciNNRXZ6oV1NC/ pWpKZN99m/PGradh5DifuGe0LOuae5PP4mKD2WEKc871hNQF9MthYTdSc4UKUOqEUX/y qM1J6MFu3lx1Wx7imvQ8Nz5tLg2AGVEbe3apy2ETIuOOKUE3uC+7qmIAia2aml0aHK9U fqCA== X-Gm-Message-State: AOAM530i1Q3t4wGzJa6WuzsLFXhdIZLJglzy9jdUJy5qLnSpT4vw7kqB 8ZUelKSoXA8N0uHgVKDUYwDXwIpyJadSViSQweY= X-Google-Smtp-Source: ABdhPJwxpZXrkYa1rZLbVNyZvefzi4hFv2hWb7lsOaLvHUX8W4V9XsbfXmUsLiMSfTJBF8neKVDX8kzVqC7kL2jCyRg= X-Received: by 2002:a02:830e:: with SMTP id v14mr555545jag.644.1639432647604; Mon, 13 Dec 2021 13:57:27 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Mon, 13 Dec 2021 22:57:17 +0100 Message-ID: Subject: Re: [PATCH v2 24/34] kasan, vmalloc, arm64: mark vmalloc mappings as pgprot_tagged To: Vincenzo Frascino Cc: andrey.konovalov@linux.dev, Marco Elver , Alexander Potapenko , Catalin Marinas , Peter Collingbourne , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Andrew Morton , Linux Memory Management List , Will Deacon , Mark Rutland , Linux ARM , Evgenii Stepanov , LKML , Andrey Konovalov X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_135728_845687_73CF167A X-CRM114-Status: GOOD ( 14.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 13, 2021 at 4:17 PM Vincenzo Frascino wrote: > > Hi Andrey, > > On 12/6/21 9:44 PM, andrey.konovalov@linux.dev wrote: > > From: Andrey Konovalov > > > > HW_TAGS KASAN relies on ARM Memory Tagging Extension (MTE). With MTE, > > a memory region must be mapped as MT_NORMAL_TAGGED to allow setting > > memory tags via MTE-specific instructions. > > > > This change adds proper protection bits to vmalloc() allocations. > > Please avoid "this patch/this change" in patch description and use imperative > mode as if you are giving a command to the code base ([1] paragraph 2). Hi Vincenzo, Done in v3. > > These allocations are always backed by page_alloc pages, so the tags > > will actually be getting set on the corresponding physical memory. > > > > Signed-off-by: Andrey Konovalov > > Co-developed-by: Vincenzo Frascino > > With the change to the commit message: > > Signed-off-by: Vincenzo Frascino Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel