From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38B2AC433DB for ; Mon, 29 Mar 2021 22:01:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 093FC6192B for ; Mon, 29 Mar 2021 22:01:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230364AbhC2WBQ (ORCPT ); Mon, 29 Mar 2021 18:01:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230143AbhC2WBD (ORCPT ); Mon, 29 Mar 2021 18:01:03 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9205FC061574 for ; Mon, 29 Mar 2021 15:01:02 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id ce10so21761913ejb.6 for ; Mon, 29 Mar 2021 15:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=toyezCdg30sSEAZOhMLaVFjK3eNVHWrmf65IUPFvlVE=; b=PmU+1KxhWZdi5Fh5U0BVrNpMExCpP2F6av5vylIDKY9DDZowaatfzMK5XEcMfBAkwd TVcGAtJxZWjlbjZr2N570h0X3x7QeBBHTSPRA19X+ZmN6GoMEfTA7v4ioSk+BA2HzeXk 067z6FsLDCAIrpZGneNLhgh8O4YuagUcJxkbtJXDXq+KnTd5ZsV6S3GAjdJY089UN7Md Y3qXf21ahWHD1P222a39xOjgGMMukYLeEWkOi/cziKk/iacGk1UujZpYgxPSv0rE3YJr 2fpclub80IhrhxKAyeHInreaJ7q0xNy8JsnK2bwR0Q6lF6NBVqNk6AfGXuC6A3kzPR5J he2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=toyezCdg30sSEAZOhMLaVFjK3eNVHWrmf65IUPFvlVE=; b=oLltq86f5LgUstga26gDZho3V8V/ONgU0RKKicxXP/SUEyU5SiecT1FxM+PovRW6gZ U4eMEQF6r50LPs47Ioc4LR0YH5A5pPvGt5itZTVLGzXWz4U9m9HmmXLFzyJvGnEESM7/ 75S2yT8weG0S0YTwqGfjkT0ACk26FszpotFg+Xfzvv7BDwXM900w5F9CWc9KHXDjoRop aug6RGocv4adCxW9WFjbe3feXP9o1tPvtMxkKEG3z+wU2pZ6sn0H5wohOqLnd5aaYsqu CfLb8TCxDrfEOgEQsYn604L/QN6Mth+p4mBV4iUhKtJckqhxGRaEpaEuL+mGjnBnkNyR W9AQ== X-Gm-Message-State: AOAM5321ALpml3vkS15d82gi0VJQQOEmdugpi2v0+gIyK5h+cuE18q42 6oxsJ95vV+harAmCKeBrCdRvkr76Ge9AIE9opwc= X-Google-Smtp-Source: ABdhPJznKG/K7Yf6ifOnHyn6fguEd/iMMzBMUyX/HtjM5aOMcAI5GdJKjCNgR1aAVJ54oSzrGJRsGyHE9sA8D48q+gU= X-Received: by 2002:a17:906:4e17:: with SMTP id z23mr30582963eju.439.1617055260095; Mon, 29 Mar 2021 15:01:00 -0700 (PDT) MIME-Version: 1.0 References: <20210326112650.307890-1-slyfox@gentoo.org> <4e23d404-5125-6c9c-4aa7-5eff0fa1ba33@redhat.com> <469d6417-64a5-fe99-1214-bb0351833b74@suse.cz> In-Reply-To: <469d6417-64a5-fe99-1214-bb0351833b74@suse.cz> From: Andrey Konovalov Date: Tue, 30 Mar 2021 00:00:49 +0200 Message-ID: Subject: Re: [PATCH] mm: page_alloc: ignore init_on_free=1 for page alloc To: Vlastimil Babka Cc: David Hildenbrand , Sergei Trofimovich , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 29, 2021 at 2:10 PM Vlastimil Babka wrote: > > > commit 855a9c4018f3219db8be7e4b9a65ab22aebfde82 > > Author: Andrey Konovalov > > Date: Thu Mar 18 17:01:40 2021 +1100 > > > > kasan, mm: integrate page_alloc init with HW_TAGS > > But the mmotm patch/-next commit also changes post_alloc_hook() > > Before the patch it was: > kernel_unpoison_pages(page, 1 << order); > ... > kernel_init_free_pages(page, 1 << order); > > Now it is (for !kasan_has_integrated_init()): > > kernel_init_free_pages(page, 1 << order); > > kernel_unpoison_pages(page, 1 << order); > > That has to be wrong, because we init the page with zeroes and then call > kernel_unpoison_pages() which checks for the 0xaa pattern. Andrey? It's similar to free_pages_prepare(): kernel_unpoison_pages() and want_init_on_alloc() are exclusive, so the order shouldn't matter. Am I missing something? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B31CAC433C1 for ; Mon, 29 Mar 2021 22:01:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 435806192B for ; Mon, 29 Mar 2021 22:01:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 435806192B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B3B3C6B007D; Mon, 29 Mar 2021 18:01:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC3EC6B007E; Mon, 29 Mar 2021 18:01:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93CF46B0080; Mon, 29 Mar 2021 18:01:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 7664B6B007D for ; Mon, 29 Mar 2021 18:01:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 29AA5180AD822 for ; Mon, 29 Mar 2021 22:01:02 +0000 (UTC) X-FDA: 77974282764.21.9B5C1A6 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf11.hostedemail.com (Postfix) with ESMTP id 3DF0F20007FB for ; Mon, 29 Mar 2021 22:00:56 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id hq27so21722159ejc.9 for ; Mon, 29 Mar 2021 15:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=toyezCdg30sSEAZOhMLaVFjK3eNVHWrmf65IUPFvlVE=; b=PmU+1KxhWZdi5Fh5U0BVrNpMExCpP2F6av5vylIDKY9DDZowaatfzMK5XEcMfBAkwd TVcGAtJxZWjlbjZr2N570h0X3x7QeBBHTSPRA19X+ZmN6GoMEfTA7v4ioSk+BA2HzeXk 067z6FsLDCAIrpZGneNLhgh8O4YuagUcJxkbtJXDXq+KnTd5ZsV6S3GAjdJY089UN7Md Y3qXf21ahWHD1P222a39xOjgGMMukYLeEWkOi/cziKk/iacGk1UujZpYgxPSv0rE3YJr 2fpclub80IhrhxKAyeHInreaJ7q0xNy8JsnK2bwR0Q6lF6NBVqNk6AfGXuC6A3kzPR5J he2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=toyezCdg30sSEAZOhMLaVFjK3eNVHWrmf65IUPFvlVE=; b=POJUcdm2pwk8hj2xxi5noyKFFXsJmDswuBrHEwxdfQMbOWfXGALga561cLDA2c+mXG P9/cGcRV/kO28jNefiAMm2xY1Ub0M+CE5LkaV5JhvqZmnjhujJGcwD0nFtIwBA8kVaUC jf9G6S1AoHqX9vpohWTXUziX1Ww85Hi5J+cY+0pj+61UeXE94Quvz7Zi+1r5FitfnFsH tDYQEJH1LWk70PgUBZHwtvVKOvZfZjEtjlVXBiogIacobhJrjYOuMpv3kxZy//bkualH nRa6fVvME0UlrWOiyKYL6qcG4gUP4+ix6lGBZTC4kqwVDjpHuzBdtH2m0k/uQwaDzy6j Y5ww== X-Gm-Message-State: AOAM532HkbDf4cdZhy7DujHjNjhQAuhmUoghIFXusul75j7Tmg6rPNjX zKlavGd3h2dCgkpTmqkm2plAH23+SIhoDy/NRu8= X-Google-Smtp-Source: ABdhPJznKG/K7Yf6ifOnHyn6fguEd/iMMzBMUyX/HtjM5aOMcAI5GdJKjCNgR1aAVJ54oSzrGJRsGyHE9sA8D48q+gU= X-Received: by 2002:a17:906:4e17:: with SMTP id z23mr30582963eju.439.1617055260095; Mon, 29 Mar 2021 15:01:00 -0700 (PDT) MIME-Version: 1.0 References: <20210326112650.307890-1-slyfox@gentoo.org> <4e23d404-5125-6c9c-4aa7-5eff0fa1ba33@redhat.com> <469d6417-64a5-fe99-1214-bb0351833b74@suse.cz> In-Reply-To: <469d6417-64a5-fe99-1214-bb0351833b74@suse.cz> From: Andrey Konovalov Date: Tue, 30 Mar 2021 00:00:49 +0200 Message-ID: Subject: Re: [PATCH] mm: page_alloc: ignore init_on_free=1 for page alloc To: Vlastimil Babka Cc: David Hildenbrand , Sergei Trofimovich , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3DF0F20007FB X-Stat-Signature: ga6c4w77bss9du85zu6dfo3upo8cij37 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=mail-ej1-f45.google.com; client-ip=209.85.218.45 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617055256-563071 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 29, 2021 at 2:10 PM Vlastimil Babka wrote: > > > commit 855a9c4018f3219db8be7e4b9a65ab22aebfde82 > > Author: Andrey Konovalov > > Date: Thu Mar 18 17:01:40 2021 +1100 > > > > kasan, mm: integrate page_alloc init with HW_TAGS > > But the mmotm patch/-next commit also changes post_alloc_hook() > > Before the patch it was: > kernel_unpoison_pages(page, 1 << order); > ... > kernel_init_free_pages(page, 1 << order); > > Now it is (for !kasan_has_integrated_init()): > > kernel_init_free_pages(page, 1 << order); > > kernel_unpoison_pages(page, 1 << order); > > That has to be wrong, because we init the page with zeroes and then call > kernel_unpoison_pages() which checks for the 0xaa pattern. Andrey? It's similar to free_pages_prepare(): kernel_unpoison_pages() and want_init_on_alloc() are exclusive, so the order shouldn't matter. Am I missing something?