From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2FE5C433F5 for ; Tue, 8 Mar 2022 15:31:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243576AbiCHPbz (ORCPT ); Tue, 8 Mar 2022 10:31:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231561AbiCHPbx (ORCPT ); Tue, 8 Mar 2022 10:31:53 -0500 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 967124E395 for ; Tue, 8 Mar 2022 07:30:57 -0800 (PST) Received: by mail-il1-x130.google.com with SMTP id b5so11602526ilj.9 for ; Tue, 08 Mar 2022 07:30:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QL+ZtmXXGFLuTx2y9WXZomB2eATV+ikv3E06Gw8vFq0=; b=I68j85a6/qjvW0V3IavZmXBtBc8pD6pwX7yGYgP70N3qfY/KekXPn14gqHuXHQi3iz 45y3wjsfeAJoSBGDTb3kxwyUuzILLoXo2eFo4z3nCSjYHUU1aBHr+B04M3kP/DctZcqU FaE5+rdNtdNZSVsKxPIjL2TKvhOwT8EAqwk6x0LlVDTkAwSZt0rUy3ePzZmsgeFzrtgj IcJ9yy+JXS0yPZEfdAsbdDcR8t9w2+5GyzVroPUq4B5oDrMBfwsfDFPB6QqHpu/tXFOv cMBPSu+cM5zifvwDyOWdetr6U++L+xykJjh1Zou3iBXvPcrzyzw1BY2lrHkSovZ8zh++ GxXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QL+ZtmXXGFLuTx2y9WXZomB2eATV+ikv3E06Gw8vFq0=; b=GB85ffSYopOdsVyjfYoYgfz8yEhqJ1Mupj4vjsMH15nE+TeiY4G/EEZHQ3OIDYhOyg zDiycAp8lfCBuGFDqyQZJDEEa11VkntdhUvPqNIacgKmVIBFmJnIkrbA0U2bk5a2i+Fh utAZK8hGlGV10k2TJUQ10+UzKyDLA+lGEpcPzkugLVs691OnXAnq0p4ra4/z5vSolOSG ZPCdHtvhIx6XhJLWw/dnafLZUsNqcR6CBfSMHImCBKF7y8fAFNgjRlWV7oj3Gdllu+dG YcFvyVqd8NEMrQzPxlod5OC8n/BSQmq8JxmamhWwDLg/tbODHpM0CIQ1tpu8Hirs0d9E jEnA== X-Gm-Message-State: AOAM532yTnwoCC9bNMLzXfSEzmdj4zTQD0s0VrGCsHNS8QZomim39wMO Sn6+ykrlZbEenHiy8ULY6w9m9nfd7PX0Z2QXgkc= X-Google-Smtp-Source: ABdhPJyPwmIL/pO50iF8syyeci1IJTewvmDOYzdRSzAtoKHRP6OQjBCrXGlvhWl93W16Be715WB6xOEjeRlrzUnkWU8= X-Received: by 2002:a05:6e02:20c3:b0:2c2:9e23:8263 with SMTP id 3-20020a056e0220c300b002c29e238263mr16510481ilq.248.1646753456934; Tue, 08 Mar 2022 07:30:56 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Tue, 8 Mar 2022 16:30:46 +0100 Message-ID: Subject: Re: [PATCH v6 31/39] kasan, vmalloc: only tag normal vmalloc allocations To: Vasily Gorbik Cc: andrey.konovalov@linux.dev, Andrew Morton , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Linux Memory Management List , Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , Linux ARM , Peter Collingbourne , Evgenii Stepanov , LKML , Andrey Konovalov , Ilya Leoshkevich Content-Type: multipart/mixed; boundary="000000000000d579e505d9b6aa3d" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --000000000000d579e505d9b6aa3d Content-Type: text/plain; charset="UTF-8" On Tue, Mar 8, 2022 at 4:17 PM Vasily Gorbik wrote: > > On Mon, Jan 24, 2022 at 07:05:05PM +0100, andrey.konovalov@linux.dev wrote: > > From: Andrey Konovalov > > > > The kernel can use to allocate executable memory. The only supported way > > to do that is via __vmalloc_node_range() with the executable bit set in > > the prot argument. (vmap() resets the bit via pgprot_nx()). > > > > Once tag-based KASAN modes start tagging vmalloc allocations, executing > > code from such allocations will lead to the PC register getting a tag, > > which is not tolerated by the kernel. > > > > Only tag the allocations for normal kernel pages. > > > > Signed-off-by: Andrey Konovalov > > This breaks s390 and produce huge amount of false positives. > I haven't been testing linux-next with KASAN for while, now tried it with > next-20220308 and bisected false positives to this commit. > > Any idea what is going wrong here? Hi Vasily, Could you try the attached fix? Thanks! --000000000000d579e505d9b6aa3d Content-Type: application/octet-stream; name="s390-kasan-vmalloc.fix" Content-Disposition: attachment; filename="s390-kasan-vmalloc.fix" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l0iafuk20 ZGlmZiAtLWdpdCBhL21tL2thc2FuL3NoYWRvdy5jIGIvbW0va2FzYW4vc2hhZG93LmMKaW5kZXgg NzI3MmUyNDhkYjg3Li42OTM5NTRmNzcxZWMgMTAwNjQ0Ci0tLSBhL21tL2thc2FuL3NoYWRvdy5j CisrKyBiL21tL2thc2FuL3NoYWRvdy5jCkBAIC00OTIsNyArNDkyLDggQEAgdm9pZCAqX19rYXNh bl91bnBvaXNvbl92bWFsbG9jKGNvbnN0IHZvaWQgKnN0YXJ0LCB1bnNpZ25lZCBsb25nIHNpemUs CiAJICogRG9uJ3QgdGFnIGV4ZWN1dGFibGUgbWVtb3J5LgogCSAqIFRoZSBrZXJuZWwgZG9lc24n dCB0b2xlcmF0ZSBoYXZpbmcgdGhlIFBDIHJlZ2lzdGVyIHRhZ2dlZC4KIAkgKi8KLQlpZiAoIShm bGFncyAmIEtBU0FOX1ZNQUxMT0NfUFJPVF9OT1JNQUwpKQorCWlmIChJU19FTkFCTEVEKENPTkZJ R19LQVNBTl9TV19UQUdTKSAmJgorCSAgICAhKGZsYWdzICYgS0FTQU5fVk1BTExPQ19QUk9UX05P Uk1BTCkpCiAJCXJldHVybiAodm9pZCAqKXN0YXJ0OwogCiAJc3RhcnQgPSBzZXRfdGFnKHN0YXJ0 LCBrYXNhbl9yYW5kb21fdGFnKCkpOwo= --000000000000d579e505d9b6aa3d-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96980C433EF for ; Tue, 8 Mar 2022 15:32:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GqVf5lJDAWlpfkpbi6YAJmsIBFb1JmaGOnVUlUpiBks=; b=cftqstl5gKnogNf1mwJ/sygp2i sgtxpLdDyNEAjXFSrwlxXjot3BMlFeOuDIn/6A1DBW+uWwxm7cCx7lWCeBciqf7YT3/0XGDmNz5qZ LS4MCoo/FPohl2x3ImM7Zt5WQHXqlEEWzkzGADPfvDjQAQ+F5hLxB0AQWK2jDHSy3SPHqoNCGr4hY nLcwqblyyW1ER5rGawhk7Ygtfc0E/vy0Ze6/0Ab9Zz1A5dlaEYZwKju30pX7wrBf2Ho07qRMANH4o ShvOf5siqClBk2hw7vfnuxc3qYXdqGkyLZ4kMZosP2bxvqXXbJSy7G8BIx9rYDvyOpXhNvVJoGf/E ll00R9Jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRbnl-004ySj-5i; Tue, 08 Mar 2022 15:31:05 +0000 Received: from mail-il1-x135.google.com ([2607:f8b0:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRbnh-004yQz-Oz for linux-arm-kernel@lists.infradead.org; Tue, 08 Mar 2022 15:31:03 +0000 Received: by mail-il1-x135.google.com with SMTP id o12so4887141ilg.5 for ; Tue, 08 Mar 2022 07:30:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QL+ZtmXXGFLuTx2y9WXZomB2eATV+ikv3E06Gw8vFq0=; b=I68j85a6/qjvW0V3IavZmXBtBc8pD6pwX7yGYgP70N3qfY/KekXPn14gqHuXHQi3iz 45y3wjsfeAJoSBGDTb3kxwyUuzILLoXo2eFo4z3nCSjYHUU1aBHr+B04M3kP/DctZcqU FaE5+rdNtdNZSVsKxPIjL2TKvhOwT8EAqwk6x0LlVDTkAwSZt0rUy3ePzZmsgeFzrtgj IcJ9yy+JXS0yPZEfdAsbdDcR8t9w2+5GyzVroPUq4B5oDrMBfwsfDFPB6QqHpu/tXFOv cMBPSu+cM5zifvwDyOWdetr6U++L+xykJjh1Zou3iBXvPcrzyzw1BY2lrHkSovZ8zh++ GxXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QL+ZtmXXGFLuTx2y9WXZomB2eATV+ikv3E06Gw8vFq0=; b=CodIVN1KTYPf5NFbahueMDLFSvwuT6F4DOZQBTlKdOLyEcISOLf8VTvPqrre9HoHuZ dgm0mpJuJKYeTLwGO0Kbl7TgaO5CVpnt5aEcbuz8AlxL8p5KvzeX8qzVhXsA9YPJJBnR BaL+W/0wvKqA0eyYcgFCRvZbeaFUAN0C+UZ22IRN3uxknXO4Aje560iTXLmr8jq8boJP sclFxHOvbKia1Ib7C0MFDppIumcG5tAPiLJYNBcj1/YvE/IppEaeypyaugSnVOyYw5Wg LN/w0S3woQ5wNma45XLuFXqw/KPfIrL7m7rPFQlAVJEKV1ExYFAccfmXrghh8rpBG+CU sIZQ== X-Gm-Message-State: AOAM532LRcLmVecmlW/0aizdPh9s/KRfhcKi638kNuuGF7CqxtlmEzyp vnx4/rZLXIwRMT3l0D73KRHheZhDXMdcJafgo0o= X-Google-Smtp-Source: ABdhPJyPwmIL/pO50iF8syyeci1IJTewvmDOYzdRSzAtoKHRP6OQjBCrXGlvhWl93W16Be715WB6xOEjeRlrzUnkWU8= X-Received: by 2002:a05:6e02:20c3:b0:2c2:9e23:8263 with SMTP id 3-20020a056e0220c300b002c29e238263mr16510481ilq.248.1646753456934; Tue, 08 Mar 2022 07:30:56 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Tue, 8 Mar 2022 16:30:46 +0100 Message-ID: Subject: Re: [PATCH v6 31/39] kasan, vmalloc: only tag normal vmalloc allocations To: Vasily Gorbik Cc: andrey.konovalov@linux.dev, Andrew Morton , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Linux Memory Management List , Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , Linux ARM , Peter Collingbourne , Evgenii Stepanov , LKML , Andrey Konovalov , Ilya Leoshkevich Content-Type: multipart/mixed; boundary="000000000000d579e505d9b6aa3d" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220308_073101_823500_0D75BACB X-CRM114-Status: GOOD ( 24.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --000000000000d579e505d9b6aa3d Content-Type: text/plain; charset="UTF-8" On Tue, Mar 8, 2022 at 4:17 PM Vasily Gorbik wrote: > > On Mon, Jan 24, 2022 at 07:05:05PM +0100, andrey.konovalov@linux.dev wrote: > > From: Andrey Konovalov > > > > The kernel can use to allocate executable memory. The only supported way > > to do that is via __vmalloc_node_range() with the executable bit set in > > the prot argument. (vmap() resets the bit via pgprot_nx()). > > > > Once tag-based KASAN modes start tagging vmalloc allocations, executing > > code from such allocations will lead to the PC register getting a tag, > > which is not tolerated by the kernel. > > > > Only tag the allocations for normal kernel pages. > > > > Signed-off-by: Andrey Konovalov > > This breaks s390 and produce huge amount of false positives. > I haven't been testing linux-next with KASAN for while, now tried it with > next-20220308 and bisected false positives to this commit. > > Any idea what is going wrong here? Hi Vasily, Could you try the attached fix? Thanks! --000000000000d579e505d9b6aa3d Content-Type: application/octet-stream; name="s390-kasan-vmalloc.fix" Content-Disposition: attachment; filename="s390-kasan-vmalloc.fix" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l0iafuk20 ZGlmZiAtLWdpdCBhL21tL2thc2FuL3NoYWRvdy5jIGIvbW0va2FzYW4vc2hhZG93LmMKaW5kZXgg NzI3MmUyNDhkYjg3Li42OTM5NTRmNzcxZWMgMTAwNjQ0Ci0tLSBhL21tL2thc2FuL3NoYWRvdy5j CisrKyBiL21tL2thc2FuL3NoYWRvdy5jCkBAIC00OTIsNyArNDkyLDggQEAgdm9pZCAqX19rYXNh bl91bnBvaXNvbl92bWFsbG9jKGNvbnN0IHZvaWQgKnN0YXJ0LCB1bnNpZ25lZCBsb25nIHNpemUs CiAJICogRG9uJ3QgdGFnIGV4ZWN1dGFibGUgbWVtb3J5LgogCSAqIFRoZSBrZXJuZWwgZG9lc24n dCB0b2xlcmF0ZSBoYXZpbmcgdGhlIFBDIHJlZ2lzdGVyIHRhZ2dlZC4KIAkgKi8KLQlpZiAoIShm bGFncyAmIEtBU0FOX1ZNQUxMT0NfUFJPVF9OT1JNQUwpKQorCWlmIChJU19FTkFCTEVEKENPTkZJ R19LQVNBTl9TV19UQUdTKSAmJgorCSAgICAhKGZsYWdzICYgS0FTQU5fVk1BTExPQ19QUk9UX05P Uk1BTCkpCiAJCXJldHVybiAodm9pZCAqKXN0YXJ0OwogCiAJc3RhcnQgPSBzZXRfdGFnKHN0YXJ0 LCBrYXNhbl9yYW5kb21fdGFnKCkpOwo= --000000000000d579e505d9b6aa3d Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --000000000000d579e505d9b6aa3d--