From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B974CC433E0 for ; Tue, 30 Mar 2021 14:48:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F9B2619D6 for ; Tue, 30 Mar 2021 14:48:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232105AbhC3Osg (ORCPT ); Tue, 30 Mar 2021 10:48:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232020AbhC3OsV (ORCPT ); Tue, 30 Mar 2021 10:48:21 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DCC2C061574 for ; Tue, 30 Mar 2021 07:48:20 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id u9so25229378ejj.7 for ; Tue, 30 Mar 2021 07:48:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bCrN/zdes5zzmbCYt/LU4SIwaX9a7ijlLHxZ2TSxl/k=; b=g4Z8jpHr/ljXyoKgIekeKh2oI+5Ja+ycgyrS5qZMXmvUPSLL7LE9JsrwMgn8QvCzQq e3U+L3R+xwqUSs1iEaihwQWddeqaKIy76U40OSzCAO21VcStW49Ex8FJEU+7GzBT6+fH DN9H2MarTMj4412WbYOaVUDNBVlYk+y+DYKsCQwyysuIfOk43FWfCMzQ5HQ5VD93O7Zg Z1lECNqqXbP1zvF3ZKcC6/NgJ7Cc987hvIXNz4J6e9iTvENI8P4Y24klkW8N57lfqWnA 8rtoJUzgj/39R8N0Xs3l+3EcW78v3f+JUAbtue6eY7toKsqkvK3RS2CXNPtCmETMxa64 hznA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bCrN/zdes5zzmbCYt/LU4SIwaX9a7ijlLHxZ2TSxl/k=; b=mTH32DGR3BHpX+UtGQLEF0i7FHxt3/KZOgb6ux8HUIgq57VvA7Ynm4z2Kl1uRkXzST +0P5q03w0L2fQ0e1Yui0fdlDXcgULErO9NH+T9+c3hCeH0Te4lwRAXE/lxB6a3M23hen hK/JDNapfKUAO3Ho9a23w2Q44r4pxnn0X1zRZlCmVTralbq3RHjxV6txD6zPPhgX9V16 wigbdSgTWydGAk0KWBdoQVrngk7ZoCTMeaBHfluDuwt8+kXNexzZs9IcOS+uzpKy/3Vq x4hj/iqE+ihRLMbBGJ8NH1B5Fxdn2XdP9FWdmrmBss5SimTtqcTrPTAPUUNuksTPMtHL sCdQ== X-Gm-Message-State: AOAM5337TBLBMiwymFcWwCVWhV4xoRnKSmoy+6PZJpzlZPIfEYECo7vH s/gnPNbFxTs3A39pdf/NJNORsiRkPVdt0CUG5vgvLEw6cxY= X-Google-Smtp-Source: ABdhPJy0MGo+RGhx1YuHiMmxqiEC12bg+chRddoyxrEKZFzlBfpWCluMk4UEDIs8LrxP8WIClITtcax+Vh15TMibKc8= X-Received: by 2002:a17:906:1fd6:: with SMTP id e22mr34540372ejt.481.1617115699375; Tue, 30 Mar 2021 07:48:19 -0700 (PDT) MIME-Version: 1.0 References: <20210326112650.307890-1-slyfox@gentoo.org> <4e23d404-5125-6c9c-4aa7-5eff0fa1ba33@redhat.com> <469d6417-64a5-fe99-1214-bb0351833b74@suse.cz> In-Reply-To: From: Andrey Konovalov Date: Tue, 30 Mar 2021 16:48:08 +0200 Message-ID: Subject: Re: [PATCH] mm: page_alloc: ignore init_on_free=1 for page alloc To: Vlastimil Babka Cc: David Hildenbrand , Sergei Trofimovich , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 30, 2021 at 12:07 AM Vlastimil Babka wrote: > > On 3/30/21 12:00 AM, Andrey Konovalov wrote: > > On Mon, Mar 29, 2021 at 2:10 PM Vlastimil Babka wrote: > >> > >> > commit 855a9c4018f3219db8be7e4b9a65ab22aebfde82 > >> > Author: Andrey Konovalov > >> > Date: Thu Mar 18 17:01:40 2021 +1100 > >> > > >> > kasan, mm: integrate page_alloc init with HW_TAGS > >> > >> But the mmotm patch/-next commit also changes post_alloc_hook() > >> > >> Before the patch it was: > >> kernel_unpoison_pages(page, 1 << order); > >> ... > >> kernel_init_free_pages(page, 1 << order); > >> > >> Now it is (for !kasan_has_integrated_init()): > >> > >> kernel_init_free_pages(page, 1 << order); > >> > >> kernel_unpoison_pages(page, 1 << order); > >> > >> That has to be wrong, because we init the page with zeroes and then call > >> kernel_unpoison_pages() which checks for the 0xaa pattern. Andrey? > > > > It's similar to free_pages_prepare(): kernel_unpoison_pages() and > > want_init_on_alloc() are exclusive, so the order shouldn't matter. Am > > I missing something? > > Yeah, when the allocation has __GFP_ZERO, want_init_on_alloc() will return true > even with the static branches disabled. Ah, I see. I'll post a fix soon. Thank you! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32298C433C1 for ; Tue, 30 Mar 2021 14:48:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AB14C619CD for ; Tue, 30 Mar 2021 14:48:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB14C619CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 12A5D6B0081; Tue, 30 Mar 2021 10:48:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DAB66B0083; Tue, 30 Mar 2021 10:48:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBCEA6B0085; Tue, 30 Mar 2021 10:48:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id CD0076B0081 for ; Tue, 30 Mar 2021 10:48:23 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8ABB58249980 for ; Tue, 30 Mar 2021 14:48:23 +0000 (UTC) X-FDA: 77976821286.01.A2FB998 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf10.hostedemail.com (Postfix) with ESMTP id DD63840002F2 for ; Tue, 30 Mar 2021 14:48:17 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id hq27so25229293ejc.9 for ; Tue, 30 Mar 2021 07:48:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bCrN/zdes5zzmbCYt/LU4SIwaX9a7ijlLHxZ2TSxl/k=; b=g4Z8jpHr/ljXyoKgIekeKh2oI+5Ja+ycgyrS5qZMXmvUPSLL7LE9JsrwMgn8QvCzQq e3U+L3R+xwqUSs1iEaihwQWddeqaKIy76U40OSzCAO21VcStW49Ex8FJEU+7GzBT6+fH DN9H2MarTMj4412WbYOaVUDNBVlYk+y+DYKsCQwyysuIfOk43FWfCMzQ5HQ5VD93O7Zg Z1lECNqqXbP1zvF3ZKcC6/NgJ7Cc987hvIXNz4J6e9iTvENI8P4Y24klkW8N57lfqWnA 8rtoJUzgj/39R8N0Xs3l+3EcW78v3f+JUAbtue6eY7toKsqkvK3RS2CXNPtCmETMxa64 hznA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bCrN/zdes5zzmbCYt/LU4SIwaX9a7ijlLHxZ2TSxl/k=; b=nAJdsVYZPMSEkTc6G3gAQyy8NPwBcZr6NgN+dCf/6OE4IPZA9Q+GK3rgfAQDgBFeX9 gFmLBhzd2UxRLsrwB0hAg/r2IofbWmLBvSt3njHLSXmXn3am82p7lEGx1jvL7pvE5fdy EsxXVMLvXZTvEU57xEGVH8FNOP4RF1x0okVIFEzLD6AKlAvwdhczzFpipy99Wuy5FQXU nrjpMdWuroQAYsVnf9kqKfx1MKNJYQt/AKe2Xt/I/r/g0HdLmzbmBGUFY0vI5s4eNJQ8 yeqfcdCHbkKrS1/FnB3B33RDfqzpEXFj1cXntIoyAMmbeQ56oz1qOxAx3YaFGj4q5B5x 1CKg== X-Gm-Message-State: AOAM532JgqM6f39satzmo9cWx4C6DfoNDD582QBwAuZTd3MX97YGGwa2 xbDdLhOeU9S75W1SKPoPXibbBMIz86PTfawV8bI= X-Google-Smtp-Source: ABdhPJy0MGo+RGhx1YuHiMmxqiEC12bg+chRddoyxrEKZFzlBfpWCluMk4UEDIs8LrxP8WIClITtcax+Vh15TMibKc8= X-Received: by 2002:a17:906:1fd6:: with SMTP id e22mr34540372ejt.481.1617115699375; Tue, 30 Mar 2021 07:48:19 -0700 (PDT) MIME-Version: 1.0 References: <20210326112650.307890-1-slyfox@gentoo.org> <4e23d404-5125-6c9c-4aa7-5eff0fa1ba33@redhat.com> <469d6417-64a5-fe99-1214-bb0351833b74@suse.cz> In-Reply-To: From: Andrey Konovalov Date: Tue, 30 Mar 2021 16:48:08 +0200 Message-ID: Subject: Re: [PATCH] mm: page_alloc: ignore init_on_free=1 for page alloc To: Vlastimil Babka Cc: David Hildenbrand , Sergei Trofimovich , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DD63840002F2 X-Stat-Signature: u37daqghykuckn87yspopwtgxge9soxj Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=mail-ej1-f52.google.com; client-ip=209.85.218.52 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617115697-218150 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 30, 2021 at 12:07 AM Vlastimil Babka wrote: > > On 3/30/21 12:00 AM, Andrey Konovalov wrote: > > On Mon, Mar 29, 2021 at 2:10 PM Vlastimil Babka wrote: > >> > >> > commit 855a9c4018f3219db8be7e4b9a65ab22aebfde82 > >> > Author: Andrey Konovalov > >> > Date: Thu Mar 18 17:01:40 2021 +1100 > >> > > >> > kasan, mm: integrate page_alloc init with HW_TAGS > >> > >> But the mmotm patch/-next commit also changes post_alloc_hook() > >> > >> Before the patch it was: > >> kernel_unpoison_pages(page, 1 << order); > >> ... > >> kernel_init_free_pages(page, 1 << order); > >> > >> Now it is (for !kasan_has_integrated_init()): > >> > >> kernel_init_free_pages(page, 1 << order); > >> > >> kernel_unpoison_pages(page, 1 << order); > >> > >> That has to be wrong, because we init the page with zeroes and then call > >> kernel_unpoison_pages() which checks for the 0xaa pattern. Andrey? > > > > It's similar to free_pages_prepare(): kernel_unpoison_pages() and > > want_init_on_alloc() are exclusive, so the order shouldn't matter. Am > > I missing something? > > Yeah, when the allocation has __GFP_ZERO, want_init_on_alloc() will return true > even with the static branches disabled. Ah, I see. I'll post a fix soon. Thank you!