From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE5A7C433FE for ; Thu, 30 Dec 2021 19:11:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241787AbhL3TLt (ORCPT ); Thu, 30 Dec 2021 14:11:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241775AbhL3TLr (ORCPT ); Thu, 30 Dec 2021 14:11:47 -0500 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5E85C06173E for ; Thu, 30 Dec 2021 11:11:46 -0800 (PST) Received: by mail-io1-xd36.google.com with SMTP id p65so30685348iof.3 for ; Thu, 30 Dec 2021 11:11:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0fiv6RL03GYq28gBLTG+oAUxzJLFmuBgFQ32/iqru78=; b=fHvkh4VbM8vMN4jMQ0x3mlFVPT+dqyKP7tPF3+OIdnJfSfsSr5rPuCpvTs23Gmt5c9 hrkw9T2uMFs0NK0MGguQg3+QGr4xZv+AmIq649MWpbTWQo25cFMIiRUB6YG0XcyCFBZB 5lQnW6wzFPQM/mt9O7JVJ9Q3oZ51NyrMTrYbzT7dbvn371+8vONU+iV04J6N8I6itBw/ pQwJhEaMjSqaB3a6hE4reQSK9HdMFt2BNqbvZOL4YlTje+bsZWCCfAvMPuy5hR+6brzl 0Q52yE3uK2SW6xQ1m7sjZu8HU2NZTrFadwhwRnO8ng0u5Rzd26POu0O4bo8AtPSSYxb5 mrIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0fiv6RL03GYq28gBLTG+oAUxzJLFmuBgFQ32/iqru78=; b=HCLjcSMyCmEw2V1JXEVZi/7gT2xl3xvDE1Q9TrvUhNQ40nRsKdmlrhd6wcQKg7ggWK sBHtZA3NB9SAWD8ga1nBd4f/GGwQcMh0GliN6ualXuNAeZm782lgrkau+MehN2ezor+I i7Og/exjKNo5nn/50Iw0euI+6in1xxaJwgGMHhaEwSEC+bgMylr1KuC58atrr5Iw+H1/ Uvkj3jKh5+fJ0LsjeDezu/aC5lUsJPkBTeK8jJRcghxHAFI2GCE7y1BoAQ85v4a3HuLE 5k3aTsrhev0TqSyjtxg05w133nAXTfs0J3MYv5MKpyxh7J/H9NprKt5dYBrVMUITlJzF Lelg== X-Gm-Message-State: AOAM530aSkMFz0fjfs/i0P004yfslUku/9Iv00nscYnDEdfQhIuubzOS 3gxgpwZEITPRxaywprYiL5EHj0e8gyx9twZ17mA= X-Google-Smtp-Source: ABdhPJy0XlHoc6IPNyedHtl279SyfKStumMeOkCGBsJTLPIBAlT3ptpCJGmDcw2JSzuhMXJuV5WnoFlyCg9SpNnDMi0= X-Received: by 2002:a6b:7e03:: with SMTP id i3mr14544209iom.202.1640891506249; Thu, 30 Dec 2021 11:11:46 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Thu, 30 Dec 2021 20:11:35 +0100 Message-ID: Subject: Re: [PATCH mm v4 29/39] kasan, page_alloc: allow skipping memory init for HW_TAGS To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Andrew Morton , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Linux Memory Management List , Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , Linux ARM , Peter Collingbourne , Evgenii Stepanov , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 21, 2021 at 1:12 PM Marco Elver wrote: > > On Mon, Dec 20, 2021 at 11:02PM +0100, andrey.konovalov@linux.dev wrote: > > From: Andrey Konovalov > [...] > > +static inline bool should_skip_init(gfp_t flags) > > +{ > > + /* Don't skip if a software KASAN mode is enabled. */ > > + if (IS_ENABLED(CONFIG_KASAN_GENERIC) || > > + IS_ENABLED(CONFIG_KASAN_SW_TAGS)) > > + return false; > > + > > + /* Don't skip, if hardware tag-based KASAN is not enabled. */ > > + if (!kasan_hw_tags_enabled()) > > + return false; > > Why is the IS_ENABLED(CONFIG_KASAN_{GENERIC,SW_TAGS}) check above > required? Isn't kasan_hw_tags_enabled() always false if one of those is > configured? It is. I wanted to include those checks for completeness, but maybe they just cause confusion instead. Will drop them in v5. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E285C433EF for ; Thu, 30 Dec 2021 19:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MMCNuDmbKfshukOUDF/o/Mm4pGKeKfjlZYIHv2nYNog=; b=NltaJIccQPxPdJ L0YCfCimW016BTK7fFveq1Td4bQ6xdyjGDmQmsJZXWa/d05OyrJLz5iwn/sQFL7yfP9t06IWxVHay RLuoej9pbaBll0ucueUd0R0FXzP5WgeVwH3M2leIgYjNqnYjCJ/Sq0MpoPylDUX84NAM6GC8szuks NAlsU9nJItrHhmORwNa8j+xXfNlijydnzi78lRIoxv3G+Zdne6gp+Jv+n6TBmHGaNhnLrDSIwm+gT YtbIj4r1mLmF7B963O8W0d4V8DrfVa5Kr8ga9rBI9p6rtBwTBR9/c1hMMLlNTzLMlaf2nqNK5yOop 1g89XmOZk/XkV7Pxrejg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n30qI-004tTE-DS; Thu, 30 Dec 2021 19:12:02 +0000 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n30q2-004tO8-Mr for linux-arm-kernel@lists.infradead.org; Thu, 30 Dec 2021 19:11:47 +0000 Received: by mail-io1-xd2d.google.com with SMTP id y11so25320697iod.6 for ; Thu, 30 Dec 2021 11:11:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0fiv6RL03GYq28gBLTG+oAUxzJLFmuBgFQ32/iqru78=; b=fHvkh4VbM8vMN4jMQ0x3mlFVPT+dqyKP7tPF3+OIdnJfSfsSr5rPuCpvTs23Gmt5c9 hrkw9T2uMFs0NK0MGguQg3+QGr4xZv+AmIq649MWpbTWQo25cFMIiRUB6YG0XcyCFBZB 5lQnW6wzFPQM/mt9O7JVJ9Q3oZ51NyrMTrYbzT7dbvn371+8vONU+iV04J6N8I6itBw/ pQwJhEaMjSqaB3a6hE4reQSK9HdMFt2BNqbvZOL4YlTje+bsZWCCfAvMPuy5hR+6brzl 0Q52yE3uK2SW6xQ1m7sjZu8HU2NZTrFadwhwRnO8ng0u5Rzd26POu0O4bo8AtPSSYxb5 mrIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0fiv6RL03GYq28gBLTG+oAUxzJLFmuBgFQ32/iqru78=; b=hlz4feS4rjiFZPL/UmjUMhQ278GW+xWD3TXpoMF0NBs7vFvV2YtNkI0WDa//igzPQC BOKO10DsWeBo/6sct/qvev39mhP3t3WrYPNrr6IGTVG3DrEgUNdYm8YTT6YISyI3ZmCV SdgY37uoFVRUqhn1qwcTkx6LVi4cpkp8zc424ec17slLBqSC1K7O+3G1LAW6m7W1zhUg rQ8JnUt/zzgSUzv6PHaRF9rhaiKAoi2EkByEcrewdRPtYEtwamH8/5Cv0jjdeqqDqbyo yUVOP8ClEecI90DwQImeJyfKMv8fq4h8Fy0s812sU7KfLky9bNkXQow8VLxWuaO22HRr TPSA== X-Gm-Message-State: AOAM532TadWkBXgg9UkTNYcYdRUdCdg7SdON0vc8alPckqQ9E0yJ4MVr lXhVDbHkUJoYJbHnjDlSTkT3Ke2zu0TAaXKWguc= X-Google-Smtp-Source: ABdhPJy0XlHoc6IPNyedHtl279SyfKStumMeOkCGBsJTLPIBAlT3ptpCJGmDcw2JSzuhMXJuV5WnoFlyCg9SpNnDMi0= X-Received: by 2002:a6b:7e03:: with SMTP id i3mr14544209iom.202.1640891506249; Thu, 30 Dec 2021 11:11:46 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Thu, 30 Dec 2021 20:11:35 +0100 Message-ID: Subject: Re: [PATCH mm v4 29/39] kasan, page_alloc: allow skipping memory init for HW_TAGS To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Andrew Morton , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Linux Memory Management List , Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , Linux ARM , Peter Collingbourne , Evgenii Stepanov , LKML , Andrey Konovalov X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_111146_772820_1C463B25 X-CRM114-Status: GOOD ( 14.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 21, 2021 at 1:12 PM Marco Elver wrote: > > On Mon, Dec 20, 2021 at 11:02PM +0100, andrey.konovalov@linux.dev wrote: > > From: Andrey Konovalov > [...] > > +static inline bool should_skip_init(gfp_t flags) > > +{ > > + /* Don't skip if a software KASAN mode is enabled. */ > > + if (IS_ENABLED(CONFIG_KASAN_GENERIC) || > > + IS_ENABLED(CONFIG_KASAN_SW_TAGS)) > > + return false; > > + > > + /* Don't skip, if hardware tag-based KASAN is not enabled. */ > > + if (!kasan_hw_tags_enabled()) > > + return false; > > Why is the IS_ENABLED(CONFIG_KASAN_{GENERIC,SW_TAGS}) check above > required? Isn't kasan_hw_tags_enabled() always false if one of those is > configured? It is. I wanted to include those checks for completeness, but maybe they just cause confusion instead. Will drop them in v5. Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel