From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE2F1C433FE for ; Mon, 6 Dec 2021 21:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354157AbhLFVwf (ORCPT ); Mon, 6 Dec 2021 16:52:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240900AbhLFVwd (ORCPT ); Mon, 6 Dec 2021 16:52:33 -0500 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87796C061746 for ; Mon, 6 Dec 2021 13:49:04 -0800 (PST) Received: by mail-il1-x12e.google.com with SMTP id t8so11712360ilu.8 for ; Mon, 06 Dec 2021 13:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NRJ2Vq4GGEkOM9Z1L10C4gsdtd/cSS7963Dg1Lu81Vk=; b=O5oU/P9UojrjXnhFmSvebt4u3yIwBjy9ZlVDmW2FwCSlXQrNXuaD5T/r9nc5B38xCC UMw4UWCvWApqBXQs8X9vUho2pXiJ4diAJCIr8xX7ADGWbe4FgvqHeX46y5DNIL24PHuy KND30Hj31SIu/p3zJF9C6XBrKl1mLUuVXzlLthev7jJ3x/BuYvZhiRb2zPUL2H56ppZx y6Gdqj5bVS6v7rIjtVj5xZ2hTsPKnqoa/W76ijNxPLz6eNS3WJ9arjEZFwwflsbmOS9L mDNgAiqFm6UWSSn1UjRoKsP2Q8nKE5f3dVaHQMTa3Xiwg/GrkMABpHDz/c4kCfoFG+PN sW1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NRJ2Vq4GGEkOM9Z1L10C4gsdtd/cSS7963Dg1Lu81Vk=; b=aJtPtKEwqc1Exau6uDlOfsqAbWbda3laJ/iYlH7jTm51HkRvw4Ymws/6MbOFWmExKf yfWDS3+ata4jFij7GknEkS6almqIKCS9Z+FsUqNWPPSJhWdpEJWc/iy0BtSNoqgjoSfu FFJfhkMjxUD8BIR/lSLvvX+GZ+L1RAPjEbw40hYqOQbcHnq6EFzy/+UEGFmQ0XhM/xDZ lBlCX22IkAjdbQt56nNFI4D0XX8no3GU6JDmZFOe/iXMSHk6tOYKX66obIE0F0MTFjn1 o8oOqjgcqBcLGJ5TqKEwsAzQ1RBESRNjkLsJ5kZRp5+Wmh2jckyHJfsreWqRgDAmMw5h kuTw== X-Gm-Message-State: AOAM53269zXl4JSHg+bOWTiU4zI5qWdQ+nbk1sldaIFdvlijR/eUslPT YATlHDQYpSOCB2yTne7qHE1oasujX46Ppp/ZV2s= X-Google-Smtp-Source: ABdhPJyn5Di1ZCOMfCFI/yFYRKjnMDY8M7gCkGqKV4X0AyAj2tgSO/+Pf2Qsr1gPkUE3JoF1Ul+gUi8goVPxCOcZfqU= X-Received: by 2002:a05:6e02:1605:: with SMTP id t5mr39279632ilu.233.1638827343979; Mon, 06 Dec 2021 13:49:03 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Mon, 6 Dec 2021 22:48:52 +0100 Message-ID: Subject: Re: [PATCH v2 24/34] kasan, vmalloc, arm64: mark vmalloc mappings as pgprot_tagged To: Vincenzo Frascino Cc: Marco Elver , Alexander Potapenko , Catalin Marinas , Peter Collingbourne , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Andrew Morton , Linux Memory Management List , Will Deacon , Mark Rutland , Linux ARM , Evgenii Stepanov , LKML , Andrey Konovalov , andrey.konovalov@linux.dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 6, 2021 at 10:46 PM wrote: > > From: Andrey Konovalov > > HW_TAGS KASAN relies on ARM Memory Tagging Extension (MTE). With MTE, > a memory region must be mapped as MT_NORMAL_TAGGED to allow setting > memory tags via MTE-specific instructions. > > This change adds proper protection bits to vmalloc() allocations. > These allocations are always backed by page_alloc pages, so the tags > will actually be getting set on the corresponding physical memory. > > Signed-off-by: Andrey Konovalov > Co-developed-by: Vincenzo Frascino > --- > arch/arm64/include/asm/vmalloc.h | 10 ++++++++++ > include/linux/vmalloc.h | 7 +++++++ > mm/vmalloc.c | 2 ++ > 3 files changed, 19 insertions(+) > > diff --git a/arch/arm64/include/asm/vmalloc.h b/arch/arm64/include/asm/vmalloc.h > index b9185503feae..3d35adf365bf 100644 > --- a/arch/arm64/include/asm/vmalloc.h > +++ b/arch/arm64/include/asm/vmalloc.h > @@ -25,4 +25,14 @@ static inline bool arch_vmap_pmd_supported(pgprot_t prot) > > #endif > > +#define arch_vmalloc_pgprot_modify arch_vmalloc_pgprot_modify > +static inline pgprot_t arch_vmalloc_pgprot_modify(pgprot_t prot) > +{ > + if (IS_ENABLED(CONFIG_KASAN_HW_TAGS) && > + (pgprot_val(prot) == pgprot_val(PAGE_KERNEL))) > + prot = pgprot_tagged(prot); > + > + return prot; > +} > + > #endif /* _ASM_ARM64_VMALLOC_H */ > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index b22369f540eb..965c4bf475f1 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -108,6 +108,13 @@ static inline int arch_vmap_pte_supported_shift(unsigned long size) > } > #endif > > +#ifndef arch_vmalloc_pgprot_modify > +static inline pgprot_t arch_vmalloc_pgprot_modify(pgprot_t prot) > +{ > + return prot; > +} > +#endif > + > /* > * Highlevel APIs for driver use > */ > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 7be18b292679..f37d0ed99bf9 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3033,6 +3033,8 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align, > return NULL; > } > > + prot = arch_vmalloc_pgprot_modify(prot); > + > if (vmap_allow_huge && !(vm_flags & VM_NO_HUGE_VMAP)) { > unsigned long size_per_node; > > -- > 2.25.1 > Hi Vincenzo, This patch is based on an early version of the HW_TAGS series you had. Could you PTAL and give your sign-off? Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D3F2C433F5 for ; Mon, 6 Dec 2021 22:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xLgE3qBFdOqTm+ISxgfrp8SI2v224QJRcMOwgum6lI0=; b=wgAuooMNx9NRUy 8moQ4C9yBLjM+zchiIqk/5OitBXcEYmcOh4dia4Es3xq90dJ+ShQQJvuGcI0C+trZ+xoO+bCDRpCq 3H+gXqRv9hqFotZyrUnKHAXJpr/aqy5x2MwqXyKnarQpndw4JKUuRpCeoGn7zzsmcwr2+3imMeKUg PvM+70u2Uh97q7TK1KkAhmaZSK3hUxSKTSwGoaJP0uUE9GSPtp9+JdrZtjUGDKzJGrIyVXBpsvN3s 2xEV14h56XrXRJ9zHaQvaq8Dtmfw0awp2T1F/VkfgwUIY7Kk8TJQv2l0z7GxAXz8fyXWzpan2Eavl rzXpNOhMp6gGgfANgeHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muMBl-0069Px-5x; Mon, 06 Dec 2021 22:10:25 +0000 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muLr7-0060VF-6L for linux-arm-kernel@lists.infradead.org; Mon, 06 Dec 2021 21:49:06 +0000 Received: by mail-il1-x131.google.com with SMTP id i6so11788814ila.0 for ; Mon, 06 Dec 2021 13:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NRJ2Vq4GGEkOM9Z1L10C4gsdtd/cSS7963Dg1Lu81Vk=; b=O5oU/P9UojrjXnhFmSvebt4u3yIwBjy9ZlVDmW2FwCSlXQrNXuaD5T/r9nc5B38xCC UMw4UWCvWApqBXQs8X9vUho2pXiJ4diAJCIr8xX7ADGWbe4FgvqHeX46y5DNIL24PHuy KND30Hj31SIu/p3zJF9C6XBrKl1mLUuVXzlLthev7jJ3x/BuYvZhiRb2zPUL2H56ppZx y6Gdqj5bVS6v7rIjtVj5xZ2hTsPKnqoa/W76ijNxPLz6eNS3WJ9arjEZFwwflsbmOS9L mDNgAiqFm6UWSSn1UjRoKsP2Q8nKE5f3dVaHQMTa3Xiwg/GrkMABpHDz/c4kCfoFG+PN sW1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NRJ2Vq4GGEkOM9Z1L10C4gsdtd/cSS7963Dg1Lu81Vk=; b=BY0EOQorqZvM2HAawQSoMXLSypIoFafMAsCPwIz5xnRp49vurxQ5ILG04Eex2NAnhd lie0aM7zCJBYj8WDXf1eN6gyI9Q1Bxljygx0MTK9wp17UjrAxf2pTAQj/zoVikhuyRlZ KR93bytLKRfIScsVJOtVWyhksiu8vKWbO5EW/resUG/oPDMTX2yCHDu87psvGDBkl/Kd 11aRFHHI74toT0P/7qdVty0uFluzfKWZLK0mUz9s4xDZwBfpSJ9ZaXhzBJc1L5zjNmpd htw17jkFHlwyk6iFbltXcuwrYEHlbehFa3kjrARX6cdLXvKvaAQtp486hfXsWvPtCJTX 89ZA== X-Gm-Message-State: AOAM533CZHlnsZ2Yl+lvamAAbu7vEul58J59wUnXxlyRk6werm/Fz3Na NiL1zMIgXIq+KRNz/vdGw2exzQoDcx3O8bPWcIU= X-Google-Smtp-Source: ABdhPJyn5Di1ZCOMfCFI/yFYRKjnMDY8M7gCkGqKV4X0AyAj2tgSO/+Pf2Qsr1gPkUE3JoF1Ul+gUi8goVPxCOcZfqU= X-Received: by 2002:a05:6e02:1605:: with SMTP id t5mr39279632ilu.233.1638827343979; Mon, 06 Dec 2021 13:49:03 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Mon, 6 Dec 2021 22:48:52 +0100 Message-ID: Subject: Re: [PATCH v2 24/34] kasan, vmalloc, arm64: mark vmalloc mappings as pgprot_tagged To: Vincenzo Frascino Cc: Marco Elver , Alexander Potapenko , Catalin Marinas , Peter Collingbourne , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Andrew Morton , Linux Memory Management List , Will Deacon , Mark Rutland , Linux ARM , Evgenii Stepanov , LKML , Andrey Konovalov , andrey.konovalov@linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_134905_281442_165EF585 X-CRM114-Status: GOOD ( 22.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 6, 2021 at 10:46 PM wrote: > > From: Andrey Konovalov > > HW_TAGS KASAN relies on ARM Memory Tagging Extension (MTE). With MTE, > a memory region must be mapped as MT_NORMAL_TAGGED to allow setting > memory tags via MTE-specific instructions. > > This change adds proper protection bits to vmalloc() allocations. > These allocations are always backed by page_alloc pages, so the tags > will actually be getting set on the corresponding physical memory. > > Signed-off-by: Andrey Konovalov > Co-developed-by: Vincenzo Frascino > --- > arch/arm64/include/asm/vmalloc.h | 10 ++++++++++ > include/linux/vmalloc.h | 7 +++++++ > mm/vmalloc.c | 2 ++ > 3 files changed, 19 insertions(+) > > diff --git a/arch/arm64/include/asm/vmalloc.h b/arch/arm64/include/asm/vmalloc.h > index b9185503feae..3d35adf365bf 100644 > --- a/arch/arm64/include/asm/vmalloc.h > +++ b/arch/arm64/include/asm/vmalloc.h > @@ -25,4 +25,14 @@ static inline bool arch_vmap_pmd_supported(pgprot_t prot) > > #endif > > +#define arch_vmalloc_pgprot_modify arch_vmalloc_pgprot_modify > +static inline pgprot_t arch_vmalloc_pgprot_modify(pgprot_t prot) > +{ > + if (IS_ENABLED(CONFIG_KASAN_HW_TAGS) && > + (pgprot_val(prot) == pgprot_val(PAGE_KERNEL))) > + prot = pgprot_tagged(prot); > + > + return prot; > +} > + > #endif /* _ASM_ARM64_VMALLOC_H */ > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index b22369f540eb..965c4bf475f1 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -108,6 +108,13 @@ static inline int arch_vmap_pte_supported_shift(unsigned long size) > } > #endif > > +#ifndef arch_vmalloc_pgprot_modify > +static inline pgprot_t arch_vmalloc_pgprot_modify(pgprot_t prot) > +{ > + return prot; > +} > +#endif > + > /* > * Highlevel APIs for driver use > */ > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 7be18b292679..f37d0ed99bf9 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3033,6 +3033,8 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align, > return NULL; > } > > + prot = arch_vmalloc_pgprot_modify(prot); > + > if (vmap_allow_huge && !(vm_flags & VM_NO_HUGE_VMAP)) { > unsigned long size_per_node; > > -- > 2.25.1 > Hi Vincenzo, This patch is based on an early version of the HW_TAGS series you had. Could you PTAL and give your sign-off? Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel