From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brandon Maier Date: Tue, 23 Jun 2020 16:22:50 -0500 Subject: Fwd: [PATCH] arm64: zynqmp: Support converting pm_cfg_obj.c In-Reply-To: References: <20200622204531.11301-1-brandon.maier@rockwellcollins.com> <768855ce-6ed4-8272-dc20-48003e50ad70@lucaceresoli.net> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Forwarding as I forgot to CC ---------- Forwarded message --------- From: Brandon Maier Date: Tue, Jun 23, 2020 at 12:08 PM Subject: Re: [PATCH] arm64: zynqmp: Support converting pm_cfg_obj.c To: Luca Ceresoli On Tue, Jun 23, 2020 at 10:18 AM Luca Ceresoli wrote: > > Hi Brandon, > > On 22/06/20 22:45, Brandon Maier wrote: > > To use CONFIG_ZYNQMP_SPL_PM_CFG_OBJ_FILE, a developer must pull down the > > U-Boot source and run ./tools/zynqmp_pm_cfg_obj_convert.py to convert > > their pm_cfg_obj.c into U-Boot's PMU loader format, then feed that file > > back to U-Boot during build. > > > > Instead, by doing the conversion in U-Boot during the build, we can > > simplify the developer's build system. And it ensures that if > > zynqmp_pm_cfg_obj_convert.py is updated, the pm_cfg_obj will stay in > > sync with U-Boot. > > In the workflows I have used so far U-Boot tools are extracted in a > different step w.r.t. U-Boot cross-compilation, so I never felt the need > for this feature. But I understand this feature can be handy. I'm trying to get it to work with Buildroot. Buildroot does have a package for uboot-tools, so I could use that to run it. I'd have to move the config and build commands into Buildroot's uboot package. Since the script belongs to U-Boot anyway, it seemed cleaner to integrate it directly into U-Boot so it could be used by other build systems too. > > The code looks OK too. > > Reviewed-by: Luca Ceresoli > > -- > Luca