From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH] drm/i915: Fix FB WM for HSW Date: Fri, 9 Aug 2013 15:19:32 -0300 Message-ID: References: <1376060529-10141-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-oa0-f43.google.com (mail-oa0-f43.google.com [209.85.219.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 165D6E5C00 for ; Fri, 9 Aug 2013 11:19:33 -0700 (PDT) Received: by mail-oa0-f43.google.com with SMTP id i10so7290612oag.16 for ; Fri, 09 Aug 2013 11:19:32 -0700 (PDT) In-Reply-To: <1376060529-10141-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org 2013/8/9 : > From: Ville Syrj=E4l=E4 > > Due to a misplaced memset(), we never actually enabled the FBC WM on HSW. > Move the memset() to happen a bit earlier, so that it won't clobber > results->enable_fbc_wm. > > Signed-off-by: Ville Syrj=E4l=E4 Yay! Thanks! Reviewed-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_pm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel= _pm.c > index b0e4a0b..862e350 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -2429,6 +2429,8 @@ static void hsw_compute_wm_results(struct drm_devic= e *dev, > break; > max_level =3D level - 1; > > + memset(results, 0, sizeof(*results)); > + > /* The spec says it is preferred to disable FBC WMs instead of di= sabling > * a WM level. */ > results->enable_fbc_wm =3D true; > @@ -2439,7 +2441,6 @@ static void hsw_compute_wm_results(struct drm_devic= e *dev, > } > } > > - memset(results, 0, sizeof(*results)); > for (wm_lp =3D 1; wm_lp <=3D 3; wm_lp++) { > const struct hsw_lp_wm_result *r; > > -- > 1.8.1.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Paulo Zanoni