From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH 45/81] drm/i915: rip out intel_dp->dpms_mode Date: Thu, 26 Jul 2012 15:06:51 -0300 Message-ID: References: <1342016944-23395-1-git-send-email-daniel.vetter@ffwll.ch> <1342016944-23395-46-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-vb0-f49.google.com (mail-vb0-f49.google.com [209.85.212.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F01B9E84B for ; Thu, 26 Jul 2012 11:06:52 -0700 (PDT) Received: by vbbfo1 with SMTP id fo1so1985268vbb.36 for ; Thu, 26 Jul 2012 11:06:51 -0700 (PDT) In-Reply-To: <1342016944-23395-46-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org Hi 2012/7/11 Daniel Vetter : > @@ -2502,7 +2495,6 @@ intel_dp_init(struct drm_device *dev, int output_reg) > return; > > intel_dp->output_reg = output_reg; > - intel_dp->dpms_mode = -1; In your current modeset-rework branch, you're also removing the "intel_dp->port = port" line. Look: http://cgit.freedesktop.org/~danvet/drm/commit/drivers/gpu/drm/i915/intel_dp.c?h=modeset-rework&id=d777693a7eefd4f92a57d49e4a6051f60282f72b This is probably an accident caused by rebasing. -- Paulo Zanoni