From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3716AC43331 for ; Thu, 26 Mar 2020 00:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08C3020714 for ; Thu, 26 Mar 2020 00:49:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gsg9KRFj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727611AbgCZAtE (ORCPT ); Wed, 25 Mar 2020 20:49:04 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:45504 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbgCZAtD (ORCPT ); Wed, 25 Mar 2020 20:49:03 -0400 Received: by mail-ed1-f65.google.com with SMTP id u59so4923596edc.12 for ; Wed, 25 Mar 2020 17:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1vn1Sw/fzu6eNJMMGOtxWYx8rdQZG6RuWTyJImwOwjw=; b=gsg9KRFjiKn13z89wNraOd9yu6kSBQjeoW6zPP9NN/Nltc/mD0NmoiS7DVpqh6gyfg H3mbVFhSty/CU+ygTwuiD5uT6epMlqVRQ+UHtqqr0r73qhp6xFSm4FPAWC9NJ0732BNW j3l7bvL4Uo28QN1NQyh42iEuFnZ6j+QUQZlEI8NGeS5nWmxqAfe3xIOhgaM2eCfpWldq PPBtrSpQuWgvrMz0lmjIjXXYbtV8ZIc5Yh/glzXrRDnaUJzamTsHdB+ai7V7VNU3LvXP qAaaxFYmeYN7IlKbUmh+4oD9Vu1vG9Ec8HogKG3HdlBPRpZVw6vJWTjZhTVTXcu1GQt1 QqAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1vn1Sw/fzu6eNJMMGOtxWYx8rdQZG6RuWTyJImwOwjw=; b=Z0QSvcipmGvBHpSOXUdINLzi/B9icrSYZKC3xszP1szleCjmDfVgokHy790M/PJCUi P7bjSywzeoi1IrkjlIFm++SNpLHt8iDU7FRD8DaAeKfhgNF41HL836GBeRG99sB2INeR DFvCctauYmBXSy87JnosvFDbAyVzZVSlQPXJZYLWMR0MuPvSNn7VGaJGOPSrk8KoTOlg gzotbVcfChe7xSTv2/SFpyYGUhzCdi6dTlA1TqtVDbj0qgsXNxSJiVffWIRHFR6G2oyT lJceDfy+LyWAJg2QkRs1p7DVC3CBIF0mpF4QMycIN5/eTOEphzcP3V+xQeK6dK64pd2i Fypw== X-Gm-Message-State: ANhLgQ1urClh9CG4hBz1qvcIDRu3//+FBf7E9t6aOtL5x8Dc9alRwI64 RV/wUWI0kZhG+80PY1CxCQxrdFf6i/Dx38pGRxA= X-Google-Smtp-Source: ADFU+vvh/FsscPJsXT9hmcNZUpVqQypPljZtjN7yJ3pWQkDyx7feJ5kcnu4dohwgST6Xi5/Y67YPsfURJ/8FFKrvQ0w= X-Received: by 2002:a50:9ea1:: with SMTP id a30mr6016866edf.318.1585183740073; Wed, 25 Mar 2020 17:49:00 -0700 (PDT) MIME-Version: 1.0 References: <20200325152209.3428-1-olteanv@gmail.com> <20200325152209.3428-7-olteanv@gmail.com> <2b5e3b75-bf51-3341-824f-f47feb556f67@gmail.com> In-Reply-To: <2b5e3b75-bf51-3341-824f-f47feb556f67@gmail.com> From: Vladimir Oltean Date: Thu, 26 Mar 2020 02:48:49 +0200 Message-ID: Subject: Re: [PATCH v2 net-next 06/10] net: dsa: b53: Add MTU configuration support To: Florian Fainelli Cc: Andrew Lunn , Vivien Didelot , "David S. Miller" , Jakub Kicinski , murali.policharla@broadcom.com, Stephen Hemminger , Jiri Pirko , Ido Schimmel , Jakub Kicinski , Nikolay Aleksandrov , netdev Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 26 Mar 2020 at 01:22, Florian Fainelli wrote: > > > > On 3/25/2020 8:22 AM, Vladimir Oltean wrote: > > From: Murali Krishna Policharla > > > > Add b53_change_mtu API to configure mtu settings in B53 switch. Enable > > jumbo frame support if configured mtu size is for jumbo frame. Also > > configure BCM583XX devices to send and receive jumbo frames when ports > > are configured with 10/100 Mbps speed. > > > > Signed-off-by: Murali Krishna Policharla > > Signed-off-by: Vladimir Oltean > > [snip] > > > @@ -658,6 +659,14 @@ static void b53_enable_cpu_port(struct b53_device *dev, int port) > > b53_brcm_hdr_setup(dev->ds, port); > > > > b53_br_egress_floods(dev->ds, port, true, true); > > + > > + b53_read32(dev, B53_JUMBO_PAGE, dev->jumbo_pm_reg, &port_mask); > > + > > + if (dev->chip_id == BCM583XX_DEVICE_ID) > > + port_mask |= JPM_10_100_JUMBO_EN; > > + > > + port_mask |= BIT(port); > > + b53_write32(dev, B53_JUMBO_PAGE, dev->jumbo_pm_reg, port_mask); > > This should eventually be brought into b53_set_jumbo() where we already > have existing logic to configure whether to accept jumbo frames and for > 10/100M ports, too, not strictly necessary for now though: > > Acked-by: Florian Fainelli > -- > Florian What do you mean should be done? This? if (!is5325(dev) && !is5365(dev)) - b53_set_jumbo(dev, dev->enable_jumbo, false); + b53_set_jumbo(dev, dev->enable_jumbo, is58xx(dev)); Regards, -Vladimir