From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65CA2C49ED7 for ; Tue, 10 Sep 2019 20:46:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FC342168B for ; Tue, 10 Sep 2019 20:46:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m5SjcWhY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726017AbfIJUqh (ORCPT ); Tue, 10 Sep 2019 16:46:37 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:39936 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725263AbfIJUqg (ORCPT ); Tue, 10 Sep 2019 16:46:36 -0400 Received: by mail-ed1-f65.google.com with SMTP id v38so18555892edm.7; Tue, 10 Sep 2019 13:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=FHzCSzk/2F4WEi0ssp/MuqreT3AyNbr4d9w+cOv5C0k=; b=m5SjcWhY8h3raUlGZ99t3qeAQ2t3krAD/KbeRc7KFZzaT6ZkR6Q4vibZkyxYyZ7wUV bOitVTAnQRH3AgZYZLTe9eoHcaBrekaHnP2vBpb0IdghoHaXypKQ5OUs8P1ZCSRKESmC LN8Hb0Qc5USujWtlvPA/KyyeKv7sIoHgwmp5sEa0jXHyW//slKNd5jTu2uKxGX09ZQzE /i1999i7kZPoNkpyWcm8UBEl6U7LlBQtZfdyP0ukPfxsC7esw9NhuDPb48dsvRfU0Haa YmsAuP+lPFhoHzoystGMIeyAfdRDRvyaJbvZNRHjrZi2m0aSrBvW7Vq8coDoptkK11zq IElw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FHzCSzk/2F4WEi0ssp/MuqreT3AyNbr4d9w+cOv5C0k=; b=lGFJ0odsG7Ht0HXy/PQ8cz9lJj1LLikLPu3AjVrN46/1bAru6wz2BMMfmCM8S0eTzk v3uXs1H7TRbBhkUAsZq0WcfggZxB3GIvq406I+H3KAwmSjMYq7BhgfM9tf/OlA5VczDE BdW+BKOY7zzQkpMgJV4ruk/XhRnZljM70mO+KiadFFUBnorQ8kE1FhZlVXuyXB+O6sOM nFCW2Cd7JUMnvluWLMzgLweuCgg1g729ZMbQXlsMqRImimoYHxHUESkcrPOT0ebmUHKc mG+B+tr1nZ1UTWhPGAchIrmT/Dfgg/1jiQWJyTyStxhLZtuyISdcovosSAHXsPJZB/6u LQ6A== X-Gm-Message-State: APjAAAVJxizP+Y5DwpyHNwN5bYo6ycQGgp2OfXbUuM7pBX9por3evIJV ZySyJ2bxqAkPPNOTZzCur7cfWbz+RUC4NWQ+rws= X-Google-Smtp-Source: APXvYqzj9/FbOE2ReaUBgrcXgifimtd8vb9VA9oTV2k7jlzGpqC2PVqmgSgGuJqgcGPNhcGQsCPCX6Z1uHCoVZ5IKa0= X-Received: by 2002:a17:906:400c:: with SMTP id v12mr26284439ejj.15.1568148394995; Tue, 10 Sep 2019 13:46:34 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a17:906:e258:0:0:0:0 with HTTP; Tue, 10 Sep 2019 13:46:34 -0700 (PDT) In-Reply-To: <20190910124952.GG32337@t480s.localdomain> References: <20190910154238.9155-1-bob.beckett@collabora.com> <20190910154238.9155-4-bob.beckett@collabora.com> <23101286-4da2-2a53-e7cd-71ead263bbaa@gmail.com> <20190910124952.GG32337@t480s.localdomain> From: Vladimir Oltean Date: Tue, 10 Sep 2019 21:46:34 +0100 Message-ID: Subject: Re: [PATCH 3/7] dt-bindings: mv88e6xxx: add ability to set default queue priorities per port To: Vivien Didelot Cc: Florian Fainelli , Robert Beckett , netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Jiri Pirko , Ido Schimmel Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi guys, On 10/09/2019, Vivien Didelot wrote: > Hi Robert, > > On Tue, 10 Sep 2019 09:42:24 -0700, Florian Fainelli > wrote: >> This is a vendor specific driver/property, >> marvell,default-queue-priority (which be cheapskate on words) would be >> more readable. But still, I have some more fundamental issues with the >> general approach, see my response in the cover letter. > > As Florian said, the DT is unlikely to welcome vendor specific nodes for > configuration which may be generic through standard network userspace > tools. > > > Thanks, > > Vivien > While I do agree that the DT bindings are a big no-no for QoS settings, the topic is interesting. What is the user space knob for configuring port-default priority (say RX queue)? Something like this maybe? (a very forced "matchall" with rxnfc) ethtool --config-nfc eth0 flow-type ether src 00:00:00:00:00:00 m 00:00:00:00:00:00 action 5 Regards, -Vladimir