From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D6C9C3F2D2 for ; Sat, 29 Feb 2020 00:50:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7505F2469D for ; Sat, 29 Feb 2020 00:50:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sSEUNIHT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726845AbgB2AuU (ORCPT ); Fri, 28 Feb 2020 19:50:20 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:42408 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726621AbgB2AuT (ORCPT ); Fri, 28 Feb 2020 19:50:19 -0500 Received: by mail-ed1-f65.google.com with SMTP id n18so5485190edw.9 for ; Fri, 28 Feb 2020 16:50:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fxmv1+Fswn7MWmCWRm/GEvVRMXqVzHdSR8v8tCCxRWY=; b=sSEUNIHT38u8ILT3kPcZNveXLcLG2/vaSJmceR9gEy98MUQVPremkwS0n44M1P9UP6 /6EOcjc9cHhLZ5SiI+jESnWlS5SAvW/ysTWtb1EWQS6PrVhU9U5135aNop9oCbSZWvQB qrcEDQh7+fdeSLX/BwFx73/cxMWOn2p6vj2S3jkgFutZKBuLanQu8GrEqWFYN4P3GVTf 8AmCodbTFm8pbQ2LRSpbAhSm1mMnfkqas7KhaM+A5EIEkO0DExkJz13qSOls6E/WWDPO Aby47g6ZqaE8cl832CxMhAsucuSi5rsYoqBYZvyv9ZPIs9Yc4AFqDj2MEySpfrot65cY rAeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fxmv1+Fswn7MWmCWRm/GEvVRMXqVzHdSR8v8tCCxRWY=; b=deKzIeOYvSlZUzBZg7ACal/pA+1Lc7qAqZkCzk/krUU0G0cq0geTFOETAomeuZWvRe LQTVS9hXzugaa5/4bxgL1HFWJSyN3f2E+H6FdcsmoxI0iwrXU9AwkY+Koap/n090vWkw Qakurr3/b8sCr+NP7IyOhrGigBc61A9lfervMWQaZ3JTt723vI8EVzFPeDkFN0bkHXBG EzSmibFLx6srxblXJG26aKWsaQ2eVTACOPLgiP2JR8888GZ4kiMM9MzcNG+gKbOBaY4/ qJAARVyfqH3RIEYE6NMmFjozjhvEED1t0KedZOVn844Vpx+OWmWe2ByfX7y3tN1rBXzi ftOA== X-Gm-Message-State: APjAAAX+C2LiMP2RlqPZU0Vpeed5YIbpv+gqoZeQJNaptNAnth/7N6ey 4LpsB1nOB3gZ+FxfGjoUx8vLNeHF2D14/awg4ds= X-Google-Smtp-Source: APXvYqyhUhTn216F/BcKLyGEScE8O7mub3TJ4FONjTTncvgUGmS9H+X0PCWQENGOVzCt92FiseFiPX4qzA/cA4PT4oM= X-Received: by 2002:a05:6402:3132:: with SMTP id dd18mr6798429edb.118.1582937417149; Fri, 28 Feb 2020 16:50:17 -0800 (PST) MIME-Version: 1.0 References: <20200228172505.14386-1-jiri@resnulli.us> <20200228172505.14386-3-jiri@resnulli.us> In-Reply-To: <20200228172505.14386-3-jiri@resnulli.us> From: Vladimir Oltean Date: Sat, 29 Feb 2020 02:50:06 +0200 Message-ID: Subject: Re: [patch net-next v2 02/12] ocelot_flower: use flow_offload_has_one_action() helper To: Jiri Pirko Cc: netdev , "David S. Miller" , Jakub Kicinski , saeedm@mellanox.com, leon@kernel.org, michael.chan@broadcom.com, vishal@chelsio.com, Jeff Kirsher , Ido Schimmel , aelior@marvell.com, Giuseppe Cavallaro , Alexandre Torgue , Jamal Hadi Salim , Cong Wang , pablo@netfilter.org, Edward Cree , mlxsw@mellanox.com Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 28 Feb 2020 at 19:25, Jiri Pirko wrote: > > From: Jiri Pirko > > Instead of directly checking number of action entries, use > flow_offload_has_one_action() helper. > > Signed-off-by: Jiri Pirko > --- Acked-by: Vladimir Oltean > v1->v2: > - new patch > --- > drivers/net/ethernet/mscc/ocelot_flower.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mscc/ocelot_flower.c b/drivers/net/ethernet/mscc/ocelot_flower.c > index 3d65b99b9734..b85111dcc2be 100644 > --- a/drivers/net/ethernet/mscc/ocelot_flower.c > +++ b/drivers/net/ethernet/mscc/ocelot_flower.c > @@ -19,7 +19,7 @@ static int ocelot_flower_parse_action(struct flow_cls_offload *f, > const struct flow_action_entry *a; > int i; > > - if (f->rule->action.num_entries != 1) > + if (!flow_offload_has_one_action(&f->rule->action)) > return -EOPNOTSUPP; > > flow_action_for_each(i, a, &f->rule->action) { > -- > 2.21.1 >