From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 591EEC48BD5 for ; Tue, 25 Jun 2019 22:15:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C198208E3 for ; Tue, 25 Jun 2019 22:15:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KJlAXSzA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726401AbfFYWPN (ORCPT ); Tue, 25 Jun 2019 18:15:13 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:32959 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726376AbfFYWPN (ORCPT ); Tue, 25 Jun 2019 18:15:13 -0400 Received: by mail-ed1-f67.google.com with SMTP id i11so201319edq.0; Tue, 25 Jun 2019 15:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YJ89zH+nrBwCxeV+GQNcYUmbxQGHmENhmGFBPbX3GJo=; b=KJlAXSzAxB0+BJHxmMKxW382DlOlNE09gm8FYZB09DilCsNIZuNPk5vRTRgRFvs2en etVzniqQZT/NluupenQeUXvi8YKmzG0jnDJG69LrV9cWU9Eq2505ud8Jz/3mces9Wc8e iuPE3+wnhDxYb/EmxxG51frq8lgN+Un5KOuWvxStzlJXrbv4bKxRgwiQ/6lxLpV86nb0 MTykgWffBjjMKmphuWm2BRW4GfLwyri92Bc77M43i2SLkhahM+agPeIDS6wJkI3U1OEW AOcLjigCgs0A+lzrincfxSY8/aDe6AF7UfXi8mwVjTkywTiLm4/ArKwtnHA5BM0yCFIQ HJAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YJ89zH+nrBwCxeV+GQNcYUmbxQGHmENhmGFBPbX3GJo=; b=OCGj4xk5A6Xrz4snCyiYTbH6+KVqeGCT0U158PaDVXn3d8km00Cz42+TRjFtgEUIg8 bSwoI7IENhY18L6yJ0G86TosJEbmVvboSSwzewoStgsa2eadDJTSS8g4hAXPenJJRzcV x9loOQlvOeXqr4g6H1E5Y01B8KkQ6Wb/A79Dza79bGcbLesptj8HA6EaIKii/Hv3ONQt 1YPKSpj5SdcxdBAGnGV39ISBNoIwPZGl2nhVVLnAh2hk+b8H7AOuWO0MFCVZlUxFkmA0 HahicAonYkXHCGqic0N+mqrcJGgthN6ifnYhfL2wqa04GtJwOkf+UQBwrkEJW+j03ZGJ 1xcg== X-Gm-Message-State: APjAAAVI+I7EmnBwxHjOyuj++SwT/mL56Rwhmdv9DPVbFDOK5Sn4Groz nfKFAcO/YKu43X04bdjN6pZkwUsNiZ4dAxw5RtI= X-Google-Smtp-Source: APXvYqz8DbJpNpb5znvTU5EwdpgcMbfZlDW+KqjUocfiDtvsalxwFVYrmPDkScayk8XvGkp02gU2jXIk25RU3418YcY= X-Received: by 2002:a50:987a:: with SMTP id h55mr983205edb.108.1561500910382; Tue, 25 Jun 2019 15:15:10 -0700 (PDT) MIME-Version: 1.0 References: <20190624145251.4849-1-opensource@vdorst.com> <20190624145251.4849-2-opensource@vdorst.com> <20190624153950.hdsuhrvfd77heyor@shell.armlinux.org.uk> <6f80325d-4b42-6174-e050-48626f7a3662@gmail.com> <20190625215329.5ubixxiwprnubwmv@shell.armlinux.org.uk> In-Reply-To: <20190625215329.5ubixxiwprnubwmv@shell.armlinux.org.uk> From: Vladimir Oltean Date: Wed, 26 Jun 2019 01:14:59 +0300 Message-ID: Subject: Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API To: Russell King - ARM Linux admin Cc: =?UTF-8?Q?Ren=C3=A9_van_Dorst?= , sean.wang@mediatek.com, Florian Fainelli , "David S. Miller" , matthias.bgg@gmail.com, Andrew Lunn , Vivien Didelot , frank-w@public-files.de, netdev , linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 26 Jun 2019 at 00:53, Russell King - ARM Linux admin wrote: > > On Tue, Jun 25, 2019 at 11:24:01PM +0300, Vladimir Oltean wrote: > > Hi Russell, > > > > On 6/24/19 6:39 PM, Russell King - ARM Linux admin wrote: > > > This should be removed - state->link is not for use in mac_config. > > > Even in fixed mode, the link can be brought up/down by means of a > > > gpio, and this should be dealt with via the mac_link_* functions. > > > > > > > What do you mean exactly that state->link is not for use, is that true in > > general? > > Yes. mac_config() should not touch it; it is not always in a defined > state. For example, if you set modes via ethtool (the > ethtool_ksettings_set API) then state->link will probably contain > zero irrespective of the true link state. > Experimentally, state->link is zero at the same time as state->speed is -1, so just ignoring !state->link made sense. This is not in-band AN. What is your suggestion? Should I proceed to try and configure the MAC for SPEED_UNKNOWN? > It exists in this structure because it was convenient to just use one > structure to store all the link information in various parts of the > code, and when requesting the negotiated in-band MAC configuration. > > I've come to the conclusion that that decision was a mistake, based > on patches such as the above mistakenly thinking that everything in > the state structure is fair game. I've since updated the docs to > explicitly spell it out, but I'm also looking at the feasibility of > changing the mac_config() interface entirely - splitting it into two > (mac_config_fixed() and mac_config_inband()) and passing only the > appropriate parameters to each. > > However, having looked at that, I think such a change will make some > MAC drivers quite a bit more complicated - having all the config > steps in one method appears to make the configuration of MAC drivers > easier (eg, mvneta, mvpp2.) > > > In drivers/net/dsa/sja1105/sja1105_main.c, if I remove the "if > > (!state->link)" guard, I see PHYLINK calls with a SPEED_UNKNOWN argument for > > ports that are BR_STATE_DISABLED. Is that normal? > > This looks like another driver which has been converted to phylink > without my review; I certainly wasn't aware of it. It gets a few > things wrong, such as: > > 1) not checking state->interface in the validate callback - so it > is basically saying that it can support any PHY interface mode > that the kernel happens to support. > Partially true. It does check the DT bindings for supported MII modes in sja1105_init_mii_settings (for fundamental reasons... the switch expects an 'all-in-one' configuration buffer with the operating modes of all MACs - don't ask me to delay the uploading of this static config until all ports collected their interface_mode from phylink via the mac_config callback - it's a deadlock). It is a gigabit switch with MII/RMII/RGMII MACs - I have never seen any PHY wired for these modes that can change system interface type. > 2) if phylink is configured to use in-band, then state->speed is > undefined; this driver will fail. (If folk don't want to support > that, we ought to have a way to tell phylink to reject anything > that attempts to set it to in-band mode!) > Ok. > 3) it doesn't implement phylink_mac_link_state DSA ops, so it doesn't > support SGMII or 802.3z phy interface modes (see 1). > No, it doesn't. Some odd switch in this device family supports SGMII on 1 of its ports, however I haven't put my hands on it. When I do I'll add checks for strange scenarios, like connecting it to an Aquantia PHY that can switch between SGMII and USXGMII (although why would anyone pair a 10G capable PHY to a 1G capable MAC...) > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up > According to speedtest.net: 11.9Mbps down 500kbps up Thanks, -Vladimir