All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Stewart <christian@paral.in>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 3/3] docker-engine: new package
Date: Tue, 7 Jun 2016 13:18:11 -0700	[thread overview]
Message-ID: <CA+h8R2oZypDvm65RVp3fNX1MYCxSWqX95MxLW-q-K25d4tNccg@mail.gmail.com> (raw)
In-Reply-To: <20160607215439.76ad85ee@free-electrons.com>

Thomas, Andrew,

On Tue, Jun 7, 2016 at 12:54 PM, Thomas Petazzoni <
thomas.petazzoni@free-electrons.com> wrote:
>
> > Does it makes sense to also add selects for BR2_PACKAGE_IPTABLES and
> > BR2_PACKAGE_CA_CERTIFICATES here?  They are not build dependencies,
> > but run-time dependencies.  It may be possible to do some things
> > without the certificates, but I think iptables is always required.
>

Not sure if these are actually required. The iptables calls are direct, not
through calling a cli.

Certs are a different story but that might be out of the scope of the
Docker package. It can run stuff locally without hitting the internet at
all.

> On a similar topic, docker expects a bunch of cgroup mounts to exist
> > somewhere on the system.  Is this something that should be left up to
> > the rootfs author (in which case maybe the help could be extended to
> > explain this), or should the docker-engine recipe attempt to modify
> > fstab somehow?  I'm not sure if there is a way to actually do that
> > though.
>

This is unnecessary. On all of the systems I'm running, with NO fstab
modifications or really anything but enabling the Docker package, it works
fine. Docker might be doing the mounting automatically.

> > +define DOCKER_ENGINE_INSTALL_INIT_SYSV
> > > +   $(INSTALL) -D -m 755
> > > $(@D)/contrib/init/sysvinit-redhat/docker \
> > > +           $(TARGET_DIR)/etc/init.d/S61docker
> >
> > This init file didn't work for me.  I'm not sure if it can work on a
> > buildroot filesystem, are you using systemd instead? I removed most
> > of the checks to get it working (actually, I think I started editing
> > the Ubuntu version).  Maybe a custom init script is required?  I can
> > show you my hack if you like.
>

I didn't expect this to work, and was hoping someone who's not using
systemd would contribute a better init script for it.

I'd appreciate seeing your script if you manage to get one that works well
for you under Buildroot's shell based init sequence.

So a custom init script is probably in order here, especially if you
> report that the one provided by upstream doesn't quite work.
>

+1

For reference, here's my system setup:  http://github.com/paralin/SkiffOS

It's actually a very extensible configuration generation platform, I'm
hoping to expand its scope soon, if anyone would like to
have a look and give me any comments, they would be greatly appreciated :)

Thanks!
Christian Stewart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160607/e99897ea/attachment.html>

  parent reply	other threads:[~2016-06-07 20:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-28 22:46 [Buildroot] [PATCH v6 0/3] Add docker engine support Christian Stewart
2016-05-28 22:46 ` [Buildroot] [PATCH v6 1/3] runc: new package Christian Stewart
2016-07-04 16:29   ` Romain Naour
2016-05-28 22:46 ` [Buildroot] [PATCH v6 2/3] docker-containerd: " Christian Stewart
2016-06-07 20:15   ` Andrew Webster
2016-06-07 20:24     ` Christian Stewart
2016-07-04 17:43   ` Romain Naour
2016-05-28 22:46 ` [Buildroot] [PATCH v6 3/3] docker-engine: " Christian Stewart
2016-06-07 19:43   ` Andrew Webster
2016-06-07 19:54     ` Thomas Petazzoni
2016-06-07 20:10       ` Andrew Webster
2016-06-07 20:18       ` Christian Stewart [this message]
2016-06-07 20:37         ` Andrew Webster
2016-06-07 20:47           ` Thomas Petazzoni
2016-06-08 15:29             ` Andrew Webster
2016-06-27 23:02               ` Christian Stewart
2016-06-28 15:21                 ` Andrew Webster
2016-06-28 17:20                   ` Christian Stewart
2016-07-04 16:13   ` Romain Naour
2016-07-04 16:16     ` Christian Stewart
2016-07-04 17:45       ` Romain Naour
2016-06-27 22:22 ` [Buildroot] [PATCH v6 0/3] Add docker engine support Christian Stewart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+h8R2oZypDvm65RVp3fNX1MYCxSWqX95MxLW-q-K25d4tNccg@mail.gmail.com \
    --to=christian@paral.in \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.