All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Stewart <christian@paral.in>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] package/mender-artifact: bump version to 3.4.0
Date: Thu, 13 Aug 2020 14:41:04 -0700	[thread overview]
Message-ID: <CA+h8R2p+WPoPxaWv34y_KZJOavF8fbEmGr4urmTH2or6qb-3AQ@mail.gmail.com> (raw)
In-Reply-To: <CAFSsvmrrpXkZNcmwy5ukrX4k2XqPGp-kQpNxqq=PN+mG+ir0Tw@mail.gmail.com>

Thomas, Adam,

On Thu, Aug 13, 2020 at 1:04 PM Adam Duskett <aduskett@gmail.com> wrote:
> Just as a note, the go-modules series breaks mender-artifact, and the
> .mk file needs to be modified

> > On Thu, Aug 13, 2020 at 11:52 AM Adam Duskett <aduskett@gmail.com> wrote:
> > > I submitted a patch based on Mirza's suggestion above which works as expected:
> > > https://patchwork.ozlabs.org/project/buildroot/patch/20200813184947.4042927-1-aduskett at gmail.com/
> >
> > > > Do we have an intermediate solution for 2020.08 ? Would reverting the
> > > > mender-artifact bump resolve the issue ?

I have submitted a v4 of the "GO111MODULE" patch series which fixes this issue.

While looking at this and testing - this is the first host-go package
I've tested in mainline - I discovered that a number of the Go build
variables for host packages are not set correctly.

The v4 of the series correctly builds all the HOST and TARGET packages
in the mainline tree that we have today.

The series is not as massive of a change as it may seem. It's actually
just a simplification, rather than symlinking a fake GOPATH we instead
just allow the Go compiler to pick up the root import path from the
go.mod file. As I've pointed out in the past, the Go developers have
requested everyone switch to the new GO111MODULE system instead of
GOPATH.

FWIW I've been using this + testing it constantly for the last months.

Best regards,
Christian Stewart

      parent reply	other threads:[~2020-08-13 21:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15 17:37 [Buildroot] [PATCH 1/4] package/mender-artifact: bump version to 3.4.0 aduskett at gmail.com
2020-07-15 17:37 ` [Buildroot] [PATCH 2/4] package/mender: bump version to 2.3.0 aduskett at gmail.com
2020-07-15 17:37 ` [Buildroot] [PATCH 3/4] package/mender: set the default script version to 3 aduskett at gmail.com
2020-07-15 17:37 ` [Buildroot] [PATCH 4/4] package/mender: add support for update modules aduskett at gmail.com
2020-07-15 21:50 ` [Buildroot] [PATCH 1/4] package/mender-artifact: bump version to 3.4.0 Thomas Petazzoni
2020-07-17 12:51 ` Thomas Petazzoni
2020-08-06 10:57   ` Mirza Krak
2020-08-06 12:41     ` Mirza Krak
2020-08-11 21:58 ` Thomas Petazzoni
2020-08-12  2:26   ` Christian Stewart
2020-08-12  8:22     ` Thomas Petazzoni
2020-08-13 18:52       ` Adam Duskett
2020-08-13 19:39         ` Christian Stewart
2020-08-13 20:04           ` Adam Duskett
2020-08-13 20:20             ` Christian Stewart
2020-08-13 21:41             ` Christian Stewart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+h8R2p+WPoPxaWv34y_KZJOavF8fbEmGr4urmTH2or6qb-3AQ@mail.gmail.com \
    --to=christian@paral.in \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.