All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Stewart <christian@paral.in>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/6] package/go: implement go modules integration
Date: Fri, 17 Jul 2020 14:59:41 -0700	[thread overview]
Message-ID: <CA+h8R2pfDqCrgx0VdnQ=gZAjHxeJk2XqGeXmkvOO-5ggGhRUQw@mail.gmail.com> (raw)
In-Reply-To: <CA+h8R2pfMBEJMQGbKda83jniXNwyAbTRYrr5ETf8Vnb7Sn23QQ@mail.gmail.com>

Hi all,

Was there any particular blocker / issue with this transition to Go
modules which needs addressing?

It should be fairly straightforward: this initial pass of the series
will allow the Go compiler to automatically resolve the "vendor"
directories rather than needing to build a symlinked GOPATH directory.
Everything that worked before should continue to work now, otherwise.

As reported on the Go release docs:

Module support in the go command is now ready for production use, and
we encourage all users to migrate to Go modules for dependency
management. If you are unable to migrate due to a problem in the Go
toolchain, please ensure that the problem has an open issue filed.

Best,
Christian Stewart

On Sat, Jun 6, 2020 at 4:22 PM Christian Stewart <christian@paral.in> wrote:
>
> Hi all,
>
>
> On Sat, Feb 29, 2020 at 11:52 PM Christian Stewart <christian@paral.in> wrote:
> > This commit moves from the GOPATH mechanism to the new GO111MODULE approach for
> > Go based packages. Old Go packages compile with small tweaks.
> >
> > The Go module system replaces the GOPATH mechanism by allowing the Go tool to
> > work with packages correctly without a GOPATH tree.
>
> I have been using this series for everything, including my daily
> driver, since submitting this patch.
>
> It works fine and most importantly works with both the old vendor/
> approach as well as the new go.mod approach.
>
> In this version of the series the Go compiler is never asked to
> download anything. It merely replaces the old "gopath" hacks that were
> in place before. A future patch series on top of this one would add
> support for Go downloading packages as well, however, for now that is
> not part of this series. This is as minimal as possible.
>
> I recommend merging the series as is (in v3) as soon as possible.
>
> Best regards,
> Christian Stewart

      reply	other threads:[~2020-07-17 21:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-01  7:52 [Buildroot] [PATCH v3 1/6] package/go: implement go modules integration Christian Stewart
2020-03-01  7:52 ` [Buildroot] [PATCH v3 2/6] package/runc: remove unnecessary workspace identifier Christian Stewart
2020-03-01  7:52 ` [Buildroot] [PATCH v3 3/6] package/docker-containerd: fix go-module package identifier/targets Christian Stewart
2020-03-01  7:52 ` [Buildroot] [PATCH v3 4/6] package/docker-engine: fix go-module package identifier Christian Stewart
2020-03-01  7:52 ` [Buildroot] [PATCH v3 5/6] package/docker-cli: " Christian Stewart
2020-03-01  7:52 ` [Buildroot] [PATCH v3 6/6] package/docker-proxy: " Christian Stewart
2020-06-06 23:22 ` [Buildroot] [PATCH v3 1/6] package/go: implement go modules integration Christian Stewart
2020-07-17 21:59   ` Christian Stewart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+h8R2pfDqCrgx0VdnQ=gZAjHxeJk2XqGeXmkvOO-5ggGhRUQw@mail.gmail.com' \
    --to=christian@paral.in \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.