Re: [Buildroot] [PATCH-NEXT v3 4/6] support/download/go-post-process: implement Go vendoring support

[Christian Stewart via buildroot <buildroot@buildroot.org>]

Hi all,

On Thu, Jan 6, 2022 at 1:20 PM Christian Stewart <christian@paral.in> wrote:
> The usage of "go mod init" converts package files from older package
> managers like Glide and vendor.conf into a go.mod and go.sum file with
> the checksums maintained.

> > > +# Do the Go vendoring
> > > +pushd ${base_name} > /dev/null
> > > +# modcacherw option leaves directories in the module cache at their default
> > > +# permissions rather than making them read-only.
> > > +if [ ! -f go.mod ] && [ -n "${gomod_init}" ]; then
> > > +    go mod init -modcacherw ${gomod_init}
>
> > So in the end, I ended up creating the go.mod manually (with the same
> > logic) in both pkg-golang.mk and in this download post-process script.
> > But if we find why "go mod init" didn't work in the context of
> > pkg-golang.mk, we could switch back to using that.

One other potential issue is Go will append a line with "go 1.16" -
the major Go version - for compatibility reasons.

So if we update Go to a new major version the go.mod might not be the
same, causing a hash mismatch.

Something to take a look at. Maybe when manually creating go.mod, we
can append "go 1.16" to make the go.mod follow the 1.16 format.

Best regards,
Christian
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot