From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE87C43334 for ; Thu, 2 Jun 2022 12:07:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234816AbiFBMHW (ORCPT ); Thu, 2 Jun 2022 08:07:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234815AbiFBMHV (ORCPT ); Thu, 2 Jun 2022 08:07:21 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A56B1EBEEB; Thu, 2 Jun 2022 05:07:20 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id i185so4597249pge.4; Thu, 02 Jun 2022 05:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XwcwX6loUblFTwI5Bhmlqw2TBVsxdFoQXDJc3TovI80=; b=k7esYmpY4T8Q9KWtH0jxmxeHnbiHqRF3LqvsK/4Ug3Jqt1gx+19gOZth9lZtzHsVKs z65zFnDsir6/cGI09w4DESfFBhn0W5yFwcDHUhGt52REfaoXr8Lc3VEDfnfNLuP0/o4D QhmI2Ziwo2TGGYdyx1kXgJ3Stahlm838VXMAuafTcApdKShsfEtVjX9TkbD+0Bn3YGXN cu4WTkIfORLzLsRbi8XMZ5t129tM/R0mlJLffyFB4beE1GnzDQtiOj8V92AdJoeaUJkr MOUy0Z8FtpbwiXb1/kULCSN9k82OaEpM+B4qbR683RScjbId31DRofz7DKXeQlDpP1zH wMRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XwcwX6loUblFTwI5Bhmlqw2TBVsxdFoQXDJc3TovI80=; b=tgW3x3fSz6AnxVIFHcR9qdnnwznVBAKmjKHiAwjYxffPQ9R4q7YZraQlvtEZdSP1tW qkHxAWOf68VL8RQ2oHHCQPl6eusjYqfZKJsc190xid659GVlBNnnSbiTeojuHbuJZcgM li5B/2xYlvdjS0DIACwmTUKAXQGhQFHMkF8o9BWjMHMndH9Xsnmr7eKH1BhAaVc5NMmB D+6MgkXL3TitcqSlmpsNyIBOGzmd1lmwaKNILSyt4fjKCjocM3GR86+FssmIh4q7g3Ie HTtLQ9aqvgNCPRLwh0Sd3/9jgtH2IWMmU5NK83DSdccNoewua0dUVC3omDMuk1Su1+ra pnaA== X-Gm-Message-State: AOAM531ksrFcw+pauIm8rdZe83w1GjWhIxp0jmF/kniDugr2fTIpPwrl StoZIvmv2FyccOu7w3aUAdyUARBkG/O0xM5IhMs= X-Google-Smtp-Source: ABdhPJwLN3JLAZweJSj8I9PDnQ5t3UDnCmJ6jzOmk2NgYlJRjY/uTSAVQc8mkFdLPGGc+2hlm0r13u/yFcGFZ+aEYy0= X-Received: by 2002:a63:2c15:0:b0:3f6:6a5f:8f0a with SMTP id s21-20020a632c15000000b003f66a5f8f0amr3954364pgs.76.1654171639739; Thu, 02 Jun 2022 05:07:19 -0700 (PDT) MIME-Version: 1.0 References: <20220531102809.11976-1-peterwu.pub@gmail.com> <20220531102809.11976-8-peterwu.pub@gmail.com> In-Reply-To: From: szuni chen Date: Thu, 2 Jun 2022 20:07:08 +0800 Message-ID: Subject: Re: [PATCH 07/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support To: Andy Shevchenko Cc: ChiaEn Wu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , cy_huang@richtek.com, alice_chen@richtek.com, chiaen_wu@richtek.com, dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Thank you for the valuable suggestion. Andy Shevchenko =E6=96=BC 2022=E5=B9=B46=E6=9C= =881=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=885:57=E5=AF=AB=E9=81=93= =EF=BC=9A > > On Tue, May 31, 2022 at 1:32 PM ChiaEn Wu wrote: > > > > From: Alice Chen > > > > Add Mediatek MT6370 flashlight support > > Same comments about the commit message. > > ... > > > +#include > > +#include > > +#include > > + blank line? Thanks, this will be refined in the new version. > > > +#include > > + blank line Thanks, this will be refined in the new version. > > > +enum { > > + MT6370_LED_FLASH1, > > + MT6370_LED_FLASH2, > > + MT6370_MAX_LEDS > > +}; > > ... > > > + struct mt6370_led *led =3D container_of(fl_cdev, struct mt6370_= led, > > + flash); > > > + struct mt6370_led *led =3D container_of(fl_cdev, struct mt6370_= led, > > + flash); > > Make a helper out of this > > #define to_mt637_led() container_of() > > and reuse. Thanks, this will be refined in the new version. > > ... > > > + /* > > + * For the flash turn on/off, HW rampping up/down time is 5ms/5= 00us, > > ramping > > > + * respectively > > Period! Thanks, this will be refined in the new version. > > > + */ > > ... > > > + const char * const states[] =3D { "off", "keep", "on" }; > > + const char *str; > > + int ret; > > + > > + if (!fwnode_property_read_string(init_data->fwnode, > > + "default-state", &str)) { > > + ret =3D match_string(states, ARRAY_SIZE(states), str); > > + if (ret < 0) > > + ret =3D STATE_OFF; > > + > > + led->default_state =3D ret; > > + } > > fwnode_property_match_string()? Sorry, but I think the use of this function is different from my target. I want to read the string of the "default-state" property and figure out if the string is in the states array. But the fwnode_property_match_string aimed to figure out if the state in the property array. One is a property array and another one is a state array. > > ... > > > + if (!count || count > MT6370_MAX_LEDS) { > > + dev_err(&pdev->dev, > > + "No child node or node count over max led number %lu\n"= , count); > > + return -EINVAL; > > return dev_err_probe(...); Thanks, will refine in the new version > > > + } > > > -- > With Best Regards, > Andy Shevchenko > > Sincerely, Alice Chen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95AB5C43334 for ; Thu, 2 Jun 2022 12:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wtshWAiA8v6kPycJtgk03QY3wBjcxOdz62up9IaWFh8=; b=E/8RgkZ1ol0M7l spwJF5k9GjFjrLGNwKeJ64FuyB0zd3KNa6fTtirlQdz9pMZLqJeBiI81PbQ2hUFOm2cIZTwM9Mm0x aZsLa/cOT860fzR+ygCQreF1qr2x9NhC0vJZMEiE2ipIpFeM2A0OCxtUDHsnFbpZ9Fy93sZ+juOLZ QYYmER9a4k8DaHocgojp55AUrF8a9gN7iUl+0T27PHqErNyHQhohKJZRakiTkH7+Luj2DC4JPevHf B/+aLZ4GBUvPrhSK91riiOPWgxA/QCCR6rrfOa2xi+ADVWBGWcXruNGodrXel6y7lAUVPUfeHhE6V ojsGQUJMZGJhj8g13K8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwjcf-003847-UU; Thu, 02 Jun 2022 12:08:18 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwjbo-0037bG-0l; Thu, 02 Jun 2022 12:07:26 +0000 Received: by mail-pf1-x42b.google.com with SMTP id 187so4584820pfu.9; Thu, 02 Jun 2022 05:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XwcwX6loUblFTwI5Bhmlqw2TBVsxdFoQXDJc3TovI80=; b=k7esYmpY4T8Q9KWtH0jxmxeHnbiHqRF3LqvsK/4Ug3Jqt1gx+19gOZth9lZtzHsVKs z65zFnDsir6/cGI09w4DESfFBhn0W5yFwcDHUhGt52REfaoXr8Lc3VEDfnfNLuP0/o4D QhmI2Ziwo2TGGYdyx1kXgJ3Stahlm838VXMAuafTcApdKShsfEtVjX9TkbD+0Bn3YGXN cu4WTkIfORLzLsRbi8XMZ5t129tM/R0mlJLffyFB4beE1GnzDQtiOj8V92AdJoeaUJkr MOUy0Z8FtpbwiXb1/kULCSN9k82OaEpM+B4qbR683RScjbId31DRofz7DKXeQlDpP1zH wMRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XwcwX6loUblFTwI5Bhmlqw2TBVsxdFoQXDJc3TovI80=; b=bzSfOU4DBIcs85vQxZVWPkoUuJvlUWhaHwWw585HmSlHs2vDe6nz4bVF8NOWhbuFup YRW0uAd7R4yY4/Bfh2IQovLO9a7XMSX5CcjJMOMoeoMS53BU2DWHPX/L3L77mvvgE443 lafNRwL6ArFqs/kOufy4WqkN9M/oUED8oAc0505Mw9LhFifGj2psCXHCiXZsZJzwaAMa 40UZlM6wy08d+tG1w2vxRwLvKaJ8DXNteiwvC+yTcbvfMmwckyAnYhWBkDKZnP2oe+gR 5lIhGrXS+FkxnVVhw9Bek39SffgA+nWe6VAckPsGj+3eTchdZrDLefhiDM6mEqBkkEnc VyYA== X-Gm-Message-State: AOAM532mhL9HZ3/LPyTxDdyGyBrZl8nDW+8b94pzcywj+8bvyk7mx6s2 tQlB2GNhxMfZs1WBGR2j7Z5LEAuHamGT5axdnug= X-Google-Smtp-Source: ABdhPJwLN3JLAZweJSj8I9PDnQ5t3UDnCmJ6jzOmk2NgYlJRjY/uTSAVQc8mkFdLPGGc+2hlm0r13u/yFcGFZ+aEYy0= X-Received: by 2002:a63:2c15:0:b0:3f6:6a5f:8f0a with SMTP id s21-20020a632c15000000b003f66a5f8f0amr3954364pgs.76.1654171639739; Thu, 02 Jun 2022 05:07:19 -0700 (PDT) MIME-Version: 1.0 References: <20220531102809.11976-1-peterwu.pub@gmail.com> <20220531102809.11976-8-peterwu.pub@gmail.com> In-Reply-To: From: szuni chen Date: Thu, 2 Jun 2022 20:07:08 +0800 Message-ID: Subject: Re: [PATCH 07/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support To: Andy Shevchenko Cc: ChiaEn Wu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , cy_huang@richtek.com, alice_chen@richtek.com, chiaen_wu@richtek.com, dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_050724_120808_C12A4195 X-CRM114-Status: GOOD ( 22.34 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB0aGUgdmFsdWFibGUgc3VnZ2VzdGlvbi4KCkFuZHkgU2hldmNoZW5rbyA8 YW5keS5zaGV2Y2hlbmtvQGdtYWlsLmNvbT4g5pa8IDIwMjLlubQ25pyIMeaXpSDpgLHkuIkg5LiL 5Y2INTo1N+Wvq+mBk++8mgo+Cj4gT24gVHVlLCBNYXkgMzEsIDIwMjIgYXQgMTozMiBQTSBDaGlh RW4gV3UgPHBldGVyd3UucHViQGdtYWlsLmNvbT4gd3JvdGU6Cj4gPgo+ID4gRnJvbTogQWxpY2Ug Q2hlbiA8YWxpY2VfY2hlbkByaWNodGVrLmNvbT4KPiA+Cj4gPiBBZGQgTWVkaWF0ZWsgTVQ2Mzcw IGZsYXNobGlnaHQgc3VwcG9ydAo+Cj4gU2FtZSBjb21tZW50cyBhYm91dCB0aGUgY29tbWl0IG1l c3NhZ2UuCj4KPiAuLi4KPgo+ID4gKyNpbmNsdWRlIDxsaW51eC9wbGF0Zm9ybV9kZXZpY2UuaD4K PiA+ICsjaW5jbHVkZSA8bGludXgvcHJvcGVydHkuaD4KPiA+ICsjaW5jbHVkZSA8bGludXgvcmVn bWFwLmg+Cj4KPiArIGJsYW5rIGxpbmU/ClRoYW5rcywgdGhpcyB3aWxsIGJlIHJlZmluZWQgaW4g dGhlIG5ldyB2ZXJzaW9uLgo+Cj4gPiArI2luY2x1ZGUgPG1lZGlhL3Y0bDItZmxhc2gtbGVkLWNs YXNzLmg+Cj4KPiArIGJsYW5rIGxpbmUKVGhhbmtzLCB0aGlzIHdpbGwgYmUgcmVmaW5lZCBpbiB0 aGUgbmV3IHZlcnNpb24uCj4KPiA+ICtlbnVtIHsKPiA+ICsgICAgICAgTVQ2MzcwX0xFRF9GTEFT SDEsCj4gPiArICAgICAgIE1UNjM3MF9MRURfRkxBU0gyLAo+ID4gKyAgICAgICBNVDYzNzBfTUFY X0xFRFMKPiA+ICt9Owo+Cj4gLi4uCj4KPiA+ICsgICAgICAgc3RydWN0IG10NjM3MF9sZWQgKmxl ZCA9IGNvbnRhaW5lcl9vZihmbF9jZGV2LCBzdHJ1Y3QgbXQ2MzcwX2xlZCwKPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmbGFzaCk7Cj4KPiA+ICsgICAg ICAgc3RydWN0IG10NjM3MF9sZWQgKmxlZCA9IGNvbnRhaW5lcl9vZihmbF9jZGV2LCBzdHJ1Y3Qg bXQ2MzcwX2xlZCwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBmbGFzaCk7Cj4KPiBNYWtlIGEgaGVscGVyIG91dCBvZiB0aGlzCj4KPiAgICNkZWZpbmUg dG9fbXQ2MzdfbGVkKCkgIGNvbnRhaW5lcl9vZigpCj4KPiBhbmQgcmV1c2UuClRoYW5rcywgdGhp cyB3aWxsIGJlIHJlZmluZWQgaW4gdGhlIG5ldyB2ZXJzaW9uLgo+Cj4gLi4uCj4KPiA+ICsgICAg ICAgLyoKPiA+ICsgICAgICAgICogRm9yIHRoZSBmbGFzaCB0dXJuIG9uL29mZiwgSFcgcmFtcHBp bmcgdXAvZG93biB0aW1lIGlzIDVtcy81MDB1cywKPgo+IHJhbXBpbmcKPgo+ID4gKyAgICAgICAg KiByZXNwZWN0aXZlbHkKPgo+IFBlcmlvZCEKVGhhbmtzLCB0aGlzIHdpbGwgYmUgcmVmaW5lZCBp biB0aGUgbmV3IHZlcnNpb24uCj4KPiA+ICsgICAgICAgICovCj4KPiAuLi4KPgo+ID4gKyAgICAg ICBjb25zdCBjaGFyICogY29uc3Qgc3RhdGVzW10gPSB7ICJvZmYiLCAia2VlcCIsICJvbiIgfTsK PiA+ICsgICAgICAgY29uc3QgY2hhciAqc3RyOwo+ID4gKyAgICAgICBpbnQgcmV0Owo+ID4gKwo+ ID4gKyAgICAgICBpZiAoIWZ3bm9kZV9wcm9wZXJ0eV9yZWFkX3N0cmluZyhpbml0X2RhdGEtPmZ3 bm9kZSwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImRlZmF1 bHQtc3RhdGUiLCAmc3RyKSkgewo+ID4gKyAgICAgICAgICAgICAgIHJldCA9IG1hdGNoX3N0cmlu ZyhzdGF0ZXMsIEFSUkFZX1NJWkUoc3RhdGVzKSwgc3RyKTsKPiA+ICsgICAgICAgICAgICAgICBp ZiAocmV0IDwgMCkKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIHJldCA9IFNUQVRFX09GRjsK PiA+ICsKPiA+ICsgICAgICAgICAgICAgICBsZWQtPmRlZmF1bHRfc3RhdGUgPSByZXQ7Cj4gPiAr ICAgICAgIH0KPgo+IGZ3bm9kZV9wcm9wZXJ0eV9tYXRjaF9zdHJpbmcoKT8KU29ycnksIGJ1dCBJ IHRoaW5rIHRoZSB1c2Ugb2YgdGhpcyBmdW5jdGlvbiBpcyBkaWZmZXJlbnQgZnJvbSBteSB0YXJn ZXQuCkkgd2FudCB0byByZWFkIHRoZSBzdHJpbmcgb2YgdGhlICJkZWZhdWx0LXN0YXRlIiBwcm9w ZXJ0eSBhbmQgZmlndXJlCm91dCBpZiB0aGUgc3RyaW5nIGlzIGluIHRoZSBzdGF0ZXMgYXJyYXku CkJ1dCB0aGUgZndub2RlX3Byb3BlcnR5X21hdGNoX3N0cmluZyBhaW1lZCB0byBmaWd1cmUgb3V0 IGlmIHRoZSBzdGF0ZQppbiB0aGUgcHJvcGVydHkgYXJyYXkuCk9uZSBpcyBhIHByb3BlcnR5IGFy cmF5IGFuZCBhbm90aGVyIG9uZSBpcyBhIHN0YXRlIGFycmF5Lgo+Cj4gLi4uCj4KPiA+ICsgICAg ICAgaWYgKCFjb3VudCB8fCBjb3VudCA+IE1UNjM3MF9NQVhfTEVEUykgewo+ID4gKyAgICAgICAg ICAgICAgIGRldl9lcnIoJnBkZXYtPmRldiwKPiA+ICsgICAgICAgICAgICAgICAiTm8gY2hpbGQg bm9kZSBvciBub2RlIGNvdW50IG92ZXIgbWF4IGxlZCBudW1iZXIgJWx1XG4iLCBjb3VudCk7Cj4g PiArICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4KPiByZXR1cm4gZGV2X2Vycl9wcm9i ZSguLi4pOwpUaGFua3MsIHdpbGwgcmVmaW5lIGluIHRoZSBuZXcgdmVyc2lvbgo+Cj4gPiArICAg ICAgIH0KPgo+Cj4gLS0KPiBXaXRoIEJlc3QgUmVnYXJkcywKPiBBbmR5IFNoZXZjaGVua28KPgo+ ClNpbmNlcmVseSwKQWxpY2UgQ2hlbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KTGludXgtbWVkaWF0ZWsgbWFpbGluZyBsaXN0CkxpbnV4LW1lZGlhdGVr QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1tZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E322C43334 for ; Thu, 2 Jun 2022 12:09:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TDeZNvhHvR7TxS9qQT9p+4/eJQaX7iUTHS1w19ZrexQ=; b=4+8vvQqW12UdCo kr4cOqrbv0oeTe5TJuzT6aAJA9tVuINeP/wVShLkSVlgkrRjb+II1ZoNUxtPHap6XQd9IbMbm65rO AHXhRB3duIXSfgQhRzKcKiwwGWXW2mzmV13fGVjWhFCebJAOQrBstrxDO3NeviT9/lNAiBzX/6c5l NAkIbOQtcoNOoiLxjBgBApxkAfsVLonpGr7GWXMj+Dxp9PjiHyZTybmwrjuoCbPtyzmKeITaN66x1 NqYi1WPeMlChMjtRY1JOhuZ/DFzjbDTMozqcIXy65+Jl+ZQ/g0ZyRG4ZE21dYGZuEkOOBNg5ammAN Bl8DWRyrBaXDe86Q+chg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwjcI-0037sA-8i; Thu, 02 Jun 2022 12:07:54 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwjbo-0037bG-0l; Thu, 02 Jun 2022 12:07:26 +0000 Received: by mail-pf1-x42b.google.com with SMTP id 187so4584820pfu.9; Thu, 02 Jun 2022 05:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XwcwX6loUblFTwI5Bhmlqw2TBVsxdFoQXDJc3TovI80=; b=k7esYmpY4T8Q9KWtH0jxmxeHnbiHqRF3LqvsK/4Ug3Jqt1gx+19gOZth9lZtzHsVKs z65zFnDsir6/cGI09w4DESfFBhn0W5yFwcDHUhGt52REfaoXr8Lc3VEDfnfNLuP0/o4D QhmI2Ziwo2TGGYdyx1kXgJ3Stahlm838VXMAuafTcApdKShsfEtVjX9TkbD+0Bn3YGXN cu4WTkIfORLzLsRbi8XMZ5t129tM/R0mlJLffyFB4beE1GnzDQtiOj8V92AdJoeaUJkr MOUy0Z8FtpbwiXb1/kULCSN9k82OaEpM+B4qbR683RScjbId31DRofz7DKXeQlDpP1zH wMRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XwcwX6loUblFTwI5Bhmlqw2TBVsxdFoQXDJc3TovI80=; b=bzSfOU4DBIcs85vQxZVWPkoUuJvlUWhaHwWw585HmSlHs2vDe6nz4bVF8NOWhbuFup YRW0uAd7R4yY4/Bfh2IQovLO9a7XMSX5CcjJMOMoeoMS53BU2DWHPX/L3L77mvvgE443 lafNRwL6ArFqs/kOufy4WqkN9M/oUED8oAc0505Mw9LhFifGj2psCXHCiXZsZJzwaAMa 40UZlM6wy08d+tG1w2vxRwLvKaJ8DXNteiwvC+yTcbvfMmwckyAnYhWBkDKZnP2oe+gR 5lIhGrXS+FkxnVVhw9Bek39SffgA+nWe6VAckPsGj+3eTchdZrDLefhiDM6mEqBkkEnc VyYA== X-Gm-Message-State: AOAM532mhL9HZ3/LPyTxDdyGyBrZl8nDW+8b94pzcywj+8bvyk7mx6s2 tQlB2GNhxMfZs1WBGR2j7Z5LEAuHamGT5axdnug= X-Google-Smtp-Source: ABdhPJwLN3JLAZweJSj8I9PDnQ5t3UDnCmJ6jzOmk2NgYlJRjY/uTSAVQc8mkFdLPGGc+2hlm0r13u/yFcGFZ+aEYy0= X-Received: by 2002:a63:2c15:0:b0:3f6:6a5f:8f0a with SMTP id s21-20020a632c15000000b003f66a5f8f0amr3954364pgs.76.1654171639739; Thu, 02 Jun 2022 05:07:19 -0700 (PDT) MIME-Version: 1.0 References: <20220531102809.11976-1-peterwu.pub@gmail.com> <20220531102809.11976-8-peterwu.pub@gmail.com> In-Reply-To: From: szuni chen Date: Thu, 2 Jun 2022 20:07:08 +0800 Message-ID: Subject: Re: [PATCH 07/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support To: Andy Shevchenko Cc: ChiaEn Wu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , cy_huang@richtek.com, alice_chen@richtek.com, chiaen_wu@richtek.com, dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_050724_120808_C12A4195 X-CRM114-Status: GOOD ( 22.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB0aGUgdmFsdWFibGUgc3VnZ2VzdGlvbi4KCkFuZHkgU2hldmNoZW5rbyA8 YW5keS5zaGV2Y2hlbmtvQGdtYWlsLmNvbT4g5pa8IDIwMjLlubQ25pyIMeaXpSDpgLHkuIkg5LiL 5Y2INTo1N+Wvq+mBk++8mgo+Cj4gT24gVHVlLCBNYXkgMzEsIDIwMjIgYXQgMTozMiBQTSBDaGlh RW4gV3UgPHBldGVyd3UucHViQGdtYWlsLmNvbT4gd3JvdGU6Cj4gPgo+ID4gRnJvbTogQWxpY2Ug Q2hlbiA8YWxpY2VfY2hlbkByaWNodGVrLmNvbT4KPiA+Cj4gPiBBZGQgTWVkaWF0ZWsgTVQ2Mzcw IGZsYXNobGlnaHQgc3VwcG9ydAo+Cj4gU2FtZSBjb21tZW50cyBhYm91dCB0aGUgY29tbWl0IG1l c3NhZ2UuCj4KPiAuLi4KPgo+ID4gKyNpbmNsdWRlIDxsaW51eC9wbGF0Zm9ybV9kZXZpY2UuaD4K PiA+ICsjaW5jbHVkZSA8bGludXgvcHJvcGVydHkuaD4KPiA+ICsjaW5jbHVkZSA8bGludXgvcmVn bWFwLmg+Cj4KPiArIGJsYW5rIGxpbmU/ClRoYW5rcywgdGhpcyB3aWxsIGJlIHJlZmluZWQgaW4g dGhlIG5ldyB2ZXJzaW9uLgo+Cj4gPiArI2luY2x1ZGUgPG1lZGlhL3Y0bDItZmxhc2gtbGVkLWNs YXNzLmg+Cj4KPiArIGJsYW5rIGxpbmUKVGhhbmtzLCB0aGlzIHdpbGwgYmUgcmVmaW5lZCBpbiB0 aGUgbmV3IHZlcnNpb24uCj4KPiA+ICtlbnVtIHsKPiA+ICsgICAgICAgTVQ2MzcwX0xFRF9GTEFT SDEsCj4gPiArICAgICAgIE1UNjM3MF9MRURfRkxBU0gyLAo+ID4gKyAgICAgICBNVDYzNzBfTUFY X0xFRFMKPiA+ICt9Owo+Cj4gLi4uCj4KPiA+ICsgICAgICAgc3RydWN0IG10NjM3MF9sZWQgKmxl ZCA9IGNvbnRhaW5lcl9vZihmbF9jZGV2LCBzdHJ1Y3QgbXQ2MzcwX2xlZCwKPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmbGFzaCk7Cj4KPiA+ICsgICAg ICAgc3RydWN0IG10NjM3MF9sZWQgKmxlZCA9IGNvbnRhaW5lcl9vZihmbF9jZGV2LCBzdHJ1Y3Qg bXQ2MzcwX2xlZCwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBmbGFzaCk7Cj4KPiBNYWtlIGEgaGVscGVyIG91dCBvZiB0aGlzCj4KPiAgICNkZWZpbmUg dG9fbXQ2MzdfbGVkKCkgIGNvbnRhaW5lcl9vZigpCj4KPiBhbmQgcmV1c2UuClRoYW5rcywgdGhp cyB3aWxsIGJlIHJlZmluZWQgaW4gdGhlIG5ldyB2ZXJzaW9uLgo+Cj4gLi4uCj4KPiA+ICsgICAg ICAgLyoKPiA+ICsgICAgICAgICogRm9yIHRoZSBmbGFzaCB0dXJuIG9uL29mZiwgSFcgcmFtcHBp bmcgdXAvZG93biB0aW1lIGlzIDVtcy81MDB1cywKPgo+IHJhbXBpbmcKPgo+ID4gKyAgICAgICAg KiByZXNwZWN0aXZlbHkKPgo+IFBlcmlvZCEKVGhhbmtzLCB0aGlzIHdpbGwgYmUgcmVmaW5lZCBp biB0aGUgbmV3IHZlcnNpb24uCj4KPiA+ICsgICAgICAgICovCj4KPiAuLi4KPgo+ID4gKyAgICAg ICBjb25zdCBjaGFyICogY29uc3Qgc3RhdGVzW10gPSB7ICJvZmYiLCAia2VlcCIsICJvbiIgfTsK PiA+ICsgICAgICAgY29uc3QgY2hhciAqc3RyOwo+ID4gKyAgICAgICBpbnQgcmV0Owo+ID4gKwo+ ID4gKyAgICAgICBpZiAoIWZ3bm9kZV9wcm9wZXJ0eV9yZWFkX3N0cmluZyhpbml0X2RhdGEtPmZ3 bm9kZSwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImRlZmF1 bHQtc3RhdGUiLCAmc3RyKSkgewo+ID4gKyAgICAgICAgICAgICAgIHJldCA9IG1hdGNoX3N0cmlu ZyhzdGF0ZXMsIEFSUkFZX1NJWkUoc3RhdGVzKSwgc3RyKTsKPiA+ICsgICAgICAgICAgICAgICBp ZiAocmV0IDwgMCkKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIHJldCA9IFNUQVRFX09GRjsK PiA+ICsKPiA+ICsgICAgICAgICAgICAgICBsZWQtPmRlZmF1bHRfc3RhdGUgPSByZXQ7Cj4gPiAr ICAgICAgIH0KPgo+IGZ3bm9kZV9wcm9wZXJ0eV9tYXRjaF9zdHJpbmcoKT8KU29ycnksIGJ1dCBJ IHRoaW5rIHRoZSB1c2Ugb2YgdGhpcyBmdW5jdGlvbiBpcyBkaWZmZXJlbnQgZnJvbSBteSB0YXJn ZXQuCkkgd2FudCB0byByZWFkIHRoZSBzdHJpbmcgb2YgdGhlICJkZWZhdWx0LXN0YXRlIiBwcm9w ZXJ0eSBhbmQgZmlndXJlCm91dCBpZiB0aGUgc3RyaW5nIGlzIGluIHRoZSBzdGF0ZXMgYXJyYXku CkJ1dCB0aGUgZndub2RlX3Byb3BlcnR5X21hdGNoX3N0cmluZyBhaW1lZCB0byBmaWd1cmUgb3V0 IGlmIHRoZSBzdGF0ZQppbiB0aGUgcHJvcGVydHkgYXJyYXkuCk9uZSBpcyBhIHByb3BlcnR5IGFy cmF5IGFuZCBhbm90aGVyIG9uZSBpcyBhIHN0YXRlIGFycmF5Lgo+Cj4gLi4uCj4KPiA+ICsgICAg ICAgaWYgKCFjb3VudCB8fCBjb3VudCA+IE1UNjM3MF9NQVhfTEVEUykgewo+ID4gKyAgICAgICAg ICAgICAgIGRldl9lcnIoJnBkZXYtPmRldiwKPiA+ICsgICAgICAgICAgICAgICAiTm8gY2hpbGQg bm9kZSBvciBub2RlIGNvdW50IG92ZXIgbWF4IGxlZCBudW1iZXIgJWx1XG4iLCBjb3VudCk7Cj4g PiArICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4KPiByZXR1cm4gZGV2X2Vycl9wcm9i ZSguLi4pOwpUaGFua3MsIHdpbGwgcmVmaW5lIGluIHRoZSBuZXcgdmVyc2lvbgo+Cj4gPiArICAg ICAgIH0KPgo+Cj4gLS0KPiBXaXRoIEJlc3QgUmVnYXJkcywKPiBBbmR5IFNoZXZjaGVua28KPgo+ ClNpbmNlcmVseSwKQWxpY2UgQ2hlbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3B5FC43334 for ; Thu, 2 Jun 2022 16:56:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 464451131FE; Thu, 2 Jun 2022 16:56:23 +0000 (UTC) Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by gabe.freedesktop.org (Postfix) with ESMTPS id 428FC10E5BE for ; Thu, 2 Jun 2022 12:07:20 +0000 (UTC) Received: by mail-pf1-x434.google.com with SMTP id y196so4591256pfb.6 for ; Thu, 02 Jun 2022 05:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XwcwX6loUblFTwI5Bhmlqw2TBVsxdFoQXDJc3TovI80=; b=k7esYmpY4T8Q9KWtH0jxmxeHnbiHqRF3LqvsK/4Ug3Jqt1gx+19gOZth9lZtzHsVKs z65zFnDsir6/cGI09w4DESfFBhn0W5yFwcDHUhGt52REfaoXr8Lc3VEDfnfNLuP0/o4D QhmI2Ziwo2TGGYdyx1kXgJ3Stahlm838VXMAuafTcApdKShsfEtVjX9TkbD+0Bn3YGXN cu4WTkIfORLzLsRbi8XMZ5t129tM/R0mlJLffyFB4beE1GnzDQtiOj8V92AdJoeaUJkr MOUy0Z8FtpbwiXb1/kULCSN9k82OaEpM+B4qbR683RScjbId31DRofz7DKXeQlDpP1zH wMRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XwcwX6loUblFTwI5Bhmlqw2TBVsxdFoQXDJc3TovI80=; b=q4vbsQh/rNkYByiHvadYFxks9GZzZv8ZdmmEtoxx22tIEQnYzXem1arEvcJ+9HtWR9 TET2lvI6d8Z5z/uJbxHBX9R0ROriSGKaS6VL8cQjtgc0LQJSbh1r8Jvjvziqn+huYTkX g+RADNKQ/H09k5XJO36Pp6zirTZ3aZsoijAFxey8JicbBuFl8G4VY3bvNlaAtVUEJfBq XvaVSPhszpN5fs0srzq+ePTAw0b4IUqfFr9xmX52GSaScjP+kn0FG/TuEAGwHsjfR9/t cY0UJCdccyOzBN3HDrqFhz1HMzHgoh+Wpy6TRoET3NM1y2+ztL64dPuFtXBI5O5vxJWe bIbw== X-Gm-Message-State: AOAM533hCHeTx52fotfHFs5OQ+XONEJsWmwb/AynZz/bmVnnHE5Jt94K tsME/euNFp9StTuw0Px84HUqS0cFd05LeqFXcWI= X-Google-Smtp-Source: ABdhPJwLN3JLAZweJSj8I9PDnQ5t3UDnCmJ6jzOmk2NgYlJRjY/uTSAVQc8mkFdLPGGc+2hlm0r13u/yFcGFZ+aEYy0= X-Received: by 2002:a63:2c15:0:b0:3f6:6a5f:8f0a with SMTP id s21-20020a632c15000000b003f66a5f8f0amr3954364pgs.76.1654171639739; Thu, 02 Jun 2022 05:07:19 -0700 (PDT) MIME-Version: 1.0 References: <20220531102809.11976-1-peterwu.pub@gmail.com> <20220531102809.11976-8-peterwu.pub@gmail.com> In-Reply-To: From: szuni chen Date: Thu, 2 Jun 2022 20:07:08 +0800 Message-ID: Subject: Re: [PATCH 07/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support To: Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Thu, 02 Jun 2022 16:56:21 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:FRAMEBUFFER LAYER" , "Krogerus, Heikki" , Pavel Machek , alice_chen@richtek.com, linux-iio , dri-devel , Liam Girdwood , cy_huang@richtek.com, Krzysztof Kozlowski , Lee Jones , Linux LED Subsystem , Daniel Thompson , Helge Deller , Rob Herring , Chunfeng Yun , Guenter Roeck , devicetree , Linux PM , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , ChiaEn Wu , linux-arm Mailing List , Jingoo Han , USB , Sebastian Reichel , Linux Kernel Mailing List , chiaen_wu@richtek.com, Greg Kroah-Hartman , Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for the valuable suggestion. Andy Shevchenko =E6=96=BC 2022=E5=B9=B46=E6=9C= =881=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=885:57=E5=AF=AB=E9=81=93= =EF=BC=9A > > On Tue, May 31, 2022 at 1:32 PM ChiaEn Wu wrote: > > > > From: Alice Chen > > > > Add Mediatek MT6370 flashlight support > > Same comments about the commit message. > > ... > > > +#include > > +#include > > +#include > > + blank line? Thanks, this will be refined in the new version. > > > +#include > > + blank line Thanks, this will be refined in the new version. > > > +enum { > > + MT6370_LED_FLASH1, > > + MT6370_LED_FLASH2, > > + MT6370_MAX_LEDS > > +}; > > ... > > > + struct mt6370_led *led =3D container_of(fl_cdev, struct mt6370_= led, > > + flash); > > > + struct mt6370_led *led =3D container_of(fl_cdev, struct mt6370_= led, > > + flash); > > Make a helper out of this > > #define to_mt637_led() container_of() > > and reuse. Thanks, this will be refined in the new version. > > ... > > > + /* > > + * For the flash turn on/off, HW rampping up/down time is 5ms/5= 00us, > > ramping > > > + * respectively > > Period! Thanks, this will be refined in the new version. > > > + */ > > ... > > > + const char * const states[] =3D { "off", "keep", "on" }; > > + const char *str; > > + int ret; > > + > > + if (!fwnode_property_read_string(init_data->fwnode, > > + "default-state", &str)) { > > + ret =3D match_string(states, ARRAY_SIZE(states), str); > > + if (ret < 0) > > + ret =3D STATE_OFF; > > + > > + led->default_state =3D ret; > > + } > > fwnode_property_match_string()? Sorry, but I think the use of this function is different from my target. I want to read the string of the "default-state" property and figure out if the string is in the states array. But the fwnode_property_match_string aimed to figure out if the state in the property array. One is a property array and another one is a state array. > > ... > > > + if (!count || count > MT6370_MAX_LEDS) { > > + dev_err(&pdev->dev, > > + "No child node or node count over max led number %lu\n"= , count); > > + return -EINVAL; > > return dev_err_probe(...); Thanks, will refine in the new version > > > + } > > > -- > With Best Regards, > Andy Shevchenko > > Sincerely, Alice Chen