Re: linux-next: Tree for July 10 (gpio/gpio-tps65910.c)

Re: linux-next: Tree for July 10 (gpio/gpio-tps65910.c)

[Sedat Dilek]

Hi,

I see the same build-error as Randy in latest linux.git
(055c9fa8874fa7261eec7a268366565db84af474).

Where is this patch queued up (see original posting)?
I do not see any patch in [2].
And please please please rename your repo... "linux-2.6" died many
months ago :-).

I also do not see any patch sent to LKML.

Should that all disabled?

CONFIG_GPIO_TPS65910=y
CONFIG_MFD_TPS65910=y
CONFIG_REGULATOR_TPS65910=m

...or is CONFIG_GPIO_TPS65910=n enough to workaround it?

- Sedat -

[1] http://marc.info/?l=linux-kernel&m=134199653428188&w=2
[2] http://git.secretlab.ca/?p=linux-2.6.git;a=summary
[3] http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=blob;f=Next/Trees;#l31

Re: linux-next: Tree for July 10 (gpio/gpio-tps65910.c)

[Linus Walleij]

On Wed, Jul 11, 2012 at 2:29 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:

> I see the same build-error as Randy in latest linux.git
> (055c9fa8874fa7261eec7a268366565db84af474).

Yes, it is there.

> Where is this patch queued up (see original posting)?

Here:
http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=shortlog;h=refs/heads/fixes

> I do not see any patch in [2].

Grant asked me to take over for a while, 10 days ago.

> I also do not see any patch sent to LKML.

But there was such a patch:
http://lkml.org/lkml/2012/7/10/16

And it's queued in my tree and on the for-next branch.

And as noted, I also tried to send it to Linus (Torvalds)
as an update to my last pull request. I guess I'll just have
to send another request.

Yours,
Linus Walleij

Re: linux-next: Tree for July 10 (gpio/gpio-tps65910.c)

[Sedat Dilek]

On Wed, Jul 11, 2012 at 6:39 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Jul 11, 2012 at 2:29 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>
>> I see the same build-error as Randy in latest linux.git
>> (055c9fa8874fa7261eec7a268366565db84af474).
>
> Yes, it is there.
>
>> Where is this patch queued up (see original posting)?
>
> Here:
> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=shortlog;h=refs/heads/fixes
>
>> I do not see any patch in [2].
>
> Grant asked me to take over for a while, 10 days ago.
>
>> I also do not see any patch sent to LKML.
>
> But there was such a patch:
> http://lkml.org/lkml/2012/7/10/16
>
> And it's queued in my tree and on the for-next branch.
>

If you are talking of "queued patches" so please give a pointer to the
patch next time - saves my and others time.

BTW, didn't see your tree in linux-next [1].

In the mean time I have built with CONFIG_*_TPS65910=n successfully.

- Sedat -

[1] http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=blob;f=Next/Trees#l184

> And as noted, I also tried to send it to Linus (Torvalds)
> as an update to my last pull request. I guess I'll just have
> to send another request.
>
> Yours,
> Linus Walleij

Re: linux-next: Tree for July 10 (gpio/gpio-tps65910.c)

[Linus Walleij]

On Wed, Jul 11, 2012 at 9:01 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:

> BTW, didn't see your tree in linux-next [1].
>
> [1] http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=blob;f=Next/Trees#l184

Look at line 185?

Yours,
Linus Walleij

Re: linux-next: Tree for July 10 (gpio/gpio-tps65910.c)

[Sedat Dilek]

On Thu, Jul 12, 2012 at 12:39 PM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> On Wed, Jul 11, 2012 at 9:01 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>
>> BTW, didn't see your tree in linux-next [1].
>>
>> [1] http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=blob;f=Next/Trees#l184
>
> Look at line 185?
>

Yesterday or more precisely next-20120710, your tree was listed at line #184 ...

184 gpio-lw         git
git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git#for-next

linux.git got the patch now and I could build (even I do not need it)
gpio/gpio-tps65910.c successfully.

- Sedat -

[1] http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=blob;f=Next/Trees;hb=refs/tags/next-20120710#l184

> Yours,
> Linus Walleij

Re: linux-next: Tree for July 10 (gpio/gpio-tps65910.c)

[Linus Walleij]

On Wed, Jul 11, 2012 at 7:44 AM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On 07/10/2012 12:43 AM, Stephen Rothwell wrote:
>>
>> Changes since 20120709:
>
> when CONFIG_OF_GPIO is not enabled:
>
> drivers/gpio/gpio-tps65910.c: In function 'tps65910_gpio_probe':
> drivers/gpio/gpio-tps65910.c:152:26: error: 'struct gpio_chip' has no member named 'of_node'

I have a patche queued for this and even attempted to send it to Torvalds.
It will be in tomorrows -next anyway.

Yours,
Linus Walleij

Re: linux-next: Tree for July 10 (gpio/gpio-tps65910.c)

[Randy Dunlap]

On 07/10/2012 12:43 AM, Stephen Rothwell wrote:

> Hi all,
> 
> Changes since 20120709:
> 



on i386:

when CONFIG_OF_GPIO is not enabled:

drivers/gpio/gpio-tps65910.c: In function 'tps65910_gpio_probe':
drivers/gpio/gpio-tps65910.c:152:26: error: 'struct gpio_chip' has no member named 'of_node'



-- 

~Randy