All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sedat Dilek <sedat.dilek@gmail.com>
To: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [3.11-rc7] Building perf-only the "official" way seems to be BROKEN?
Date: Fri, 30 Aug 2013 16:54:08 +0200	[thread overview]
Message-ID: <CA+icZUUyiZXwjBkEtzHGW0sN0fvVDx_wrt5NT2Wuy5hNODk7Ow@mail.gmail.com> (raw)
In-Reply-To: <CA+icZUWNoq2+y511Mk8j_Vmo1_CdTmaG=2nLDz8oh6QPDqr_+A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1771 bytes --]

On Fri, Aug 30, 2013 at 4:28 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> [...]
>
>> [ BUILD PERF-ONLY ]
>>
>> So, I have finished a Linux-kernel build and wanted to build perf
>> (from tools-dir) ONLY!
>>
>> I followed the advices (I am a "good" guy) seen for example in the
>> "tools/Makefile" file.
>>
>> [ tools/Makefile ]
>> ...
>>         @echo 'You can do:'
>>         @echo ' $$ make -C tools/ <tool>_install' <--- NOTE THIS ONE!
>>         @echo ''
>>         @echo '  from the kernel command line to build and install one of'
>>         @echo '  the tools above'
>>         @echo ''
>>         @echo '  $$ make tools/install'
>>         @echo ''
>>         @echo '  installs all tools.'
>> ...
>>
>> OK, so I did this for a perf-only build...
>>
>>
>>    $ LANG=C LC_ALL=C make -C tools/ perf_install 2>&1 | tee ../build-perf.txt
>>
>> ...this breaks like this...
>>
>> ...
>> make[2]: Entering directory
>> `/home/wearefam/src/linux-kernel/linux/tools/lib/traceevent'
>> make[2]: Leaving directory
>> `/home/wearefam/src/linux-kernel/linux/tools/lib/traceevent'
>>     LINK perf
>> gcc: error: /home/wearefam/src/linux-kernel/linux/tools/lib/lk/liblk.a:
>> No such file or directory
>> make[1]: *** [perf] Error 1
>> make[1]: Leaving directory `/home/wearefam/src/linux-kernel/linux/tools/perf'
>> make: *** [perf_install] Error 2
>>
>
> [ From #linux-rt (OFTC) ]
>
> [16:17] <acme> dileks_webchat, there are many, many ways to build the tools
> [16:17] <acme> the one I use is:
> [16:17] <acme> make O=/tmp/build/perf -C tools/perf install
> [16:19] <dileks_webchat> acme:  make -C tools/perf install works as
> expected. interesting :-)
>

Attached patch seems to fix the issue when building perf this way...

   $ make -C tools/ perf_install

- Sedat -

[-- Attachment #2: fix-tools-perf_install-not-building-liblk.diff --]
[-- Type: application/octet-stream, Size: 582 bytes --]

diff --git a/tools/Makefile b/tools/Makefile
index 41067f3..c15f0e7 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -53,7 +53,10 @@ turbostat x86_energy_perf_policy: FORCE
 cpupower_install:
 	$(call descend,power/$(@:_install=),install)
 
-cgroup_install firewire_install lguest_install perf_install usb_install virtio_install vm_install net_install:
+cgroup_install firewire_install lguest_install usb_install virtio_install vm_install net_install:
+	$(call descend,$(@:_install=),install)
+
+perf_install: liblk
 	$(call descend,$(@:_install=),install)
 
 selftests_install:

  reply	other threads:[~2013-08-30 14:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30 12:31 [3.11-rc7] Building perf-only the "official" way seems to be BROKEN? Sedat Dilek
2013-08-30 14:28 ` Sedat Dilek
2013-08-30 14:54   ` Sedat Dilek [this message]
2013-08-30 15:24     ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+icZUUyiZXwjBkEtzHGW0sN0fvVDx_wrt5NT2Wuy5hNODk7Ow@mail.gmail.com \
    --to=sedat.dilek@gmail.com \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.