All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sedat Dilek <sedat.dilek@googlemail.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Chris Metcalf <cmetcalf@tilera.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Helge Deller <deller@gmx.de>,
	Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: linux-next: Tree for July 28 ("copy_from_user_overflow" undefined)
Date: Fri, 29 Jul 2011 20:09:22 +0200	[thread overview]
Message-ID: <CA+icZUWJ=VS6_oqibRbdU0D=TMpEpcB4DNd1i8QUF5MS+4rV8Q@mail.gmail.com> (raw)
In-Reply-To: <4E32F2ED.4020000@codeaurora.org>

On Fri, Jul 29, 2011 at 7:50 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 07/29/2011 02:45 AM, Sedat Dilek wrote:
>> [ CCing all people from 0416 patch ]
>>
>> OK, here a quick review and looking for suspicious commits:
> [snip]
>> -- a/lib/Makefile
>> +++ b/lib/Makefile
>> @@ -14,6 +14,7 @@ lib-y := ctype.o string.o vsprintf.o cmdline.o \
>>          proportions.o prio_heap.o ratelimit.o show_mem.o \
>>          is_single_threaded.o plist.o decompress.o find_next_bit.o
>>
>> +lib-$(CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS) += usercopy.o
>>  lib-$(CONFIG_MMU) += ioremap.o
>>  lib-$(CONFIG_SMP) += cpumask.o
>>
>> So, I can rebuild next-201107{27,28} with
>> CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS=y and look again if the
>> build-breakage in binfmt_misc is gone.
>>
>> Any comments from x86 folk?
>
> I already noticed this and sent a fixup patch to Andrew. Looks like he
> never picked it up. The real fix is to change that lib-$(CONFIG... to
> obj-$(CONFIG...
>
> See https://lkml.org/lkml/2011/7/6/6 for the patch.
>
> --
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
>
>

NO, Andrew didn't do so [1] and that's why the appropriate patch [2]
in linux-next misses it, too.
Grr, your patch is from 05-Jul-2011...

- Sedat -

[1] http://userweb.kernel.org/~akpm/mmotm/broken-out/consolidate-config_debug_strict_user_copy_checks.patch
[2] http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=4df97ff66a102a89ecfa2f88051e30bdd54ad864

  reply	other threads:[~2011-07-29 18:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-28 14:05 linux-next: Tree for July 28 (fs/binfmt_misc.ko) Sedat Dilek
2011-07-28 23:01 ` linux-next: Tree for July 28 ("copy_from_user_overflow" undefined) Randy Dunlap
2011-07-29  1:34   ` Sedat Dilek
2011-07-29  5:09     ` Randy Dunlap
2011-07-29  9:02       ` Sedat Dilek
2011-07-29  9:45         ` Sedat Dilek
2011-07-29 11:07           ` Sedat Dilek
2011-07-29 15:13             ` Randy Dunlap
2011-07-29 15:33               ` Sedat Dilek
2011-07-29 17:50           ` Stephen Boyd
2011-07-29 18:09             ` Sedat Dilek [this message]
2011-07-29 18:21             ` Randy Dunlap
2011-07-29 18:21               ` Randy Dunlap
2011-07-29 18:59               ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+icZUWJ=VS6_oqibRbdU0D=TMpEpcB4DNd1i8QUF5MS+4rV8Q@mail.gmail.com' \
    --to=sedat.dilek@googlemail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=cmetcalf@tilera.com \
    --cc=deller@gmx.de \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rdunlap@xenotime.net \
    --cc=sboyd@codeaurora.org \
    --cc=sedat.dilek@gmail.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.