From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 069BAC04AB4 for ; Tue, 14 May 2019 13:44:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C636B21473 for ; Tue, 14 May 2019 13:44:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="riajmBb6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726013AbfENNo1 (ORCPT ); Tue, 14 May 2019 09:44:27 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:45014 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbfENNo0 (ORCPT ); Tue, 14 May 2019 09:44:26 -0400 Received: by mail-wr1-f65.google.com with SMTP id c5so19256602wrs.11 for ; Tue, 14 May 2019 06:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=U7t9OWgDul1DXrcWJKRj2Op8WI9SAhOi5TTLWWgd0Ys=; b=riajmBb6Emk4JTr9q69MjIzkxUOdEaAp7VRcJ8c80SjV4zRTs57VBGRr2mnajcmHP7 iZAwzufMiZl5bkPznW4IGTE41NrCu8HJf8FbiMSJu9X98PJsW9al4uVyz4eQguewEztv dFx/oCuGuDZeGeWx6K+jUVlIH0R7gf/uQszzMudQZuRNOsG52QkpQS80TLlrc+6x3kQY GxOb2GYiYfbMDmv2yJgRpoqdwtADG5jgZ127KPYjh/8ivOqh4lUR2O3guFeyR3PTz6is moDFqu5jEPETxXSmTObdFYEwCfMCptehsn7r2xio7H5y1SNhGLU3sB4E8fpocmVFUoIF 3Kvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=U7t9OWgDul1DXrcWJKRj2Op8WI9SAhOi5TTLWWgd0Ys=; b=FlKKrGnqiy2GflBJjzMDYPoLDoYTdGH4C54Ay7XaaRxnG+yt3aoa45ClxBQ//OApDw C9/Jx85rsp26QcBcTAfRBGhiggdrj19wwbdPPNEaGnQIl2sflTKhuCU0t1Z/SyqtjhNt EmsztKEH9g1MYDmHyOhozi25lCR1AuQ09GnFFuyD9XGB56IgtVnIqvQI4cE7SAkDvkSv 2hwzgW2mOdfCbBbdg648ctklKrrDkNv9xNLykLGOXKWKHb9uaxFSfeM6vLHdBf78Ozp6 zNqmpfgXtIFsMhyjxoQ6mMA5p4hjC3hphkfK8ifPlQ+8LQUE7XA6e3oNmpNZBB2N1LkH bblA== X-Gm-Message-State: APjAAAUhlTktpjK1oEs5hD2M297EaVs2BOnyyH6gyXYuEWStV2Eqund2 levmUuIN164BNYUfngJGF3QzYkcEOCrke9jVUmM= X-Google-Smtp-Source: APXvYqzdXf3G0V0OCkWiEoKao4toPiFThaoWMWknZbPGTQfpmDOZ/acvD+TPVLujU/sD+FnZpbdscLu0/zmfAANurOU= X-Received: by 2002:adf:9e46:: with SMTP id v6mr10216280wre.141.1557841465392; Tue, 14 May 2019 06:44:25 -0700 (PDT) MIME-Version: 1.0 References: <20190513104358.59716-1-andriy.shevchenko@linux.intel.com> <20190513123751.GS9224@smile.fi.intel.com> <2d39b39b-27eb-abef-747f-400433daefee@intel.com> <4f297fa0-257d-5036-8a1a-0f5434bb5d26@intel.com> In-Reply-To: <4f297fa0-257d-5036-8a1a-0f5434bb5d26@intel.com> Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Tue, 14 May 2019 15:44:13 +0200 Message-ID: Subject: Re: [PATCH v2 00/12] NFC: nxp-nci: clean up and support new ID To: Oleg Zhurakivskyy Cc: Andy Shevchenko , =?UTF-8?Q?Cl=C3=A9ment_Perrochaud?= , Charles Gorand , linux-nfc@lists.01.org, Samuel Ortiz , linux-wireless@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, May 14, 2019 at 3:30 PM Oleg Zhurakivskyy wrote: > > > OK, thanks! > > On 5/14/19 3:03 PM, Sedat Dilek wrote: > > > It's good to keep both informations - preferable put them into the > > Kconfig help text? > > Sure, it's best to keep them both. > While looking at the Kconfig help text; I wonder why... config NFC_NXP_NCI_I2C tristate "NXP-NCI I2C support" depends on NFC_NXP_NCI && I2C ---help--- This module adds support for an I2C interface to the NXP NCI chips. Select this if your platform is using the I2C bus. To compile this driver as a module, choose m here. The module will be called nxp_nci_i2c. Say Y if unsure. Shouldn't that be "Say N if unsure"? Or Say Yes If Sure :-). - Sedat -