From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348AbcCGP7K (ORCPT ); Mon, 7 Mar 2016 10:59:10 -0500 Received: from mail-vk0-f53.google.com ([209.85.213.53]:36067 "EHLO mail-vk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752848AbcCGP7G (ORCPT ); Mon, 7 Mar 2016 10:59:06 -0500 MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com Date: Mon, 7 Mar 2016 16:59:04 +0100 Message-ID: Subject: Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning From: Sedat Dilek To: Alan Stern Cc: Steven Rostedt , Jiri Kosina , Tejun Heo , Lai Jiangshan , Benjamin Tissoires , Paul McKenney , Andy Lutomirski , LKML , USB list , Greg Kroah-Hartman , Peter Zijlstra , Ingo Molnar Content-Type: multipart/mixed; boundary=001a1144f912491072052d778b43 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --001a1144f912491072052d778b43 Content-Type: text/plain; charset=UTF-8 On Sun, Mar 6, 2016 at 6:23 PM, Alan Stern wrote: > On Sat, 5 Mar 2016, Sedat Dilek wrote: > >> On Fri, Mar 4, 2016 at 5:04 PM, Alan Stern wrote: >> > On Wed, 2 Mar 2016, Sedat Dilek wrote: >> > >> >> On 3/1/16, Alan Stern wrote: >> >> > On Tue, 1 Mar 2016, Sedat Dilek wrote: >> >> > >> >> >> On Tue, Oct 13, 2015 at 2:57 AM, Steven Rostedt >> >> >> wrote: >> >> >> > On Sat, 3 Oct 2015 12:05:42 +0200 >> >> >> > Sedat Dilek wrote: >> >> >> > >> >> >> >> So, at the beginning... dunno WTF is causing the problems - no >> >> >> >> workaround for CLANG. >> >> >> > >> >> >> > Probably need to compile with gcc and with clang and look at the binary >> >> >> > differences. Or at least what objdump shows. >> >> >> > >> >> >> >> >> >> [ Hope to address this issue to the correct people - CCed some people >> >> >> I taped on their nerves ] >> >> >> >> >> >> Not sure if I should open a new thread? >> >> >> Please, some clear statements on this. >> >> >> Thanks. >> >> >> >> >> >> The issue is still visible and alive. >> > >> > I think it would be worthwhile to doublecheck the time at which >> > interrupts get disabled. Sedat, please try your plug/unplug the USB >> > mouse test with the patch below. >> > >> > Alan Stern >> > >> > >> > >> > Index: usb-4.4/drivers/hid/usbhid/hid-core.c >> > =================================================================== >> > --- usb-4.4.orig/drivers/hid/usbhid/hid-core.c >> > +++ usb-4.4/drivers/hid/usbhid/hid-core.c >> > @@ -1393,8 +1393,11 @@ static void usbhid_disconnect(struct usb >> > >> > static void hid_cancel_delayed_stuff(struct usbhid_device *usbhid) >> > { >> > + if (raw_irqs_disabled()) pr_info("usbhid irqs disabled A\n"); >> > del_timer_sync(&usbhid->io_retry); >> > + if (raw_irqs_disabled()) pr_info("usbhid irqs disabled B\n"); >> > cancel_work_sync(&usbhid->reset_work); >> > + if (raw_irqs_disabled()) pr_info("usbhid irqs disabled C\n"); >> > } >> > >> > static void hid_cease_io(struct usbhid_device *usbhid) >> > >> >> With your patch I get the dmesg attached. > >> [ 22.234758] usbhid irqs disabled A >> [ 22.234857] usbhid irqs disabled B >> [ 22.234912] BUG: sleeping function called from invalid context atkernel/workqueue.c:2688 > > That's a smoking gun. It means everyone has been looking in the wrong > place. Can you provide an objdump listing of usbhid_close()? The > routine starts like this: > > void usbhid_close(struct hid_device *hid) > { > struct usbhid_device *usbhid = hid->driver_data; > > mutex_lock(&hid_open_mut); > > /* protecting hid->open to make sure we don't restart > * data acquistion due to a resumption we no longer > * care about > */ > spin_lock_irq(&usbhid->lock); > if (!--hid->open) { > spin_unlock_irq(&usbhid->lock); > hid_cancel_delayed_stuff(usbhid); > > It appears that the spin_unlock_irq() call isn't working. > > For extra thoroughness, try putting one of those raw_irqs_disabled() > checks just before and one just after the spin_lock_irq() line above. > Maybe also before the mutex_lock() line. > > Alan Stern > Hmm, we are there where I was looking at... Please, read the reply of Jiri [1], we did some tweaking. With CONFIG_FTRACE=n and CONFIG_PROVE_LOCKING=n ! *** Part one: ObjectDump of hid-core.o *** $ objdump -D drivers/hid/usbhid/hid-core.o | awk '/<[^>]*>:$/ { p=0; } /:/ { p=1; } { if (p) print $0; }' > ../objdump-D_hid-core_o_usbhid_close_$(uname -r).txt $ cat ../objdump-D_hid-core_o_usbhid_close_4.4.4-1-iniza-small.txt 00000000000002e0 : 2e0: 55 push %rbp 2e1: 48 89 e5 mov %rsp,%rbp 2e4: 41 57 push %r15 2e6: 41 56 push %r14 2e8: 41 54 push %r12 2ea: 53 push %rbx 2eb: 49 89 ff mov %rdi,%r15 2ee: 4d 8b b7 e8 1e 00 00 mov 0x1ee8(%r15),%r14 2f5: 48 c7 c7 00 00 00 00 mov $0x0,%rdi 2fc: 31 f6 xor %esi,%esi 2fe: e8 00 00 00 00 callq 303 303: 49 8d 9e 88 28 00 00 lea 0x2888(%r14),%rbx 30a: 48 89 df mov %rbx,%rdi 30d: e8 00 00 00 00 callq 312 312: 41 ff 8f e4 1d 00 00 decl 0x1de4(%r15) 319: 9c pushfq 31a: 41 5c pop %r12 31c: 48 89 df mov %rbx,%rdi 31f: e8 00 00 00 00 callq 324 324: 41 54 push %r12 326: 9d popfq 327: 75 23 jne 34c 329: 4c 89 f7 mov %r14,%rdi 32c: e8 3f 00 00 00 callq 370 331: 41 f6 87 b9 1d 00 00 testb $0x4,0x1db9(%r15) 338: 04 339: 75 11 jne 34c 33b: 49 8b 7e 18 mov 0x18(%r14),%rdi 33f: e8 00 00 00 00 callq 344 344: 49 8b 46 08 mov 0x8(%r14),%rax 348: 80 60 28 f7 andb $0xf7,0x28(%rax) 34c: 48 c7 c7 00 00 00 00 mov $0x0,%rdi 353: e8 00 00 00 00 callq 358 358: 5b pop %rbx 359: 41 5c pop %r12 35b: 41 5e pop %r14 35d: 41 5f pop %r15 35f: 5d pop %rbp 360: c3 retq 361: 66 66 66 66 66 66 2e data32 data32 data32 data32 data32 nopw %cs:0x0(%rax,%rax,1) 368: 0f 1f 84 00 00 00 00 36f: 00 *** Part two: Double-checking (after TV-adds) *** - Sedat - [1] https://marc.info/?l=linux-input&m=144359852905747&w=2 --001a1144f912491072052d778b43 Content-Type: text/plain; charset=US-ASCII; name="objdump-D_hid-core_o_usbhid_close_4.4.4-1-iniza-small.txt" Content-Disposition: attachment; filename="objdump-D_hid-core_o_usbhid_close_4.4.4-1-iniza-small.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ili63ifo0 MDAwMDAwMDAwMDAwMDJlMCA8dXNiaGlkX2Nsb3NlPjoKICAgICAyZTA6CTU1ICAgICAgICAgICAg ICAgICAgIAlwdXNoICAgJXJicAogICAgIDJlMToJNDggODkgZTUgICAgICAgICAgICAgCW1vdiAg ICAlcnNwLCVyYnAKICAgICAyZTQ6CTQxIDU3ICAgICAgICAgICAgICAgIAlwdXNoICAgJXIxNQog ICAgIDJlNjoJNDEgNTYgICAgICAgICAgICAgICAgCXB1c2ggICAlcjE0CiAgICAgMmU4Ogk0MSA1 NCAgICAgICAgICAgICAgICAJcHVzaCAgICVyMTIKICAgICAyZWE6CTUzICAgICAgICAgICAgICAg ICAgIAlwdXNoICAgJXJieAogICAgIDJlYjoJNDkgODkgZmYgICAgICAgICAgICAgCW1vdiAgICAl cmRpLCVyMTUKICAgICAyZWU6CTRkIDhiIGI3IGU4IDFlIDAwIDAwIAltb3YgICAgMHgxZWU4KCVy MTUpLCVyMTQKICAgICAyZjU6CTQ4IGM3IGM3IDAwIDAwIDAwIDAwIAltb3YgICAgJDB4MCwlcmRp CiAgICAgMmZjOgkzMSBmNiAgICAgICAgICAgICAgICAJeG9yICAgICVlc2ksJWVzaQogICAgIDJm ZToJZTggMDAgMDAgMDAgMDAgICAgICAgCWNhbGxxICAzMDMgPHVzYmhpZF9jbG9zZSsweDIzPgog ICAgIDMwMzoJNDkgOGQgOWUgODggMjggMDAgMDAgCWxlYSAgICAweDI4ODgoJXIxNCksJXJieAog ICAgIDMwYToJNDggODkgZGYgICAgICAgICAgICAgCW1vdiAgICAlcmJ4LCVyZGkKICAgICAzMGQ6 CWU4IDAwIDAwIDAwIDAwICAgICAgIAljYWxscSAgMzEyIDx1c2JoaWRfY2xvc2UrMHgzMj4KICAg ICAzMTI6CTQxIGZmIDhmIGU0IDFkIDAwIDAwIAlkZWNsICAgMHgxZGU0KCVyMTUpCiAgICAgMzE5 Ogk5YyAgICAgICAgICAgICAgICAgICAJcHVzaGZxIAogICAgIDMxYToJNDEgNWMgICAgICAgICAg ICAgICAgCXBvcCAgICAlcjEyCiAgICAgMzFjOgk0OCA4OSBkZiAgICAgICAgICAgICAJbW92ICAg ICVyYngsJXJkaQogICAgIDMxZjoJZTggMDAgMDAgMDAgMDAgICAgICAgCWNhbGxxICAzMjQgPHVz YmhpZF9jbG9zZSsweDQ0PgogICAgIDMyNDoJNDEgNTQgICAgICAgICAgICAgICAgCXB1c2ggICAl cjEyCiAgICAgMzI2Ogk5ZCAgICAgICAgICAgICAgICAgICAJcG9wZnEgIAogICAgIDMyNzoJNzUg MjMgICAgICAgICAgICAgICAgCWpuZSAgICAzNGMgPHVzYmhpZF9jbG9zZSsweDZjPgogICAgIDMy OToJNGMgODkgZjcgICAgICAgICAgICAgCW1vdiAgICAlcjE0LCVyZGkKICAgICAzMmM6CWU4IDNm IDAwIDAwIDAwICAgICAgIAljYWxscSAgMzcwIDxoaWRfY2FuY2VsX2RlbGF5ZWRfc3R1ZmY+CiAg ICAgMzMxOgk0MSBmNiA4NyBiOSAxZCAwMCAwMCAJdGVzdGIgICQweDQsMHgxZGI5KCVyMTUpCiAg ICAgMzM4OgkwNCAKICAgICAzMzk6CTc1IDExICAgICAgICAgICAgICAgIAlqbmUgICAgMzRjIDx1 c2JoaWRfY2xvc2UrMHg2Yz4KICAgICAzM2I6CTQ5IDhiIDdlIDE4ICAgICAgICAgIAltb3YgICAg MHgxOCglcjE0KSwlcmRpCiAgICAgMzNmOgllOCAwMCAwMCAwMCAwMCAgICAgICAJY2FsbHEgIDM0 NCA8dXNiaGlkX2Nsb3NlKzB4NjQ+CiAgICAgMzQ0Ogk0OSA4YiA0NiAwOCAgICAgICAgICAJbW92 ICAgIDB4OCglcjE0KSwlcmF4CiAgICAgMzQ4Ogk4MCA2MCAyOCBmNyAgICAgICAgICAJYW5kYiAg ICQweGY3LDB4MjgoJXJheCkKICAgICAzNGM6CTQ4IGM3IGM3IDAwIDAwIDAwIDAwIAltb3YgICAg JDB4MCwlcmRpCiAgICAgMzUzOgllOCAwMCAwMCAwMCAwMCAgICAgICAJY2FsbHEgIDM1OCA8dXNi aGlkX2Nsb3NlKzB4Nzg+CiAgICAgMzU4Ogk1YiAgICAgICAgICAgICAgICAgICAJcG9wICAgICVy YngKICAgICAzNTk6CTQxIDVjICAgICAgICAgICAgICAgIAlwb3AgICAgJXIxMgogICAgIDM1YjoJ NDEgNWUgICAgICAgICAgICAgICAgCXBvcCAgICAlcjE0CiAgICAgMzVkOgk0MSA1ZiAgICAgICAg ICAgICAgICAJcG9wICAgICVyMTUKICAgICAzNWY6CTVkICAgICAgICAgICAgICAgICAgIAlwb3Ag ICAgJXJicAogICAgIDM2MDoJYzMgICAgICAgICAgICAgICAgICAgCXJldHEgICAKICAgICAzNjE6 CTY2IDY2IDY2IDY2IDY2IDY2IDJlIAlkYXRhMzIgZGF0YTMyIGRhdGEzMiBkYXRhMzIgZGF0YTMy IG5vcHcgJWNzOjB4MCglcmF4LCVyYXgsMSkKICAgICAzNjg6CTBmIDFmIDg0IDAwIDAwIDAwIDAw IAogICAgIDM2ZjoJMDAgCgo= --001a1144f912491072052d778b43--